facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 15:27:13 +03:00
Code Issues Projects Releases Wiki Activity

stop calling hg debugedenimporthelper with an extra repo argument

Browse Source 
Summary:
This argument is unnecessary since D14222323, which should be deployed
everywhere by now.  Passing in the extra repo argument forces hg to open the
repository object twice, which is unnecessary.

We already set the current working directory to the repository when invoking
the import helper, so hg will find the repository correctly from that.

Reviewed By: pkaush

Differential Revision: D15179667

fbshipit-source-id: 838cbee91748c41c713731187608a9823b971a53
This commit is contained in:
Adam Simpkins 2019-05-02 20:37:41 -07:00 committed by Facebook Github Bot
parent f0b14c5139
commit f497a29d04
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
eden/fs/store/hg/HgImporter.cpp
View File

@ -259,15 +259,15 @@ HgImporter::HgImporter(
// primarily in our integration tests.
if (importHelperScript.has_value()) {
cmd.push_back(importHelperScript.value().value());
cmd.push_back(repoPath.value().str());
} else if (FLAGS_hgImportUseDebugSubcommand) {
cmd.push_back(FLAGS_hgPath);
cmd.push_back("debugedenimporthelper");
} else {
cmd.push_back(getImportHelperPath().value());
cmd.push_back(repoPath.value().str());
}
cmd.push_back(repoPath.value().str());
#ifndef EDEN_WIN
cmd.push_back("--out-fd");
cmd.push_back(folly::to<string>(HELPER_PIPE_FD));