edenfs: add missing cmake edencommon dependency (#691)

Summary:
edenfs: add missing cmake edencommon dependency

edenfs was missing a declared dep on edencommon in the rpc code CMakeLists.txt, this fixed missing edencommon headers

Pull Request resolved: https://github.com/facebook/sapling/pull/691

Test Plan:
Build locally: `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden`

Before:
```
FAILED: eden/fs/nfs/portmap/CMakeFiles/eden_nfs_portmap_server.dir/Rpcbindd.cpp.o
/usr/bin/c++  -DBOOST_ALL_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\"/home/alex/local/sapling:/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden\" -DGFLAGS_IS_A_DLL=0 -I. -I/home/alex/local/sapling -I/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fb303/include -I/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fizz/include -I/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/wangle/include -I/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fbthrift/include -I/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/blake3-lrolsLBeklWWBLYfMM4fF2TJGwCeReSgHBUbEgA3TFw/include -isystem /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/folly/include -isystem /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fmt-_ZorQJC2eeu9K7XicUjMKUe54C8sh6ZsaDZIZfQ_QmE/include -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations -Wno-nullability-completeness -Wno-unknown-pragmas -O2 -g -DNDEBUG   -pthread -std=gnu++17 -MD -MT eden/fs/nfs/portmap/CMakeFiles/eden_nfs_portmap_server.dir/Rpcbindd.cpp.o -MF eden/fs/nfs/portmap/CMakeFiles/eden_nfs_portmap_server.dir/Rpcbindd.cpp.o.d -o eden/fs/nfs/portmap/CMakeFiles/eden_nfs_portmap_server.dir/Rpcbindd.cpp.o -c /home/alex/local/sapling/eden/fs/nfs/portmap/Rpcbindd.cpp
In file included from /home/alex/local/sapling/eden/fs/nfs/portmap/Rpcbindd.h:14,
                 from /home/alex/local/sapling/eden/fs/nfs/portmap/Rpcbindd.cpp:8:
/home/alex/local/sapling/eden/fs/utils/PathFuncs.h:24:10: fatal error: eden/common/utils/StringConv.h: No such file or directory
   24 | #include "eden/common/utils/StringConv.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
```

After, works and gets to the next error, see next in stack

 ---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/691).
* https://github.com/facebook/sapling/issues/693
* https://github.com/facebook/sapling/issues/696
* https://github.com/facebook/sapling/issues/692
* __->__ https://github.com/facebook/sapling/issues/691
* https://github.com/facebook/sapling/issues/682
* https://github.com/facebook/sapling/issues/689
* https://github.com/facebook/sapling/issues/697
* https://github.com/facebook/sapling/issues/706
* https://github.com/facebook/sapling/issues/730

Reviewed By: xavierd

Differential Revision: D49874584

Pulled By: genevievehelsel

fbshipit-source-id: cc55efff959f6230bdd3c6dd01d16a02db472a48
This commit is contained in:
Alex Hornby 2023-10-06 21:20:06 -07:00 committed by Facebook GitHub Bot
parent ceccbc1682
commit f63a41bd25

View File

@ -14,6 +14,7 @@ target_link_libraries(
PUBLIC
eden_nfs_rpc
Folly::folly
edencommon::edencommon_utils
)
add_library(