facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 06:18:07 +03:00
Code Issues Projects Releases Wiki Activity

Remove per request blobstore qps in scs tunable

Browse Source 
Summary:
This tunable controls the amount or blobsotre reads and writes within a single request.
Since it was set in January 2021 (3 years ago) (https://www.internalfb.com/code/configerator/[773df72c41aa]/source/scm/mononoke/tunables/default.cconf?lines=70-71) it has not been changed, so removing it and setting it to the specified value in configerator

Reviewed By: mzr

Differential Revision: D50968709

fbshipit-source-id: c713e0ffde42aab379a3cb6486fab77c1fb506d7
This commit is contained in:
Clara Rull 2023-11-03 07:58:32 -07:00 committed by Facebook GitHub Bot
parent 6fe1903eb6
commit feb9a818ba
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
eden/mononoke/scs_server/src/source_control_impl.rs
View File

@ -72,6 +72,8 @@ const FORWARDED_IDENTITIES_HEADER: &str = "scm_forwarded_identities";
const FORWARDED_CLIENT_IP_HEADER: &str = "scm_forwarded_client_ip";
const FORWARDED_CLIENT_DEBUG_HEADER: &str = "scm_forwarded_client_debug";
const FORWARDED_OTHER_CATS_HEADER: &str = "scm_forwarded_other_cats";
const PER_REQUEST_READ_QPS: usize = 4000;
const PER_REQUEST_WRITE_QPS: usize = 4000;
define_stats! {
prefix = "mononoke.scs_server";
@ -320,11 +322,9 @@ impl SourceControlServiceImpl {
let metadata = self.create_metadata(req_ctxt).await?;
let session = SessionContainer::builder(self.fb)
.metadata(Arc::new(metadata))
.blobstore_maybe_read_qps_limiter(tunables().scs_request_read_qps().unwrap_or_default())
.blobstore_maybe_read_qps_limiter(PER_REQUEST_READ_QPS)
.await
.blobstore_maybe_write_qps_limiter(
tunables().scs_request_write_qps().unwrap_or_default(),
)
.blobstore_maybe_write_qps_limiter(PER_REQUEST_WRITE_QPS)
.await
.build();
Ok(session)