Commit Graph

57 Commits

Author SHA1 Message Date
Siddharth Agarwal
81f2ac473b make bookmark error type implement std::error::Error
Summary: All its users need this, and it makes sense.

Reviewed By: jsgf

Differential Revision: D5847753

fbshipit-source-id: 042c7b5637e5f83918fa9bc5d131c8745d7bbc3e
2017-09-18 00:35:52 -07:00
Siddharth Agarwal
a74542da60 update and pull in uuid + subprocess
Summary:
Finally got an update working by removing the `mysql_async` crate.

Some notes:

* The `mysql_async` crate was responsible in this case: see https://github.com/rust-lang/cargo/issues/4066#issuecomment-328210204 for why.
* tokio/futures deprecated a bunch of stuff. I've filed a TODO for now.
* We finally pulled in error-chain 0.11, which has a bunch of nice improvements.

Reviewed By: kulshrax

Differential Revision: D5798282

fbshipit-source-id: a38a7b17ee0205428e2ea63334722aa408582493
2017-09-08 17:05:38 -07:00
Arun Kulshreshtha
8b6310dcef Switch from url to percent_encoding crate in FileBookmarks
Summary:
The url::percent_encoding module was split into its own crate. Use
that instead.

Reviewed By: jsgf

Differential Revision: D5769525

fbshipit-source-id: 4d95c5d791e486f56a16091ffa5114b3cfbfd47e
2017-09-07 10:50:55 -07:00
Jeremy Fitzhardinge
144bea971a mononoke: bookmarks: add helpers for boxing Bookmarks trait objects
Summary:
Add BoxedBookmark to assist in boxing a Bookmark trait, and implement Bookmark
for Box<_> and Arc<_> Bookmark trait objects.

Reviewed By: sid0

Differential Revision: D5540675

fbshipit-source-id: 7582adbd2858f6814d57b7e54089b922886a4d54
2017-08-02 17:43:24 -07:00
Jeremy Fitzhardinge
09b25e1507 mononoke: bookmarks: fold ListBookmarks into Bookmarks
Summary:
In practice, no users of Bookmarks will not want listing, and all
implementations need to be able to support it.

Reviewed By: StanislavGlebik

Differential Revision: D5540672

fbshipit-source-id: d64a3894c7cd14d329bd23809525935461289bc3
2017-08-02 17:43:24 -07:00
Jeremy Fitzhardinge
6cfc6704b6 mononoke: stockbookmarks: make Error a parameter
Summary: Allow the error type to be any type the internal errors can be converted to.

Reviewed By: sid0

Differential Revision: D5540671

fbshipit-source-id: 1077132d25bcc13ba2a3a509c916f2e07ac10dcf
2017-08-02 17:43:24 -07:00
facebook-github-bot
2b6af6b941 Initial commit
fbshipit-source-id: f75baa4ff6aa71973f677b752d7aba582cf4927f
2017-07-27 18:00:19 -07:00