Lukas Piatkowski
3d1587c3da
rust-shed: add secure_utils to the shed
...
Reviewed By: StanislavGlebik
Differential Revision: D21549859
fbshipit-source-id: 0e143354a60578732ae1eed8c3c71b9f859e3958
2020-06-03 13:16:23 -07:00
svcscm
5dfc002377
Updating submodules
...
Summary:
GitHub commits:
519a07cfb6
31a8928a32
8639ca9194
19443ec091
d03e3b7fb5
0f41388773
ffe08ffcc2
7d7a5c2009
a1183f94c8
8d40a7c34c
99736471c8
6d7396f7d3
a024b0947c
Reviewed By: yns88
fbshipit-source-id: f8561a4b63578967f2e05838be4a115212a4b1ad
2020-06-03 13:08:14 -07:00
Zhengxu Chen
2905f6dbf2
Specify error handler for text encoding in logging functions.
...
Summary: Currently output from build command is decoded with "surrogateescape" error handler, but when writing to log files/stdout we don't specify error handlers to be also "surrogateescape" according to https://docs.python.org/3/library/codecs.html#error-handlers , which could cause exception when there's surrogate characters logged in message.
Reviewed By: yfeldblum
Differential Revision: D21850411
fbshipit-source-id: 21c51d1ab2132171ae29f2d1fbe42655ebee94c5
2020-06-03 11:27:46 -07:00
Victor Zverovich
f9c4acfa84
Update fmt version to 6.2.1
...
Summary:
Update fmt version to 6.2.1 for better compatibility with the version used in fbcode. Among other things this fixes fbthrift build failure on Travis:
```
/home/fbthrift/thrift/lib/cpp2/async/RocketClientChannel.cpp:70:67: required from here
/home/install/include/fmt/core.h:492:3: error: static assertion failed: don't know how to format the type, include fmt/ostream.h if it provides an operator<< that should be used
```
which is caused by trying to format an enum class without a formatter - only supported as of 6.0.
Reviewed By: stevegury, avalonalex
Differential Revision: D21860076
fbshipit-source-id: 1857ab65822956b005980b8dfff7a967508f507c
2020-06-03 09:48:54 -07:00
svcscm
932a4dd6e1
Updating submodules
...
Summary:
GitHub commits:
f2bdd2f1da
Reviewed By: yns88
fbshipit-source-id: d7632eeb47ff2cd8f6186ea70aa9482a796ece45
2020-06-03 05:55:05 -07:00
svcscm
afcc4f8582
Updating submodules
...
Summary:
GitHub commits:
5426462841
4584299ad1
Reviewed By: yns88
fbshipit-source-id: 5870af19bc87a81672603c6a81eef746754ca193
2020-06-03 04:21:22 -07:00
svcscm
777c519fd6
Updating submodules
...
Summary:
GitHub commits:
24bccacfd9
Reviewed By: yns88
fbshipit-source-id: 8600bfbffca48b054e25a3211a28cee2dfb71bd7
2020-06-03 00:36:59 -07:00
svcscm
716af75014
Updating submodules
...
Summary:
GitHub commits:
0268a536a9
1e2c3e4011
Reviewed By: yns88
fbshipit-source-id: fb9013c64c4d6ebea74eb4fdaf256dc45bd87248
2020-06-02 19:34:17 -07:00
svcscm
d73bbe077d
Updating submodules
...
Summary:
GitHub commits:
5a189ae9db
6647e5c591
Reviewed By: yns88
fbshipit-source-id: 97475849c3f7f3722c410a8689f7ed42ae129fd5
2020-06-02 19:17:52 -07:00
svcscm
4e127097cb
Updating submodules
...
Summary:
GitHub commits:
2f396fc8e0
f4740f0fd5
60e07c2ee4
2adb7e3768
50c868242b
bd689dc721
6799467cb7
Reviewed By: yns88
fbshipit-source-id: 3496c537c7cec32b1d34dbdda692f037609d3339
2020-06-02 16:44:49 -07:00
svcscm
6fa8683681
Updating submodules
...
Summary:
GitHub commits:
f520b6a2b1
5189706a2b
Reviewed By: yns88
fbshipit-source-id: 1855a9020df0160c61c93700c333d67d04c54a44
2020-06-02 11:17:52 -07:00
svcscm
36034b5903
Updating submodules
...
Summary:
GitHub commits:
580386f856
dc6b480825
Reviewed By: yns88
fbshipit-source-id: 73911e4b6c27d285ddcf99aedb85a017aec71f4a
2020-06-02 08:07:23 -07:00
svcscm
73af8761d5
Updating submodules
...
Summary:
GitHub commits:
a70a495361
d30944f126
7a50ca13c7
Reviewed By: yns88
fbshipit-source-id: ffd89c7e1ad51f21114b6badbc06ff0af5162b30
2020-06-02 06:43:17 -07:00
svcscm
a2db0d0905
Updating submodules
...
Summary:
GitHub commits:
96a7070eac
1606d9184a
Reviewed By: yns88
fbshipit-source-id: 09a6f88080c8ea3f1d6fd0394e74a77bd8b9ed37
2020-06-02 01:46:07 -07:00
svcscm
fdd3bd1b6c
Updating submodules
...
Summary:
GitHub commits:
784fb075be
23c1595805
f074558a2d
36e354b0c3
2fc21e9839
02f59ed669
075cc25761
3ee20671d8
dc02ad55db
Reviewed By: yns88
fbshipit-source-id: 26daed81de47807ebc486d1557fc2297b14f12c4
2020-06-01 17:30:09 -07:00
svcscm
595bcc2eff
Updating submodules
...
Summary:
GitHub commits:
06274a0d8d
2e0b0315f7
bc0d9d254c
99c4ed49e0
cf22ebfe9b
22d30fc25e
Reviewed By: yns88
fbshipit-source-id: 4a9e856583e923c705e3d721f858ee3ca74d9639
2020-06-01 14:50:11 -07:00
svcscm
af284d0de9
Updating submodules
...
Summary:
GitHub commits:
9caa77ba66
a840016d0e
d539a73191
Reviewed By: yns88
fbshipit-source-id: f136847503e4c70d57b1f24b2dfc50508955140c
2020-06-01 11:28:24 -07:00
svcscm
6fa8ff80dd
Updating submodules
...
Summary:
GitHub commits:
f6784e4283
48bb5a4342
Reviewed By: yns88
fbshipit-source-id: 77a37aee961b58c96127a3f5e230f51e8e7e3e9d
2020-06-01 10:39:34 -07:00
svcscm
8bc207b768
Updating submodules
...
Summary:
GitHub commits:
082c96dd33
a255651f51
Reviewed By: wittgenst
fbshipit-source-id: e6120ba88da4095c20c5c05dafd4849f5b2eb0a5
2020-06-01 09:03:55 -07:00
svcscm
2363833947
Updating submodules
...
Summary:
GitHub commits:
24834bbaee
a69ad1c401
f8974e8273
62f53377fd
144bfbe1dd
20807e41de
7d673046a6
aed8bb3e04
Reviewed By: wittgenst
fbshipit-source-id: af4a695712c1b53386118068a8454157c2ba6e97
2020-06-01 02:17:50 -07:00
svcscm
f3c930db16
Updating submodules
...
Summary:
GitHub commits:
8f91f84803
617a252e90
377c316aa0
Reviewed By: wittgenst
fbshipit-source-id: 911874b032e2a01190636c5008fd06c0080ee7f4
2020-06-01 01:38:58 -07:00
svcscm
2fa6da1efc
Updating submodules
...
Summary:
GitHub commits:
a9b90b9f87
c367a12920
Reviewed By: wittgenst
fbshipit-source-id: 009f245733795498bfe1c971a375127f79b8451b
2020-05-31 16:26:46 -07:00
svcscm
dba1a66340
Updating submodules
...
Summary:
GitHub commits:
df6fbfb120
4916927343
38ed706256
2dfa4fbe4d
ae08ad24e8
Reviewed By: wittgenst
fbshipit-source-id: 54e96660e945e3ebfed644aa5e5860ccc53c0779
2020-05-30 22:25:58 -07:00
svcscm
71dff880d9
Updating submodules
...
Summary:
GitHub commits:
25c055e0b6
Reviewed By: wittgenst
fbshipit-source-id: b43bdf6bfe5ff20157bd6bfab5f8f82e19eeb094
2020-05-29 22:02:30 -07:00
svcscm
60c23bcf70
Updating submodules
...
Summary:
GitHub commits:
dc1a385e67
1544932587
1ec10a60ab
Reviewed By: wittgenst
fbshipit-source-id: 4694382d982197e38042c2fdbfbaa085c0f8c6c1
2020-05-29 15:45:09 -07:00
svcscm
cb09b2214f
Updating submodules
...
Summary:
GitHub commits:
cd1f764334
8f13bf87d2
Reviewed By: wittgenst
fbshipit-source-id: b0b63634a37f9fbe5d56f617a006eb6d96f7caae
2020-05-29 13:35:40 -07:00
svcscm
2b5163fc42
Updating submodules
...
Summary:
GitHub commits:
23851596f1
e03159028c
011b1c54e5
65603f1e75
c1f9688882
0c56fc4d66
b38f85c31b
c011b36a5a
31d1a244d6
1b3055711f
5e88317ea6
d17b5f7b31
Reviewed By: wittgenst
fbshipit-source-id: 3255cd0e86dc3c45f00d4e52db1158513af561a0
2020-05-29 12:41:56 -07:00
svcscm
dae04e6a07
Updating submodules
...
Summary:
GitHub commits:
a1299f09fd
1492869dbd
e5884ae697
6840cc81cb
0494985a1f
6deae0ce10
2f958aa74e
c5abf78bca
60b836e2bf
48f49ea448
9ae8fb988c
b1cb1d32af
61db7f5147
cb4dccfcc0
Reviewed By: wittgenst
fbshipit-source-id: f604bb170c50a73854eeb868b6c2a5f72d29c8e7
2020-05-29 11:01:03 -07:00
svcscm
b592b8effd
Updating submodules
...
Summary:
GitHub commits:
e0360afe03
Reviewed By: wittgenst
fbshipit-source-id: 2513aed8b08e75d3110747abfecb7248ff664630
2020-05-28 07:19:51 -07:00
svcscm
5874113298
Updating submodules
...
Summary:
GitHub commits:
d976f45ee0
dd570fb3cf
e67de4176c
Reviewed By: wittgenst
fbshipit-source-id: e010f4ec11c7666daad946bc3e5e792b03ff3063
2020-05-28 03:03:43 -07:00
svcscm
7266c29b7d
Updating submodules
...
Summary:
GitHub commits:
984efa75a3
cebecbbaff
0dedce9c3a
3b09ae7f66
59fcae89e3
f91de18ae4
20a7ef9858
7abc8e4594
ed20eb0e18
6fd5b8dfae
37add01a38
fca73296da
Reviewed By: wittgenst
fbshipit-source-id: dff9e170dcd2a81dd361c4bdc55aa8dfe90e1d4c
2020-05-27 21:11:30 -07:00
svcscm
6ba00d708d
Updating submodules
...
Summary:
GitHub commits:
28cfb68041
e844b95a8b
72c5bd8a02
bcefc59e9f
0eb6489e21
Reviewed By: wittgenst
fbshipit-source-id: 3fc62a72f8cdd51d1243274fb493465d4801aee4
2020-05-27 13:42:17 -07:00
svcscm
3d126c54b6
Updating submodules
...
Summary:
GitHub commits:
e1c7e6ce96
25cd078ee5
Reviewed By: wittgenst
fbshipit-source-id: 7d500ed8b8b8b1c16c6006880b51b24c23c5804f
2020-05-27 10:45:35 -07:00
svcscm
4c81a9ab6e
Updating submodules
...
Summary:
GitHub commits:
d743571943
8ab7b72558
Reviewed By: wittgenst
fbshipit-source-id: f26c310f970d09297c27042dfa91b1fe20d849e7
2020-05-27 08:53:23 -07:00
svcscm
7e4ec91e8f
Updating submodules
...
Summary:
GitHub commits:
f4ec3998d8
Reviewed By: wittgenst
fbshipit-source-id: e07920315ac63edf6457ee19b2061255aee91ac6
2020-05-26 23:04:44 -07:00
svcscm
e678c2730d
Updating submodules
...
Summary:
GitHub commits:
ee33ca6a34
39740ea64b
Reviewed By: wittgenst
fbshipit-source-id: 15699f4d930741ed5bbaa2aa79f0377791f51cbd
2020-05-26 18:09:22 -07:00
svcscm
d05dd60087
Updating submodules
...
Summary:
GitHub commits:
c20846234b
ad1c3b8efe
92f510c83b
0ddc1a2fff
82a82c76e7
Reviewed By: wittgenst
fbshipit-source-id: aeef80444b40ad65e2ed89ff419878ae563c177d
2020-05-26 17:20:34 -07:00
svcscm
94f2a7d235
Updating submodules
...
Summary:
GitHub commits:
81c41ef1f6
b5ec32d2b1
b09ee1a03c
Reviewed By: wittgenst
fbshipit-source-id: d7c53165454afe1ae4595cf402a4e1dc76bafa56
2020-05-26 17:20:34 -07:00
svcscm
20a756f1a5
Updating submodules
...
Summary:
GitHub commits:
fb0ccbb6aa
774673fbd2
44e5cfcca4
9554a67c73
Reviewed By: wittgenst
fbshipit-source-id: 3bc67d8ee3f409d422dd393cf949e4d802a6ac95
2020-05-26 13:47:19 -07:00
svcscm
3173bb25c8
Updating submodules
...
Summary:
GitHub commits:
e69b649453
7d97a671aa
bc44b0f07d
545f4fc1c1
85f9aafb64
5267abf80e
df2f1779db
Reviewed By: wittgenst
fbshipit-source-id: dc3b4dcf07c36545428356018ccd2ab769d0843e
2020-05-26 02:36:12 -07:00
svcscm
cc12206e49
Updating submodules
...
Summary:
GitHub commits:
213c4ed5b4
1d0b0d98cd
9043fd7559
d65ffba71e
a395ae3d31
bd68bfb41b
f187cd3ec0
Reviewed By: wittgenst
fbshipit-source-id: a122bc5dbcc57e018e2daf1ac19f53859a3424f4
2020-05-26 00:29:16 -07:00
svcscm
06f32fa94e
Updating submodules
...
Summary:
GitHub commits:
71dbf454c9
7e4f99fc6f
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 45c5a4ea86e82eed15ebe79ac542b3a90183f4b9
2020-05-25 22:23:39 -07:00
svcscm
ab13dfc04a
Updating submodules
...
Summary:
GitHub commits:
3139f52cb0
b408eaadae
4091de5e08
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: f14e0475ad4dc0e5555f0fbe37f5b36339cceef1
2020-05-25 07:24:32 -07:00
svcscm
f86cff6e22
Updating submodules
...
Summary:
GitHub commits:
9db970345d
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 48d989adf41319527b4480fbea081e2079b3cf14
2020-05-24 14:23:17 -07:00
svcscm
47a8bd05d7
Updating submodules
...
Summary:
GitHub commits:
ac5666bd7d
d5ce6e820b
558c49789f
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: a016ba866d2996169de881377af59ccf85cecb13
2020-05-23 15:33:15 -07:00
svcscm
d2484b4bb3
Updating submodules
...
Summary:
GitHub commits:
44ff9b5003
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: b8a6d0afa64ccdbb45362f7d61899d5cb0142e31
2020-05-23 01:23:54 -07:00
svcscm
6a871bb4d8
Updating submodules
...
Summary:
GitHub commits:
070df52dd0
c4f10fe40a
7945e61cf0
93d952a945
955e1bf5d0
f23ada231b
9504676f7f
78c6f87ce3
981e8f7255
058217dd8b
cfad3e375d
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 98d0b40dac46330a72d99038a6639b943f212e7b
2020-05-22 01:06:29 -07:00
Wez Furlong
72111106fd
getdeps: use eden prefetch
on windows
...
Summary:
Now that we've deployed the new eden build with globfiles
support, we can enable the use of eden prefetch in the getdeps
build when running inside an EdenFS mount on Windows.
Reviewed By: fanzeyi
Differential Revision: D21692689
fbshipit-source-id: b42e778901976cf0385ec31056c227b2049162dc
2020-05-21 22:55:34 -07:00
svcscm
1aeff22dfc
Updating submodules
...
Summary:
GitHub commits:
be6ee4d528
4b5b7d787f
6a97f85bcb
fb48f55139
0ef92d81db
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: de7acb38ade33a05bf4f52dc1f24373745f11f57
2020-05-21 22:20:16 -07:00
svcscm
9e3bd69e01
Updating submodules
...
Summary:
GitHub commits:
0bc8ef0d72
647364858e
28c893e596
d74f1d479e
91f616e4cf
f6e3f7d3d2
bbfcf1717b
122f3d90ff
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 36b22e15ac2988d6cc8c68cf54ee4cd2da4b5abc
2020-05-21 20:50:29 -07:00
svcscm
de0d51cb86
Updating submodules
...
Summary:
GitHub commits:
811ce17b86
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 8b0d8d59cbea551448cab9442667f23822aa464d
2020-05-21 19:32:35 -07:00
svcscm
816ae7971c
Updating submodules
...
Summary:
GitHub commits:
732d3ffcae
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 40fabfa4b326e193419780e2dbf4276da4ec58c8
2020-05-21 17:49:36 -07:00
svcscm
8ffad53b14
Updating submodules
...
Summary:
GitHub commits:
7c832f1dbb
791aa79790
263ece6907
826295a5e9
eaaf2c2adf
e52980a9ee
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 88c8e28d2e31ba3ca58cf946b60adcb4e8f631c7
2020-05-21 17:01:30 -07:00
svcscm
ad8c1956a3
Updating submodules
...
Summary:
GitHub commits:
750fa0dede
8174190bdf
9614d4db5b
5946fb89f8
292bcf6227
da3eb41a78
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 552536eae60e0a95a0a10cb8b06a324da6bda1b2
2020-05-21 15:03:31 -07:00
svcscm
e2c443e41d
Updating submodules
...
Summary:
GitHub commits:
ca792c0142
28929e8245
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 09ae1a9da72243f761f40f951037c432f8a31de3
2020-05-21 02:46:20 -07:00
svcscm
42c96bf16c
Updating submodules
...
Summary:
GitHub commits:
909926d1ee
8abb78f423
ac53e737cf
0b892bcbfb
eb04bb86c6
0c2c715235
5c5e7ad98c
450e1aaae6
60e318d48d
b4b0ff439e
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 11bfde5db57254d449c0d5fb4cea1a895432989c
2020-05-20 19:30:10 -07:00
svcscm
685727181b
Updating submodules
...
Summary:
GitHub commits:
cb71aa00fb
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 69c3c96e73bfdd338d1030f36e94805d8040ab6a
2020-05-20 11:29:22 -07:00
svcscm
f7ba3510bd
Updating submodules
...
Summary:
GitHub commits:
54bccd495b
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 5009d574a8eff12fa080b9b78a6de9b7a689aad9
2020-05-20 02:58:55 -07:00
svcscm
14375cd837
Updating submodules
...
Summary:
GitHub commits:
45f233c178
a1523efcdf
b18ffd1b6a
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: e5f53bc48c15ce2b71febc068a3df6a93615252f
2020-05-19 20:27:53 -07:00
svcscm
e31a7f7d61
Updating submodules
...
Summary:
GitHub commits:
f425a3aa28
14182bff3b
40cf9cf678
b964ccc5ed
301ce66128
13323915fa
55629dc11a
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: f0e856e7298952190a541a855d52766020389474
2020-05-19 17:23:34 -07:00
svcscm
cfe17e9d73
Updating submodules
...
Summary:
GitHub commits:
2d2c15fcbc
41e40d7ba8
39b24432d4
345dcbca42
34901ee92f
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: d1707c5d41cb21f65233616a39466f98b757cb76
2020-05-19 15:03:57 -07:00
svcscm
c44cc1e6e4
Updating submodules
...
Summary:
GitHub commits:
bdd6a3a5cc
Reviewed By: wittgenst
fbshipit-source-id: 810add3221725dc7e0f601409ff5bd7bb8a3acfb
2020-05-19 02:02:23 -07:00
svcscm
28ff9b83a5
Updating submodules
...
Summary:
GitHub commits:
509ab86b8a
24b8d3e01c
ada700b906
Reviewed By: wittgenst
fbshipit-source-id: 053c53b2a5afe3b09b9982da63358b292a88e8c8
2020-05-18 19:26:55 -07:00
svcscm
acfa7f4291
Updating submodules
...
Summary:
GitHub commits:
e05a737c18
d3b7867ab4
30bff94e85
Reviewed By: wittgenst
fbshipit-source-id: 7c89711e394c8cc9ee4ee934e1bf2af7fcbb705a
2020-05-18 17:52:34 -07:00
svcscm
8cb4f39bc5
Updating submodules
...
Summary:
GitHub commits:
d67d568565
6472821406
10a3d74cc4
10957464df
b2ab01c578
06943d59da
218b463647
Reviewed By: wittgenst
fbshipit-source-id: af0d8f75f6ee6ac9e67812fcd6206070f74f3f49
2020-05-18 15:02:08 -07:00
svcscm
a9734869fe
Updating submodules
...
Summary:
GitHub commits:
08763d6583
b2c842281f
474a2bde70
f732967c40
b9d65f5aa6
64c5a2a73e
49f42386a9
Reviewed By: wittgenst
fbshipit-source-id: 1cb968b6411cb414b0ce38ff6ba4a7d5bf4b28cf
2020-05-18 11:24:37 -07:00
svcscm
fd5b027131
Updating submodules
...
Summary:
GitHub commits:
9b0e67ee8c
Reviewed By: zpao
fbshipit-source-id: bae83694fa49c0d32ca2861934935358d1c06e60
2020-05-18 03:35:53 -07:00
svcscm
14a432a34f
Updating submodules
...
Summary:
GitHub commits:
0d8e13cf96
Reviewed By: zpao
fbshipit-source-id: 17d72824a48803c09f7978ebd21ba6f018923caa
2020-05-17 06:39:22 -07:00
svcscm
f103557161
Updating submodules
...
Summary:
GitHub commits:
81d2abd909
Reviewed By: zpao
fbshipit-source-id: 1901a6eac2f1ef70c4016c6a04c585de85bd6a5d
2020-05-16 21:24:58 -07:00
svcscm
f0503d2371
Updating submodules
...
Summary:
GitHub commits:
435aa6f17a
9908c44c20
085eeb2350
02a7046078
586b5278a6
Reviewed By: zpao
fbshipit-source-id: a05ce6a02eb756dfd6a5c448704d7aef23d50e2a
2020-05-15 21:10:12 -07:00
svcscm
2021c7ca73
Updating submodules
...
Summary:
GitHub commits:
8e6a6315dd
d0910a4d1b
4819eee6ac
Reviewed By: zpao
fbshipit-source-id: 8396b635b7444907e16927df06130b95052cc386
2020-05-15 18:52:23 -07:00
svcscm
c0b0bb9797
Updating submodules
...
Summary:
GitHub commits:
c49a1f934e
2db01ebc47
Reviewed By: zpao
fbshipit-source-id: 9309fb61ecdbb86408b321ced8a200af5a0f5415
2020-05-15 18:05:50 -07:00
svcscm
3ac615d9de
Updating submodules
...
Summary:
GitHub commits:
ab94f6d977
4425227078
10e3eae0d4
35da1e767f
Reviewed By: zpao
fbshipit-source-id: 5ed64d41a20ce6288b5983c835e9798cc0e9d3b6
2020-05-15 13:36:15 -07:00
svcscm
ad303b48ee
Updating submodules
...
Summary:
GitHub commits:
02fa333a56
dd4dd7b279
5d07a157a8
Reviewed By: zpao
fbshipit-source-id: 5dba0bd104b2d4e86ccc21850d852ea44277856b
2020-05-15 09:00:52 -07:00
svcscm
3fa957dd70
Updating submodules
...
Summary:
GitHub commits:
ef4e45e6be
f3ec7dc3e9
Reviewed By: zpao
fbshipit-source-id: 629e349cbf08ae422ba6a8973c1528121a0a0dd7
2020-05-15 02:57:50 -07:00
svcscm
61724cbe22
Updating submodules
...
Summary:
GitHub commits:
1b4b90a028
17b31be012
Reviewed By: zpao
fbshipit-source-id: 504a9afa39116184bd7d211698b406d935116715
2020-05-14 22:53:59 -07:00
svcscm
5bbe42d3cc
Updating submodules
...
Summary:
GitHub commits:
0cec467ed0
0d590d5dd5
dd142643b9
2cc045b7e2
7a6adeea7c
2c01d87f58
468b087f3c
9359e9ab10
45dc2aa42e
5bbab2865d
Reviewed By: zpao
fbshipit-source-id: 287664b8e2882af79f4ed5b13747c4247446c941
2020-05-14 21:11:43 -07:00
svcscm
a10d8004d3
Updating submodules
...
Summary:
GitHub commits:
cc8536a799
f98f9746f3
dc8a041ea5
8cc979bafa
8b08b00eb6
b11a8b1b9a
e862b9eea8
e5aa0460ed
6c17ef772b
c31bd19341
feb04f7112
ab17ea2a8d
53ba2b88bb
Reviewed By: zpao
fbshipit-source-id: b90cabd842d77deaa5a6b8d8609dd79495b85a17
2020-05-14 19:34:53 -07:00
Wez Furlong
e19a93b09e
getdeps: upgrade zstd from 1.3.8 -> 1.4.4
...
Summary:
I'm doing this mostly so that we can avoid using git
to fetch the sources.
Reviewed By: chadaustin
Differential Revision: D21508201
fbshipit-source-id: 54d4635d8938659bea962e90bd829d237f1ed221
2020-05-14 18:08:22 -07:00
Wez Furlong
2a0fa00ec9
getdeps: windows: avoid expanding drive letter substitutions
...
Summary:
We use drive letter substitutions to workaround Windows
filename length limitations. On my personal Windows system running
python 3.8.2 realpath inside an ssh session manages to resolve to
the full filename which causes the boost build to fail.
Avoid that!
Reviewed By: chadaustin
Differential Revision: D21507851
fbshipit-source-id: 1220c1c85d2124ddc51f42cefff2ce00e10c55c9
2020-05-14 18:08:22 -07:00
svcscm
b5bab3d581
Updating submodules
...
Summary:
GitHub commits:
f5c3a265cc
Reviewed By: zpao
fbshipit-source-id: 6450dee2c95b8cf69f0d69356902f4cf2571d96c
2020-05-14 18:08:22 -07:00
svcscm
b35a0f849e
Updating submodules
...
Summary:
GitHub commits:
64bad39e0d
d10385b2cf
d1d606ea75
5b7309d5fe
e5c84d203b
6e64791678
b9a2b343c4
d9c1059140
1bcde534b5
46981b8186
Reviewed By: zpao
fbshipit-source-id: 5299cef9c91612f176ff0c29d0cc3acf629d2240
2020-05-14 14:15:58 -07:00
svcscm
764d75b131
Updating submodules
...
Summary:
GitHub commits:
4a4f4c3293
Reviewed By: zpao
fbshipit-source-id: 115bb9e118523a9d98075e7a106f0a64be57f92f
2020-05-14 10:44:06 -07:00
svcscm
46de4c526a
Updating submodules
...
Summary:
GitHub commits:
2f38e736cd
db00ef824b
f66e9d7cd2
Reviewed By: zpao
fbshipit-source-id: d40cfe2f50505ecc1059838b668e6fd95d9c1182
2020-05-14 02:32:51 -07:00
svcscm
dc6a90a2e9
Updating submodules
...
Summary:
GitHub commits:
c2eda06820
7ed5f9f16c
Reviewed By: zpao
fbshipit-source-id: 48b466893b7537c845bc30b2880f7bb9d7c1d265
2020-05-13 20:24:51 -07:00
svcscm
a2b856cc99
Updating submodules
...
Summary:
GitHub commits:
a11054fa09
Reviewed By: zpao
fbshipit-source-id: f69d6f83ec05d34968b68a33980d6e9eec4281b9
2020-05-13 17:17:33 -07:00
svcscm
0e12d9a096
Updating submodules
...
Summary:
GitHub commits:
58be1aa908
Reviewed By: zpao
fbshipit-source-id: dfa118d04a4089277e49fa02752bed062944ab9f
2020-05-13 16:53:15 -07:00
svcscm
8a595b49df
Updating submodules
...
Summary:
GitHub commits:
205b83bdd2
ee1e6c7b72
398f5c4807
cfe0556cbd
0510e00d52
Reviewed By: zpao
fbshipit-source-id: 562c88611c68fe9f5ed57ceb6b265bc05577a2b2
2020-05-13 15:38:00 -07:00
svcscm
4e8a9077e5
Updating submodules
...
Summary:
GitHub commits:
d55c0b181d
f4660f251d
2d66b4df1f
50c861d765
a6c6103875
9b05d5c814
6891c1b819
Reviewed By: zpao
fbshipit-source-id: b111c91ce6901143de31b0637909313e59bd9570
2020-05-13 14:13:21 -07:00
svcscm
58478894d2
Updating submodules
...
Summary:
GitHub commits:
963d617980
9d972c3d96
50d63a2af0
Reviewed By: zpao
fbshipit-source-id: 020dc9a8d951955fbb42873887d6af56ac31d024
2020-05-13 12:22:05 -07:00
svcscm
c4709f47b8
Updating submodules
...
Summary:
GitHub commits:
debe32b24c
20b37e9bff
Reviewed By: zpao
fbshipit-source-id: 8985e158d3dee85f4c6b2c5b49d0aed6ba1b4add
2020-05-13 01:26:57 -07:00
svcscm
1f887381e6
Updating submodules
...
Summary:
GitHub commits:
fb500be709
Reviewed By: zpao
fbshipit-source-id: 7c053596ba3107fbaf7c400831f777b6ec3a4d08
2020-05-12 17:04:19 -07:00
svcscm
11f55ea8be
Updating submodules
...
Summary:
GitHub commits:
5a74dde371
07cfe45cd9
71650d5d67
2b81847227
8ed576f96b
8a4ba8a17f
f30ca63d3b
20021f0396
67355d562e
2f0b01b165
Reviewed By: zpao
fbshipit-source-id: 04350da1e88206c9029aee4c1da9393d75cbbac8
2020-05-12 14:58:20 -07:00
svcscm
58060eb2e4
Updating submodules
...
Summary:
GitHub commits:
32ca978520
7c0d945b4b
659b3d2c8f
18d7d53dc9
c384c08a4f
Reviewed By: zpao
fbshipit-source-id: 700e5fec8ac6b26e506fed916b06d320f8be2ffc
2020-05-12 13:00:34 -07:00
svcscm
3f42343487
Updating submodules
...
Summary:
GitHub commits:
f06288af92
Reviewed By: zpao
fbshipit-source-id: 32d312c6077a625cd5a82b71228365ea1c2f0ee2
2020-05-12 02:53:41 -07:00
svcscm
95f0b94031
Updating submodules
...
Summary:
GitHub commits:
129156f4ff
Reviewed By: zpao
fbshipit-source-id: a502d0767dc42466c66afbc9143eb50c618ed4c8
2020-05-11 21:20:10 -07:00
svcscm
ad4c78031c
Updating submodules
...
Summary:
GitHub commits:
825d7e2146
d33c823f0d
247c90a49e
Reviewed By: zpao
fbshipit-source-id: ba3a422976d12dbd798a597185985f7b70eb45ec
2020-05-11 20:52:12 -07:00
svcscm
bb300ac19e
Updating submodules
...
Summary:
GitHub commits:
c0b5c0b084
efb57da2ba
Reviewed By: zpao
fbshipit-source-id: 4b5c66c9cd0efdefeb2bc90851a676f52986297a
2020-05-11 19:00:27 -07:00
svcscm
d10bd02c87
Updating submodules
...
Summary:
GitHub commits:
d8ed7cd812
b3281fd99f
a07fd0febe
fe4c0d46e3
8e025a80a2
2e9324718a
9e0a38526c
16f1f53e1b
5b3b3ac872
3b16ae5126
ad939ea6a9
f513dc756a
Reviewed By: zpao
fbshipit-source-id: 1b3804afd513f1e429cae1411816c9e6166dfdf1
2020-05-11 16:41:29 -07:00
svcscm
3caffc114e
Updating submodules
...
Summary:
GitHub commits:
34027c7b31
29cd269e7f
7c5727c8cc
7e79b25f93
e571d404dd
f2aa9bf7f5
f0e8731b72
22375a92ce
5e84ff4dc0
19d8cafbae
52d172d621
cdcedc50d9
20f413e15b
d8234440b2
Reviewed By: zpao
fbshipit-source-id: 991ae049c052c4d1f16d63aebbbed0d1528ca9d1
2020-05-11 13:39:38 -07:00
Xavier Deguillard
04250881ed
getdeps: add filtering of tests
...
Summary:
For large projects, with lots of tests, running all the tests can take a lot
of time, but for quick development iteration, only a subset of the tests may
be needed to run.
On non-Windows platforms, this can be easily achieved by manually executing
the individual tests binaries and use the builtin filtering mechanism of that
test binary to achieve the goal. On Windows, this can quickly become
impossible as DLLs might not be available, and the right PATH would need to
be manually specified by hand to execute the tests binaries[0].
To solve this, let's simply provide a unified way of running specific tests
by passing in a regexp. Both testpilot and CTest do support regex to execute
specific tests. My understanding is that cargo doesn't yet allows regex, but
will in the future.
[0]: And a missing DLLs would produce no output when executed from
PowerShell, which makes this very confusing.
Reviewed By: wez
Differential Revision: D21484774
fbshipit-source-id: ee32e950e25bb2a498a2b364a447955a917b0590
2020-05-11 11:50:10 -07:00
svcscm
5c060a098a
Updating submodules
...
Summary:
GitHub commits:
b86a9654d8
41a856c411
4103ac1325
6aaf3811e5
72a568d387
f638193708
3b81021a51
0e2fb21613
Reviewed By: zpao
fbshipit-source-id: be11a1e3d022e6e305859eff4fa2cad4f2be6ab9
2020-05-11 10:30:33 -07:00
svcscm
db6c795410
Updating submodules
...
Summary:
GitHub commits:
99612a3f69
Reviewed By: jurajh-fb
fbshipit-source-id: 08133876034f1a20ff025770aaa2b18c7c304342
2020-05-10 16:06:06 -07:00
svcscm
1bf7ac2fae
Updating submodules
...
Summary:
GitHub commits:
0f963e26bc
aeabaf80fc
19dae4b3a0
Reviewed By: jurajh-fb
fbshipit-source-id: 4812cd06a780a9f5cb0ac3cb9f3dda91a4e1d2e8
2020-05-09 19:12:25 -07:00
svcscm
9da8207f89
Updating submodules
...
Summary:
GitHub commits:
857fa3c5c8
Reviewed By: jurajh-fb
fbshipit-source-id: d5794a10fb31ad4734ebeeb0151e465c2eafa6f4
2020-05-09 08:46:34 -07:00
svcscm
7ce59f5e27
Updating submodules
...
Summary:
GitHub commits:
1c90e20961
3a1c29d40e
Reviewed By: jurajh-fb
fbshipit-source-id: 6429491b5ff43f834860e2c66c1b754a0ff6969f
2020-05-08 21:51:29 -07:00
Xavier Deguillard
a4af481237
getdeps: silence inherits via dominance warnings
...
Summary:
Previously, the Windows build was litered with warnings of the form (typo included):
warning C4250: 'C1': inherits 'C2::C2::method' via dominance
note: see declaration of 'C2::method'
Microsoft doesn't offer any recommendation, and the internet suggest that the
right `using` should silence it. That's unfortunately not the case, adding:
using C2::method
In `C1` doesn't do anything, and the compiler still complains :(.
Since the warning appears to be non-actionable, and looks more like a
"notice" than a warning, let's just silence it.
Reviewed By: wez
Differential Revision: D21395095
fbshipit-source-id: ae661b3ed61303e6361b8a15d9e7c6b9627ea8c1
2020-05-08 21:46:06 -07:00
svcscm
5ea5261b0b
Updating submodules
...
Summary:
GitHub commits:
875a2dd743
7ddd03f5b7
09a4848005
2dfe12ed17
Reviewed By: jurajh-fb
fbshipit-source-id: a8b1ce8b34c9088bab17b6dfa3f66bc9c84d6d41
2020-05-08 20:41:50 -07:00
svcscm
e81c14a55e
Updating submodules
...
Summary:
GitHub commits:
f07f48504d
7bb0dddf34
Reviewed By: jurajh-fb
fbshipit-source-id: ea4c6cc5f3cfe6425a44bce01e0612b8ff798ba4
2020-05-08 17:17:03 -07:00
svcscm
0f9ab99093
Updating submodules
...
Summary:
GitHub commits:
e12d3367f1
a50ea71c00
Reviewed By: jurajh-fb
fbshipit-source-id: 788d8b502527efc3fa0629717a3306c1bcefc12a
2020-05-08 15:24:56 -07:00
svcscm
4c98fcd44c
Updating submodules
...
Summary:
GitHub commits:
732edbcbc9
4fffce6a60
09b5779df4
5a0756c248
e72e2167fd
7f2218bac2
4261ad5912
fbbb20d9af
1c12a32e33
c909c0c0bd
880eddef20
Reviewed By: jurajh-fb
fbshipit-source-id: 896acfd6d7b8b89b26be7505924e51780376346e
2020-05-08 14:10:47 -07:00
svcscm
19085ec829
Updating submodules
...
Summary:
GitHub commits:
e5afb93b37
a87b053e26
53bc4596f8
47e3c03f53
ae1f120997
406d65ca7b
7aa39613f4
55ac1ecef1
edceb01e64
c4636d9052
46b9fb69f4
0972ea1fa4
88ffc4fdfe
d3acaf0f03
Reviewed By: jurajh-fb
fbshipit-source-id: a178c740dfaf4a74ae503541cf025e7644c06cd1
2020-05-08 12:58:13 -07:00
Wez Furlong
ba3bb150a4
getdeps: try harder to avoid ccache on sandcastle
...
Summary:
A small number of hosts are impacted by some local misconfiguration like this:
```
ccache /usr/bin/c++ -DHAVE_PCLMUL -DHAVE_SSE42 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DROCKSDB_SUPPORT_THREAD_LOCAL -DSNAPPY -I/var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1 -I/var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/include -I/var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/third-party/folly -isystem /var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/third-party/gtest-1.8.1/fused-src -isystem /var/sandcastle/temp/fbcode_builder_getdeps/installed/snappy-8kzrVQJKWlYwtUKTyQTv0R3_bltgjXecrUEMwSpi-vI/include -W -Wextra -Wall -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -std=c++11 -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -MD -MT CMakeFiles/rocksdb.dir/cache/lru_cache.cc.o -MF CMakeFiles/rocksdb.dir/cache/lru_cache.cc.o.d -o CMakeFiles/rocksdb.dir/cache/lru_cache.cc.o -c /var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/cache/lru_cache.cc
ccache: error: /home/facebook/.ccache/ccache.conf: No such file or directory
```
let's try to avoid it!
Reviewed By: simpkins
Differential Revision: D21460408
fbshipit-source-id: 95b1fe019ff36eb8acb8476af997c220a7947436
2020-05-08 09:46:20 -07:00
svcscm
ec4f0cc1bd
Updating submodules
...
Summary:
GitHub commits:
96e6d14049
e01dd78306
52d113416f
2e6c6a9ab1
ffd8bbea62
5b0fa147a7
6f36c10136
62ae2fc80d
df22d3e817
d6ae8ab57f
Reviewed By: jurajh-fb
fbshipit-source-id: 40a3041ec9bbaaa4efac3fdef376a578009dab11
2020-05-08 07:35:16 -07:00
svcscm
87235de9af
Updating submodules
...
Summary:
GitHub commits:
87e90fe063
0c3386b80e
0640ee9fb2
9285064e2b
fffcfc717a
637e532bb3
5ee041d293
147ec22033
7f828ea30f
47c8ffa47c
83489f4a74
Reviewed By: jurajh-fb
fbshipit-source-id: fa6eb05ec7f208c6c2659777e145522eb0fb746b
2020-05-08 00:30:36 -07:00
Lukas Piatkowski
1bf54a6703
rust: remove abandoned heapsize crate
...
Summary: This also unblocks the MacOS Mononoke builds, so enabling them back
Reviewed By: farnz
Differential Revision: D21455422
fbshipit-source-id: 4eae10785db5b93b1167f580a1c887ee4c8a96a2
2020-05-07 23:45:44 -07:00
Lukas Piatkowski
abe2c69df3
mononoke/fbcode_builder: bring back mononoke manifests for getdeps build
...
Summary:
The breakage has been fixed, so bring back the manifest, but only the Linux one, because the Mac version is failing due to another issue.
Also to make it easier to debug issues on GitHub Actions separate out the dependencies build from Mononoke and rust-shed builds.
Reviewed By: krallin
Differential Revision: D21448412
fbshipit-source-id: 68d89c858d1692727a7fd66bca114920e6dfb4dc
2020-05-07 23:45:44 -07:00
svcscm
dc377e35d2
Updating submodules
...
Summary:
GitHub commits:
736a80e10c
Reviewed By: jurajh-fb
fbshipit-source-id: 8c17a7b41e277d856f919643cad1190253b23a03
2020-05-07 23:45:43 -07:00
svcscm
3004d232eb
Updating submodules
...
Summary:
GitHub commits:
02b379a058
7d618e4fde
34dddf5a34
12825894a2
Reviewed By: jurajh-fb
fbshipit-source-id: 80b0ed5c548c8eadc9ace91d5a609673586447b3
2020-05-07 22:59:41 -07:00
svcscm
6ee22e83c6
Updating submodules
...
Summary:
GitHub commits:
b7457e5076
94265234de
e8b466e7fe
425d00b7c7
Reviewed By: jurajh-fb
fbshipit-source-id: b5386f0c02bff517d74b33fc5e3baa56aefe7762
2020-05-07 18:53:32 -07:00
svcscm
24b62d7632
Updating submodules
...
Summary:
GitHub commits:
439c7b22b3
311367e082
9fff0c5702
f286fb344b
5d7937ef67
Reviewed By: jurajh-fb
fbshipit-source-id: 83771b2a6f50090673b679e6a72101f2ea906943
2020-05-07 16:38:05 -07:00
svcscm
5742cf5978
Updating submodules
...
Summary:
GitHub commits:
31db27b735
6c0325d0d7
18212e38a5
Reviewed By: jurajh-fb
fbshipit-source-id: c5b44da1dc64ab2cf1cc6d639973162589d281da
2020-05-07 14:51:22 -07:00
svcscm
f21759b8ea
Updating submodules
...
Summary:
GitHub commits:
2dcfdbf1c2
678c674257
3c93c7b1f8
9c7e962518
486c3b267a
e9ba4ba348
938100e488
0ab3763c44
f16f2fb04e
57c543634c
b0cb27110b
55deb05e03
Reviewed By: jurajh-fb
fbshipit-source-id: f636391a9abb95259cb09c4a3a66c69b4b7222e2
2020-05-07 13:09:23 -07:00
svcscm
008a0fb839
Updating submodules
...
Summary:
GitHub commits:
692063dded
5232565ab8
2f30dbeb4e
34ea33d2e9
f72c40855a
ac3ae1df0b
253bb6846a
48032a841d
17633ddbc1
a2a311b026
8f41535116
1473f6a810
Reviewed By: jurajh-fb
fbshipit-source-id: 2675c67402bd0517eda4c46466fa6d13a2f9d295
2020-05-07 10:54:29 -07:00
Ravindra Sunkad
7e45849a52
Update FBOSS OSS build to link with v4.12.0 of iproute2
...
Summary:
fboss-oss build links to hash that corresponds to tag v4.4.0 released on Jan 11 2016
```
repo_url = https://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git
rev = 92a0236a3cdf3438000834121b7ea8a09f1f52b1
```
The change is to update the iproute2 version to ```v4.12.0``` (July 5 2017) to match with the version used internally to Facebook
Reviewed By: shri-khare
Differential Revision: D21411714
fbshipit-source-id: fac606396e284193bb7199cf60d2601594bfa5f0
2020-05-07 09:54:57 -07:00
svcscm
12e9e9b5bc
Updating submodules
...
Summary:
GitHub commits:
e15d61adf1
77505dd784
e6b156a139
204e7819f4
224e9d9376
220a6af389
f754b8e766
f3792d9458
5a203c90db
d7e26b2441
Reviewed By: jurajh-fb
fbshipit-source-id: bde6f8ce09b85ece439488793d2f0ce006c1074b
2020-05-07 02:56:38 -07:00
svcscm
7bd7e8ff30
Updating submodules
...
Summary:
GitHub commits:
8727b4becd
4ced273f7b
e1a9b0d805
15cf7e676a
0b1b272b3a
dfac023550
c99d951975
7fd6d24b08
fe7150cfff
207f49c90c
5b6f511845
Reviewed By: jurajh-fb
fbshipit-source-id: d11a7d1b96b4e75ca18bded1cd779bb6b4d94299
2020-05-06 23:26:40 -07:00
Hasnain Lakhani
fa7e8e7480
Add manifest for fatal
...
Reviewed By: wez
Differential Revision: D21417542
fbshipit-source-id: f7f0726e84db3dc903bf11c9045a9975a3e90234
2020-05-06 22:25:15 -07:00
svcscm
5de2fd3093
Updating submodules
...
Summary:
GitHub commits:
16544b5dee
52d45cf6fa
5b5e17c534
2b144501d4
Reviewed By: jurajh-fb
fbshipit-source-id: 44c1328481fc67c799f75aaedda6e5af34c711cb
2020-05-06 22:25:15 -07:00
svcscm
c5a31b78be
Updating submodules
...
Summary:
GitHub commits:
15bfa96afd
2c064a01ac
ad92ccc781
1f20df2f38
6e76746415
f2dfdbea5f
0258a144e4
Reviewed By: jurajh-fb
fbshipit-source-id: 38c0e240b567b7e21fc5b3596f496fdcadbe7ee8
2020-05-06 21:33:45 -07:00
svcscm
afe7ca726a
Updating submodules
...
Summary:
GitHub commits:
3f841a1068
4f02b6a779
f633fb70e4
fb7081afd8
fa7b2b30d4
Reviewed By: jurajh-fb
fbshipit-source-id: 4fb1955cbf7736bb158ea8135076ab23b7bd12d9
2020-05-06 21:33:44 -07:00
svcscm
5e5b3d7e7f
Updating submodules
...
Summary:
GitHub commits:
27b152e63e
82070c967b
15ba461f16
e8010d69ec
c1e1185b7a
e726d65cf0
56fa901615
817dd790b7
4b6e5a3727
Reviewed By: jurajh-fb
fbshipit-source-id: 5b0905b8cfa77903d5e1906c28d490470304b513
2020-05-06 17:35:08 -07:00
svcscm
9ef61e4a9a
Updating submodules
...
Summary:
GitHub commits:
6af9edb3a0
43ac0956f5
f29bd8e01e
Reviewed By: jurajh-fb
fbshipit-source-id: 14f2105ec8ddd6d88c97ee452fe787356d018925
2020-05-06 13:28:53 -07:00
svcscm
3574d0b11e
Updating submodules
...
Summary:
GitHub commits:
0f3dc9ff8e
045694e8cd
ac2905ddaf
f16a8b5ea6
5a24bb495b
53f84470d2
f1949dd109
d4e27d5b15
4f9300c89d
a7675615c3
50d5c29346
8d8eb1f19d
Reviewed By: jurajh-fb
fbshipit-source-id: 3d6263cd910af52a01bca6dc2213bf615cfaf8be
2020-05-06 12:05:24 -07:00
svcscm
0608448c58
Updating submodules
...
Summary:
GitHub commits:
843b1cb701
76a9f07723
ea59d20d9c
aef5dd9e25
8b4a8682e3
6c378a0eab
95b6ef6d62
93dba83ff0
dcf917ff81
586bc1d67c
0457b02715
5a92ba8c83
Reviewed By: jurajh-fb
fbshipit-source-id: 092941470dca12a826d616ec73f8c14fd0bc0e48
2020-05-06 10:44:37 -07:00
Wez Furlong
21821e2bc6
getdeps: fix builds with cached project downloads
...
Summary:
D21364132 accidentally broke this; we can't run the fetcher
for projects for which we pulled the build out of cache, because there
is no source to update in that case.
This commit adjusts the logic so that we write out a marker file
to indicate that we installed a build from cache and to look for
that file being present to gate the new update logic.
Reviewed By: lnicco
Differential Revision: D21419122
fbshipit-source-id: 304670848add22531d88549d66f22c40ff255140
2020-05-06 09:22:49 -07:00
svcscm
e8eb164b55
Updating submodules
...
Summary:
GitHub commits:
c6514eb5c2
15c99b4b6b
c1e80e6455
e79f66edfe
Reviewed By: jurajh-fb
fbshipit-source-id: 3c83129be5e50c44705a3d975e571e9110f6dc32
2020-05-06 05:46:59 -07:00
svcscm
3f0760427f
Updating submodules
...
Summary:
GitHub commits:
8eb845b08d
40f530d566
Reviewed By: jurajh-fb
fbshipit-source-id: d73a0ab8a9ab28196e88b40bb31fe93bf20378ba
2020-05-05 23:36:14 -07:00
svcscm
ffc1ff373a
Updating submodules
...
Summary:
GitHub commits:
ca3fc479ed
c21c459771
7ab262586c
be20f1c25c
Reviewed By: jurajh-fb
fbshipit-source-id: 03c4364247da35b714e50c2f0253f9bb0c63e77f
2020-05-05 20:21:21 -07:00
svcscm
377be3ddbb
Updating submodules
...
Summary:
GitHub commits:
6ad92107a5
911311aba9
11f49c1469
ca296a862e
481d507212
354bb79e06
fb0e5fd94b
84c9b9c565
Reviewed By: jurajh-fb
fbshipit-source-id: 25f72385b08f151b4d2af9bb65d7af410842ee18
2020-05-05 19:00:09 -07:00
svcscm
a5d3bbc25e
Updating submodules
...
Summary:
GitHub commits:
c230732e3f
2829163852
32215b0c25
394f2bbd13
Reviewed By: jurajh-fb
fbshipit-source-id: 72de1d434eee60afd38134ad367d452c69d3494f
2020-05-05 15:48:06 -07:00
svcscm
cdf03496b7
Updating submodules
...
Summary:
GitHub commits:
e5627af768
2f1700c8c5
Reviewed By: jurajh-fb
fbshipit-source-id: 894daf4bcb2939deb9709ba86887665a5e449a94
2020-05-05 14:33:22 -07:00
svcscm
70a5e0e788
Updating submodules
...
Summary:
GitHub commits:
6489eda488
633e1d7e3a
1797e36654
Reviewed By: jurajh-fb
fbshipit-source-id: d7ecf0c4f20e4dfdc9df3becf3a35c83757b58e4
2020-05-05 12:53:11 -07:00
svcscm
437d84726c
Updating submodules
...
Summary:
GitHub commits:
3091f9dd0a
e5c563487b
449f3c089d
91bc0130fa
00e6af0887
42a643e797
Reviewed By: jurajh-fb
fbshipit-source-id: 5b656cd437a210119c7f5645f138971d96b3c542
2020-05-05 12:17:03 -07:00
svcscm
3b8c8b4680
Updating submodules
...
Summary:
GitHub commits:
1972a4b5c2
1cd11098a9
Reviewed By: jurajh-fb
fbshipit-source-id: 5ffb2e9251741c8db314dd2038796fc5d9abb951
2020-05-05 08:02:49 -07:00
svcscm
69006edc25
Updating submodules
...
Summary:
GitHub commits:
886a2a4651
313dba04bb
b809094278
14efec15bd
ca0252fe54
d25d21b400
f59693dbbc
61f194f57b
659027363b
9ebed36edf
dfdbb41163
Reviewed By: jurajh-fb
fbshipit-source-id: c5902f7e09d4106d16fb72e51b37099c2da192f9
2020-05-05 06:57:49 -07:00
svcscm
e130a8a8e3
Updating submodules
...
Summary:
GitHub commits:
79730fef2d
c5f5dc0071
2bf5443abd
7c383d4e61
d2b3dbf4f9
ce326f3523
a8053d8d0d
f2c6d7c349
f289daa8f3
43fdf5c767
fb0bffd5aa
8369f9d9b3
Reviewed By: jurajh-fb
fbshipit-source-id: 0885170ab34e4c0e096ba8f7b7078a05432faacb
2020-05-05 05:07:53 -07:00
Lukas Piatkowski
2da413da3e
mononoke/opensource: temporarily remove mononoke manifest
...
Summary: The oss jobs are causing problems to the developers now, lets disable them temporarily.
Reviewed By: StanislavGlebik
Differential Revision: D21400898
fbshipit-source-id: f7a3567056633d9eef98a8d05a37cd029c9e506c
2020-05-05 04:20:42 -07:00
svcscm
659ecb4858
Updating submodules
...
Summary:
GitHub commits:
e2fba1fdf9
Reviewed By: jurajh-fb
fbshipit-source-id: 0cd1a9fad1773d95e69b53b6f2915f1bdb251bdc
2020-05-05 03:46:42 -07:00
svcscm
1d3f0f51b6
Updating submodules
...
Summary:
GitHub commits:
6fad3d5a80
Reviewed By: jurajh-fb
fbshipit-source-id: 630ed9b37a10e2a4f20f4b021d0c4c271fceb10a
2020-05-05 02:47:03 -07:00
svcscm
b9d6b776c0
Updating submodules
...
Summary:
GitHub commits:
2cabf118d2
cc70355a12
e53b3cc393
6f06ca6645
9cb9ae7ec8
d7f6c7d3eb
7d8f6d9e81
000f8ae8eb
a0bcb01daa
e7144be352
6ca7ea7e92
Reviewed By: jurajh-fb
fbshipit-source-id: 0e913373d6594492fbe249455754d36d70e3c9ab
2020-05-04 22:11:13 -07:00
svcscm
eb1e7f0597
Updating submodules
...
Summary:
GitHub commits:
2e48429390
faf91ce01f
89e187d839
257e071629
79952c99f2
5a61e7864d
eddb225388
93403f13b7
d21b67d26d
fedb9fe464
34b8b26990
26ffeccf3e
c0db94e58f
Reviewed By: jurajh-fb
fbshipit-source-id: 94972f903e6fe8e28f857572aceb001fb788eb80
2020-05-04 20:32:25 -07:00
Wez Furlong
8dd0a11354
getdeps: fix an fbsource invalidation problem
...
Summary:
When the commit hash changed in fbsource, we would correctly decide
that we'd need to rebuild first-party projects but we would incorrectly skip
running the fetcher.update method. This would mean that we'd not perform the
shipit run and that our shipit tree would diverge from the source tree.
This commit resolves this by performing the fetcher.update but ignoring
the source update status in this case.
Reviewed By: xavierd
Differential Revision: D21364131
fbshipit-source-id: b4001e549c7d3f27aa4a21b19893c9bb7c0f6d1f
2020-05-04 17:44:48 -07:00
Wez Furlong
decc0228b5
getdeps: improve build invalidation for dependencies
...
Summary:
We didn't do a great job of recognizing that we'd need to
build a project when one of its dependencies had changed: we relied
chiefly on the dependency hash for this and could fail to handle
changes in individual source files.
This commit helps to improve this situation by checking to see if
any installed files in the dependencies of a manifest are newer than
the most recent built time of a given manifest. If so, we'll trigger
a build. We try to be reasonably smart about deciding when to trigger
a cmake reconfigure if it looks like cmake files in the deps have
been changed.
Reviewed By: xavierd
Differential Revision: D21364132
fbshipit-source-id: 7534496e10d1f532aa9cf865900ace84a8785327
2020-05-04 17:44:47 -07:00
Wez Furlong
83d470aa9e
getdeps: refine makefiles matcher for cmake reconfigure
...
Summary:
Only run cmake reconfigure for .cmake, .cmake.in and CMakeLists.txt
files changes.
Previously we would reconfigure for any change to a file with a path that
matched `cmake` which could result in false positives in cases where
you may be iterating on .py or .c files in shared cmake directories.
This also reclassifies non-cmake files under fbcode_builder/CMake as source
files so that we run cmake for those; previously they would cause a
reconfigure and build, now they just cause a build.
Reviewed By: xavierd
Differential Revision: D21364133
fbshipit-source-id: a1231f657d6c6056b269656c677d3449d8715cf6
2020-05-04 17:44:47 -07:00
Wez Furlong
482cf97da6
getdeps: code formatting
...
Summary:
Our linter really wants to include formatting changes unrelated
to my diff stack.
This is a formatting only change to avoid clouding my diffs; no functional
effect.
Reviewed By: xavierd
Differential Revision: D21364519
fbshipit-source-id: 7670dd4154e788f593f256aabdfdeef6d17aeec4
2020-05-04 17:44:46 -07:00
Adam Simpkins
e955b6dabc
getdeps: avoid blowing away too much data when invalidating the CMake cache
...
Summary:
Previously getdeps would remove the entire top-level `CMakeFiles` directory
from the build output when it wanted to invalidate the CMake cache. This
directory is used to keep all of the compiled object files for any libraries
or executables defined in the top-level CMakeLists.txt file. Blowing away
this directory forces all of these sources to be re-compiled, even if this was
not necessary. This is particularly problematic for folly, which compiles all
of its source files via rules in the top-level CMakeLists.txt target file.
I did have the code still blow away the CMake error and output logs in this
directory: in the past I have seen situations where CMake would not update
these files on new CMake runs if they already existed.
Reviewed By: wez
Differential Revision: D21360668
fbshipit-source-id: 6fcd1a8e371d756114fbab60d8636be8cd5f8978
2020-05-04 17:19:07 -07:00
Adam Simpkins
3b280eff95
getdeps: indicate that folly depends on lz4
...
Summary:
Update the manifest file for folly to indicate a dependency on lz4.
folly does not require lz4 be available, but it will use it if it is found at
configure time.
getdeps is unfortunately not strict about providing projects only with the
dependencies that they require at build time. This causes it to sometimes
make lz4 available to folly (if you are also building another project that
requires lz4), and sometimes not. This ends up causing changes in
folly-config.h depending on which projects you are building, forcing all of
the folly sources to be recompiled.
In the future we perhaps should update getdeps to consistently only pass in
include directories for dependencies actually listed in the manifest file.
However, specifying that folly depends on lz4 also works to mitigate this
particular issue for now, and it is also generally desirable to build folly
with lz4 support.
Reviewed By: wez
Differential Revision: D21359995
fbshipit-source-id: aaf61671b7750d6c47e3613c732d220b3311b5ba
2020-05-04 17:19:07 -07:00
svcscm
99b73b16b1
Updating submodules
...
Summary:
GitHub commits:
cb3d30c578
7c33a1c9c5
a00ddf1574
f41d462eed
Reviewed By: jurajh-fb
fbshipit-source-id: 11255fe3f50166a0c370f60d622b598c96b61976
2020-05-04 17:19:07 -07:00
svcscm
e1758e6868
Updating submodules
...
Summary:
GitHub commits:
d7d48e4762
ef6bc9338b
8912f0385a
680c416348
d83d7f3024
b7716f3b23
Reviewed By: jurajh-fb
fbshipit-source-id: 2f68cd7ab7c415b3d0bca21d71e0da7ca58dc708
2020-05-04 15:16:41 -07:00
svcscm
faf7d23534
Updating submodules
...
Summary:
GitHub commits:
613e4a315f
1ed4765e85
8316ff391f
61c5215f84
Reviewed By: jurajh-fb
fbshipit-source-id: efc13fd712fd33fd1b451693ffbf50212edeb34d
2020-05-04 10:50:59 -07:00
svcscm
ea6490063c
Updating submodules
...
Summary:
GitHub commits:
adc6e75705
Reviewed By: yns88
fbshipit-source-id: beb89e5127c1ecdc7e08b780736eb1c397b8312c
2020-05-04 03:24:30 -07:00
svcscm
4ef0800822
Updating submodules
...
Summary:
GitHub commits:
95e8b8f31b
0580a039d7
7f9294015c
efd513c0f5
09d0aec9f2
83d98acd03
91f87afd70
689facf2b8
9c0e731f65
8038d05e74
Reviewed By: yns88
fbshipit-source-id: 8757fb3c1d5303094bd02632de5e0a8392ed9eed
2020-05-04 03:24:29 -07:00
svcscm
73730d6d4c
Updating submodules
...
Summary:
GitHub commits:
c518e9eccf
Reviewed By: yns88
fbshipit-source-id: c8553c86fbac2538155bdb7f69b8f560fa788a1b
2020-05-03 18:33:17 -07:00
svcscm
533605c017
Updating submodules
...
Summary:
GitHub commits:
ecef50e946
c7b3288dff
Reviewed By: yns88
fbshipit-source-id: d8eeea1aae0589ac5a471ca6ae3fdf4afe26d53f
2020-05-02 21:16:54 -07:00
svcscm
c9b0f44e11
Updating submodules
...
Summary:
GitHub commits:
a17dbae5c9
ca2ec4f682
dc3aebd961
b7d7b13ebe
9cd90d3b3b
ddbb420f52
Reviewed By: yns88
fbshipit-source-id: de39b297d9b74b0c4ef0588e2ad002ac21fea375
2020-05-02 15:11:41 -07:00
svcscm
b3e00d0fe3
Updating submodules
...
Summary:
GitHub commits:
b6dda66386
094f932779
Reviewed By: yns88
fbshipit-source-id: 4c3badd4af6ece45cdd3f06fe3fbca71f660e16b
2020-05-01 20:00:06 -07:00
svcscm
dc5e180b39
Updating submodules
...
Summary:
GitHub commits:
f9f0f138c4
af4d41c481
5b7f096980
70a1e73eff
a20ed3f2c2
43d0e4e89c
126f25bd8e
e378c28486
061ca36e2d
Reviewed By: yns88
fbshipit-source-id: 4362d2f913c5f2ec4e91ed10735168ee7c72a2cb
2020-05-01 15:14:21 -07:00
svcscm
c273e891d2
Updating submodules
...
Summary:
GitHub commits:
7e50497ecd
5a965509c8
f2bb67b35e
98419a685b
c915fec339
8a433489a1
070902ae31
c1ff43c814
aaad412cde
b9c0014bc4
8178d4bfbc
Reviewed By: yns88
fbshipit-source-id: dd2c5451b22a7a1bd378cbd57a0b7210554d31f0
2020-05-01 14:05:47 -07:00
Wez Furlong
5537225a02
eden: enable rocksdb in the windows build
...
Summary:
In the initial stages of the windows port we had
problems building rocksdb on windows, so we disabled it.
These days we're able to build it and detect it--we even
require it in the cmake code, but hadn't gotten around
to telling the rest of the code that we can use it.
This commit re-enables it in the build but leaves sqlite
as the default engine until we're able to perform some
benchmarking.
Rocksdb itself has some build issues on Windows; it doesn't
use cmake to locate dependencies, so even though we built
snappy it doesn't know how to find it without modifying the
source:
https://github.com/facebook/rocksdb/blob/master/thirdparty.inc#L4
For that reason, we disable the use of Snappy in the Windows build.
However, in the version of rocksdb that we were using, it would
default to trying to use Snappy even though it wasn't compiled in
and throw an exception.
I've upgraded to a newer version of rocksdb that will simply not
use compression if no compression was enabled at build time.
Given that we mostly store relatively small objects, I'm assuming
that the lack of compression is fine for now.
Reviewed By: xavierd
Differential Revision: D21319896
fbshipit-source-id: 2a2d06d4bd5382706e9220f9b4a2de99dc18311d
2020-05-01 10:33:32 -07:00
svcscm
ee57fdd996
Updating submodules
...
Summary:
GitHub commits:
e141d0c936
Reviewed By: yns88
fbshipit-source-id: 77e99d5002cc5a482142ecddaedacfd336e92854
2020-05-01 08:08:46 -07:00
svcscm
e648c26999
Updating submodules
...
Summary:
GitHub commits:
9eb7cebbb7
Reviewed By: yns88
fbshipit-source-id: 3a4a4d757e53fb65807f4deb389b808ae39c1244
2020-04-30 23:23:27 -07:00
svcscm
c2b3c27fe6
Updating submodules
...
Summary:
GitHub commits:
a253b9719d
6504ae0c4e
e6a4c5a552
Reviewed By: yns88
fbshipit-source-id: 267d7c60012547549ce2750c4f6c5bd16024fdfa
2020-04-30 18:34:36 -07:00
svcscm
2520bb2887
Updating submodules
...
Summary:
GitHub commits:
1b7231eb04
f31381b307
afa9d0c6f8
27cfd48e16
f29c5b9944
9ea50e9599
42ac5ccf8f
213c2c603c
8e3f92113a
83a03f8292
f4f880f3d9
Reviewed By: yns88
fbshipit-source-id: ed9c38dd24821ffc25b42618da0bed1f97198fce
2020-04-30 14:34:42 -07:00
svcscm
ec650a55ab
Updating submodules
...
Summary:
GitHub commits:
7532d7d2e4
42b07dce84
964d3c1f09
e8a222d4fa
b9ef0150dc
eecd8fba46
8cd51543bb
b49b454c2d
fe79d4028a
c62da2a205
27ed4facbe
Reviewed By: yns88
fbshipit-source-id: ac421e7e7a971db711d7edb402d077675089d022
2020-04-30 13:10:03 -07:00
Adam Simpkins
e1cbb0b482
getdeps: upgrade googletest from 1.8.1 to 1.10.0
...
Summary:
Upgrade to the 1.10.0 release. This includes some new features like the
`GTEST_SKIP()` macro.
Reviewed By: genevievehelsel
Differential Revision: D21309360
fbshipit-source-id: 163db628fc99aaa786aeb207f35c7d6295cb5e25
2020-04-30 12:20:08 -07:00
Adam Simpkins
b64e91e99b
getdeps: improve how run_cmake.py invokes ctest
...
Summary:
Update the generated `run_cmake.py` script to tell ctest to print the test
output on failure. Also pass in a `-j` flag to run tests in parallel by
default.
These flags are already passed in by default when running `getdeps.py test`;
this simply updates this developer utility script to do the same.
Reviewed By: wez
Differential Revision: D21307806
fbshipit-source-id: 42045b0f9362494042c79bc946a1004ff8ad98b6
2020-04-30 12:07:14 -07:00
svcscm
3842881f29
Updating submodules
...
Summary:
GitHub commits:
2b59db7359
242186f5ff
4bf6682fe6
fe238e5438
e8cf50093e
17d9a609f2
Reviewed By: yns88
fbshipit-source-id: 3c1030ebc3768a827583b50c2d47fba494816943
2020-04-30 11:54:34 -07:00
svcscm
fa0835e1c9
Updating submodules
...
Summary:
GitHub commits:
b07e345587
Reviewed By: yns88
fbshipit-source-id: 393f088c43d1416d4daa4f54b26102cf9d7ac818
2020-04-29 23:47:30 -07:00
svcscm
d20afab335
Updating submodules
...
Summary:
GitHub commits:
328d4efc16
b6146ad460
Reviewed By: yns88
fbshipit-source-id: bf05d6b176b3e4260329b09862cc27c2aa94ef83
2020-04-29 23:12:36 -07:00
svcscm
4e3e1dc7d0
Updating submodules
...
Summary:
GitHub commits:
19f74a96e6
ac50e17058
2d1a80916f
b9587ed249
98b76fab50
b938e6042b
e661b714ec
7dfd2114cb
a2138b57e5
bbd7e74dd9
b2bdf8486e
Reviewed By: yns88
fbshipit-source-id: 1472de3aa441e87859255ad3a73156c180078a1f
2020-04-29 20:18:43 -07:00
Wez Furlong
69dcced778
getdeps: GH actions: strip artifacts before capturing them ( #809 )
...
Summary:
On Linux the debug info sections in projects downstream from folly and
thrift are huge due to a lot of C++ template usage.
We build in RelWithDebInfo mode as that is most useful when debugging
locally and because the build times are long, but most casual consumers
of the binaries via GH actions really don't care about debug info,
and this should save ~180MB of size in (for example) the watchman
executables.
Pull Request resolved: https://github.com/facebook/watchman/pull/809
Refs: https://github.com/facebook/watchman/issues/804
Test Plan:
Review the artifact size on the linux build in this PR (see
https://github.com/facebook/watchman/actions/runs/91688952 ) and confirm that it
is a bit smaller than 180MB; now under 3 MB.
Reviewed By: simpkins
Differential Revision: D21318302
Pulled By: wez
fbshipit-source-id: f78bc5e735dd78771e0604abae64c0a23cf9158d
2020-04-29 19:09:09 -07:00
Wez Furlong
61bd577f5e
getdeps: fix artifact generation ( #808 )
...
Summary:
The mismatched project output settings were causing
the dyndeps fixup to fail to find any objects and thus none of
the artifacts are populated for posix platforms.
Pull Request resolved: https://github.com/facebook/watchman/pull/808
Test Plan:
The PR published artifacts to:
* https://github.com/facebook/watchman/actions/runs/91617994
* https://github.com/facebook/watchman/actions/runs/91617996
* https://github.com/facebook/watchman/actions/runs/91617997
Reviewed By: simpkins
Differential Revision: D21315090
Pulled By: wez
fbshipit-source-id: 60461809f55e73119f7206e3f392d5b237722f85
2020-04-29 18:45:26 -07:00
svcscm
7bf64283f8
Updating submodules
...
Summary:
GitHub commits:
9c46c9a4a1
ae11e2959a
48ebb4184a
43eb92d9af
bd2fdf2678
5de48576f0
28fe8e4620
eeaad4c91c
841d806bb0
5a59b5e1dd
465ca12e30
107162ff3e
9ae8592aa3
Reviewed By: yns88
fbshipit-source-id: 6500c5006c8e68e2fcaf5899aec304fa9801ccb8
2020-04-29 18:04:24 -07:00
Wez Furlong
35bf841b08
getdeps: split monolithic GH actions CI spec up ( #1360 )
...
Summary:
Rather than have a single main.yml file containing all off the different
builds, split that up so that we have one file per build environment
(linux, mac, windows).
This has a couple of advantages:
* It is quicker to see the status of just one of the platforms
* Artifact collection for one platform is not blocked pending completion
of the builds for all systems
* It's a little easier to understand what is happening for a single platform
To support having multiple files I've changed the output-file option to
be an output-dir.
I've included the rm of main.yml in this commit. Once this gets
imported back to the FB internal system I'll amend in an update to
the helper script that updates all of our opensource builds and run
and amend that.
Pull Request resolved: https://github.com/facebook/folly/pull/1360
Test Plan:
the GH action status on this PR should show three different
actions running, one for each platform.
I updated and ran
`fbcode/opensource/fbcode_builder/getdeps/facebook/update-all-github-actions.sh`
to regenerate all the actions files for FB.
Reviewed By: yfeldblum
Differential Revision: D21310991
Pulled By: wez
fbshipit-source-id: 604ef652c8f746781a4b410c6b996cdee4524e0d
2020-04-29 15:30:13 -07:00
Wez Furlong
d307993944
fb_py_win_main.c: fix File Not Found errors on windows
...
Summary:
This commit resolves an issue with our zipapp executables
on Windows that meant that the only reliable way to start them was
to use the fully path to the executable.
The root cause is that the __wargv array is produced by parsing the
process command line into an array, and if you ran `watchman-wait -h`
__wargv[0] would have `watchman-wait` rather than the fully qualified
path to the executable that the zipapp plumbing requires.
The fix is to ask the system for the fully qualified path and ensure that
that gets set as both argv[0] AND argv[1].
Reviewed By: xavierd
Differential Revision: D21190350
fbshipit-source-id: eeb95084592d30a028a93b2b03877f8cc6c72729
2020-04-29 14:41:57 -07:00
Wez Furlong
5cc7b0e182
GH actions: fixup boost windows environment ( #1359 )
...
Summary:
The environment changed since I tested D20740410 and now it appears
that we'll need to re-export a versioned variable in order for cmake
to detect boost on the GH actions hosts.
Pull Request resolved: https://github.com/facebook/folly/pull/1359
Test Plan:
the GH actions status of this diff.
The workflow was updated via:
```
python3 build/fbcode_builder/getdeps.py generate-github-actions folly --output-file .github/workflows/main.yml
```
Reviewed By: yfeldblum
Differential Revision: D21307640
Pulled By: yfeldblum
fbshipit-source-id: 1555cbcade822775379cd9054be37fdbc17b4d93
2020-04-29 13:11:51 -07:00
Wez Furlong
bd2688aae5
getdeps: allow satisfying deps from system packages
...
Summary:
From the outset, we wanted to be sure that getdeps was able
to source and build the dependencies so that we knew that we'd have
a repeatable build. This came at the cost of build times: having
to build boost on each CI run is a bit of a chore.
This commit adds three new elements to the manifest files:
* `rpms` - a list of RPM names that are all required to be present
in order to consider the dependency satisfied
* `debs` - like `rpms` above, but scoped to debian package names
* `preinstalled.env` - a list of environment variables that if they
are all set and non-empty will satisfy the dependency.
A new `--allow-system-packages` option to getdeps enables the new
logic that looks for system packages; it is off by default, but
enabled in the generated GitHub Actions workflows.
A new `install-system-deps` subcommand is provided that will attempt
to install the system packages needed to satisfy the build. This
typically needs to be run via sudo and is thus broken out separately
from the main getdeps build flow.
I made a pass over the manifest files and added package names that
satisfy the build on ubuntu-18 and fedora-31.
shri-khare: I renamed the `Python3.7.6` manifest to just `python` as
part of this change; the version of python that it pulls in through
the normal build is the same and I believe that an equal or newer
version of python3 is available in the GH actions builder.
The `preinstalled.env` is used only by the boost manifest: it references
the name of an environment variable that is set by the github
windows hosts and that points to a pre-built and pre-installed
copy of boost. Since there is no package manager that we can
easily query for this sort of thing, probing from the environment
seems like a reasonable and fast way to check for this. We
may need to evolve this over time to become more feature rich,
but this seems like a good starting point.
This commit has the potential to save 20 minutes of build time
from each public CI build just due to the boost dependency alone!
Refs: https://github.com/facebook/watchman/pull/797
Reviewed By: yfeldblum
Differential Revision: D20740410
fbshipit-source-id: 6c38019449c54465127656c3d18a6ff1f30adaea
2020-04-29 11:17:51 -07:00
svcscm
d1cab3d9ce
Updating submodules
...
Summary:
GitHub commits:
260ed35e3d
d86477862a
dfbe879c51
3dcd14979c
70a0726512
3fcd3df282
c769af7a4f
b6b98939a3
Reviewed By: yns88
fbshipit-source-id: 462bdb8fdd255bcf871d752d59f25f53d44636fb
2020-04-29 03:16:02 -07:00
svcscm
89ac7b0334
Updating submodules
...
Summary:
GitHub commits:
dc62351fa5
ae008314f6
fd29290685
3c553b49b9
90a0eaf078
79e3d3435b
8086e5e294
bb7534f26d
eba5b02639
daa9f25f71
43ec0851f0
7386286e27
162c68efa6
Reviewed By: yns88
fbshipit-source-id: 02428de75d53a196dbed12267dcddcff79df117f
2020-04-28 23:07:47 -07:00
svcscm
930a2a9d63
Updating submodules
...
Summary:
GitHub commits:
97350d5e55
f881a0f02d
d4398e08fc
Reviewed By: yns88
fbshipit-source-id: bca8124585600901a5893f9f6e42b774162c5d9c
2020-04-27 23:58:15 -07:00
svcscm
c2228a74bf
Updating submodules
...
Summary:
GitHub commits:
ebf6b279dd
Reviewed By: yns88
fbshipit-source-id: 39518f0a8194b8073d44a3461301e2f2320daf8f
2020-04-27 20:11:04 -07:00
svcscm
d6c3788984
Updating submodules
...
Summary:
GitHub commits:
8f5ad7a7a9
0df1589e0c
99d5c32af9
d523b11420
4cd859edf1
6917c57025
f83fa701d3
b2aba4e6dc
7cad3ae6ea
Reviewed By: yns88
fbshipit-source-id: 1d80b947b1b93a99fc7848281c93ede1817178e4
2020-04-27 18:42:09 -07:00
svcscm
14796a03d8
Updating submodules
...
Summary:
GitHub commits:
662362e803
3c9ed98484
580b5b95bc
6e85117e8c
f83e84d046
3e53b78d42
75201a4827
cc8d16efd6
8747facc9b
e75453d28c
4d6f2d2d71
76037a9a1d
2e7c66397a
Reviewed By: yns88
fbshipit-source-id: e64cf995260d59b1a750648beec151bbb820387e
2020-04-27 16:17:00 -07:00
Zeyi (Rice) Fan
84735dcdd3
directly reference vendored Rust crates instead of copying it
...
Reviewed By: wez
Differential Revision: D21238976
fbshipit-source-id: 13a6def8d6c8d25057409956cc883589b205cd04
2020-04-27 09:56:58 -07:00
svcscm
4aeadad2be
Updating submodules
...
Summary:
GitHub commits:
06cc4e8f6c
277b07e8a9
f400225dc7
a2d35ac0f9
Reviewed By: wittgenst
fbshipit-source-id: f477ddea5d92ab2dd7ccabe9f727ac124cf78650
2020-04-26 21:33:33 -07:00
svcscm
13cb3d8b04
Updating submodules
...
Summary:
GitHub commits:
d1d742e2e5
598704d025
5026cb73ca
bbaf26faa3
411f7eb5fd
197cb33355
9c4f0c07f5
Reviewed By: wittgenst
fbshipit-source-id: f5e7d91ca3b9c17e928cc111d55a0961785a478a
2020-04-26 20:26:26 -07:00
svcscm
7b6b96e20e
Updating submodules
...
Summary:
GitHub commits:
edbe0f2e39
e84f5de1ee
e0671c3e19
ed3499f1da
c7fd0b9115
4e64e993fe
ef9820a0f2
f795324507
Reviewed By: wittgenst
fbshipit-source-id: 66ba6b44b2325cb8486bbe2fd03b67679b9f2b01
2020-04-25 19:55:53 -07:00
svcscm
4e3d9883e0
Updating submodules
...
Summary:
GitHub commits:
80912860d5
0bc9b9b0be
dc0507618c
e270048526
276d3d4b30
09ea3ddbef
f551ffb529
f2dd723352
e6a5d607c7
ca5320bf22
Reviewed By: wittgenst
fbshipit-source-id: e727d0ad5485c6aa2e8d9c3df455ae2b3f7fcc8a
2020-04-24 19:01:35 -07:00
svcscm
30ab95ed9b
Updating submodules
...
Summary:
GitHub commits:
7b3045b7dd
5721023996
5f7a7d79a4
d8e90515f8
de89a2ae55
3bfe802f9d
40497a875a
d3839b27e2
0e734c7ef1
d401c5ea06
5942ae9fa5
fda187126b
Reviewed By: wittgenst
fbshipit-source-id: 0caba7294c7ace47e2c7642816ccf35e2a61ddf2
2020-04-24 16:42:02 -07:00
Wez Furlong
894ed5f4c9
getdeps: partially educate getdeps about EdenFS on Windows
...
Summary:
I noticed that copytree was taking forever and realized
that it wasn't issuing a prefetch call so I started looking in here;
this commit teaches getdeps how to recognize and EdenFS repo on
Windows but skips calling prefetch on Windows.
Currently the prefetch implementation triggers some very slow
processing in mercurial that is slower to start than just
enumerating the files in the opensource build.
It turned out that my original problem was just that my credentials
had expired and we weren't surfacing that error on Windows yet.
Reviewed By: simpkins
Differential Revision: D20755905
fbshipit-source-id: 8d3695cdd1f04199d1d409895482b8c706285d5f
2020-04-24 14:44:52 -07:00
svcscm
b3d4f59b04
Updating submodules
...
Summary:
GitHub commits:
7779bffbf6
6c36bc7682
9d858eef07
337cee36e7
db01e02483
5ac754ab77
f4f67f4bce
ee4f6ba497
Reviewed By: wittgenst
fbshipit-source-id: 5b3a9c25bd94aff0352e3f5e16f1275b8328715a
2020-04-24 08:04:01 -07:00
svcscm
228f99d9fb
Updating submodules
...
Summary:
GitHub commits:
4a7d67b578
55a89231cd
23ee0e4e68
78efaa6756
660f206038
212129d8c2
876f9a3c5a
071033d784
8f18162891
834c12a054
Reviewed By: wittgenst
fbshipit-source-id: 5db2ab3f53cc263b95be89ffed3ace13c67d8f94
2020-04-24 06:20:27 -07:00
Lukas Piatkowski
22a9d3e1cc
mononoke/configerator structs: add shipit and autocargo configs for all configerator structs
...
Summary: The configerator structs are used in many top level functions in Mononoke and are required in order to build all the code on github
Reviewed By: ahornby
Differential Revision: D21130546
fbshipit-source-id: 7f17d92173f5ecf7c3406ae4202359a0db8df84a
2020-04-24 04:33:53 -07:00
svcscm
8f5d1296a4
Updating submodules
...
Summary:
GitHub commits:
b7b7390a70
Reviewed By: wittgenst
fbshipit-source-id: 7692116372f9a09b3efd077c46bfc85d2eaad80f
2020-04-24 04:05:53 -07:00
svcscm
3f5aba5dce
Updating submodules
...
Summary:
GitHub commits:
23198e8b72
4134ddf996
fc25d15e3a
b646e5df83
e076254b26
fc4852b397
9ae029fc23
e04f3bce4f
b734bf0646
55443f2b16
bad0017d5b
91063b0c3e
Reviewed By: wittgenst
fbshipit-source-id: a20549d3cdb6d1fcf4dacbaa31ba59e778d3d462
2020-04-23 21:30:41 -07:00
svcscm
f4e0759ec7
Updating submodules
...
Summary:
GitHub commits:
e2144de7c7
caadbc23f0
d6dc3ff29a
869ddf3f38
54f7939bd7
337a4627fe
Reviewed By: wittgenst
fbshipit-source-id: 5f1323cede11278dd9d046428639182a24751822
2020-04-22 21:17:14 -07:00
svcscm
59fdcce0c5
Updating submodules
...
Summary:
GitHub commits:
5d242ccb22
137bb3272d
Reviewed By: wittgenst
fbshipit-source-id: 445c646776262de5dba54f27720d4e0b40b3bdd7
2020-04-22 15:40:41 -07:00
svcscm
076b622691
Updating submodules
...
Summary:
GitHub commits:
3746bf6f2c
87730ea6f8
Reviewed By: wittgenst
fbshipit-source-id: 6a086370f89072201ca00c82bb8408666351738d
2020-04-22 14:19:56 -07:00
svcscm
5c64445648
Updating submodules
...
Summary:
GitHub commits:
72a93b564f
Reviewed By: wittgenst
fbshipit-source-id: 84e6c00255af34e0f658bed5b8f0160fe2cfa305
2020-04-22 09:25:36 -07:00
svcscm
957307f7c6
Updating submodules
...
Summary:
GitHub commits:
1864bd5fc6
0bd8675fa9
6df3348483
Reviewed By: wittgenst
fbshipit-source-id: 0587cb5650ba1cdb650db2249709edccec9b6dc9
2020-04-22 01:41:05 -07:00
svcscm
2fc23ee172
Updating submodules
...
Summary:
GitHub commits:
5ead4c5ea4
Reviewed By: wittgenst
fbshipit-source-id: 35c6bf0b0983bf879037102a8b0f6905523724da
2020-04-21 21:50:40 -07:00
svcscm
ffc48eaad3
Updating submodules
...
Summary:
GitHub commits:
9261f492d7
01ca4c5d16
4f1e337b97
665c02d657
Reviewed By: wittgenst
fbshipit-source-id: 532bfeac67f041b68f1151b5b55a84d73a8ffefe
2020-04-21 20:37:20 -07:00
svcscm
aa9dc2ef38
Updating submodules
...
Summary:
GitHub commits:
4cbc19d2a1
ef4b41b580
71252a0f2d
f356004ff6
683dcc1f67
Reviewed By: wittgenst
fbshipit-source-id: f7207d3607a3acdf57dbbada3922b557df129ab8
2020-04-21 18:40:56 -07:00
svcscm
73de0146d1
Updating submodules
...
Summary:
GitHub commits:
93ac7a1ba4
93a5505743
26c439a99c
c1ccd6b6af
04f70750eb
Reviewed By: wittgenst
fbshipit-source-id: 3d70cc0ccc1ba42698ccf0cbccba8557376eb95b
2020-04-21 16:42:40 -07:00
svcscm
85ecde72ff
Updating submodules
...
Summary:
GitHub commits:
e66b103682
6ee66cf8f0
4a7ddd92af
Reviewed By: wittgenst
fbshipit-source-id: 4c31e93448954c5d3c1499e966d66f095430085e
2020-04-21 14:44:01 -07:00
svcscm
853949dfe0
Updating submodules
...
Summary:
GitHub commits:
de551687ba
a2fc2708b9
Reviewed By: wittgenst
fbshipit-source-id: 5e5fbf05b78631ec61166032327ced3f4119e925
2020-04-21 13:36:41 -07:00
svcscm
6599784094
Updating submodules
...
Summary:
GitHub commits:
71372bd652
8c7ef2e325
f986586a15
Reviewed By: wittgenst
fbshipit-source-id: 271adfc03e696c40230f76e66d0bb981ce48bcc9
2020-04-21 11:31:19 -07:00
svcscm
d3f79980ef
Updating submodules
...
Summary:
GitHub commits:
c9eb47f77b
10efe12e9f
Reviewed By: wittgenst
fbshipit-source-id: 08e802bd51bc0c0124ebb0e6fc8b7cdcb8b4c28f
2020-04-21 02:30:07 -07:00
svcscm
f6a3a1f109
Updating submodules
...
Summary:
GitHub commits:
0ff0c88fc6
d5f1f1bbad
Reviewed By: wittgenst
fbshipit-source-id: 53dad6564a4a2c114785110e95cf5d4eb6e2c3dc
2020-04-21 01:16:49 -07:00
svcscm
b7537eea6b
Updating submodules
...
Summary:
GitHub commits:
a016281436
ffbcf5a13a
043f4e37c4
b9762613d2
fb43be3e28
cb3963d1d6
Reviewed By: wittgenst
fbshipit-source-id: 418c3c65f570c9948b987aa1620e7b5a9eb9f908
2020-04-20 19:29:06 -07:00
svcscm
270e6d3121
Updating submodules
...
Summary:
GitHub commits:
64f490f37a
4149e5f63e
ca2af5cc4c
Reviewed By: wittgenst
fbshipit-source-id: 36383e9665ef1a1e19ff7dbb72af5007142b0cee
2020-04-20 16:28:17 -07:00
svcscm
0777b1e31e
Updating submodules
...
Summary:
GitHub commits:
4d3de35f19
b8befce2d6
6a0dd80b49
6603d5a9c4
Reviewed By: wittgenst
fbshipit-source-id: 72c8743812bf6c2c945e607d3c11f506d1d2e421
2020-04-20 09:57:15 -07:00
svcscm
ec6bd59f88
Updating submodules
...
Summary:
GitHub commits:
23496d2d53
19fcc32e27
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: ebb56f048f23336c39d4b1046c781a2206f95988
2020-04-19 22:48:19 -07:00
svcscm
b80cad2730
Updating submodules
...
Summary:
GitHub commits:
9e69c39c2f
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 222389e953191e62fab555dc0f4a8353fa828ab3
2020-04-19 12:24:45 -07:00
svcscm
e41cba0dd0
Updating submodules
...
Summary:
GitHub commits:
fb0e252e1f
7c40dec732
8db6fc263f
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 1b0131a711a486e8f00d83562ff42d4ded5eba2f
2020-04-18 12:28:17 -07:00
svcscm
a8518830f3
Updating submodules
...
Summary:
GitHub commits:
2cf08ee6ad
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 0a9b18a05f44d84e8f9a1eb552dbefd84b08a33f
2020-04-18 12:28:17 -07:00
svcscm
7c0cdd0076
Updating submodules
...
Summary:
GitHub commits:
7095c7d0fe
4a3a0d6379
f093ae8673
243852ec15
5c3e0b543a
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: d1de638144b89189a4557dfa4bc23d628b3155a5
2020-04-17 16:37:21 -07:00
svcscm
16dca9a013
Updating submodules
...
Summary:
GitHub commits:
08438ba241
b432d9e11f
63d82e57b9
cc7ba2dbbd
dc2958f1d2
ac90359ba4
f86e22cb98
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 6ccb7149fa8dc59f8b0af139c5e49e17cb7eae8d
2020-04-17 13:27:40 -07:00
svcscm
771d00f6f2
Updating submodules
...
Summary:
GitHub commits:
091c004733
9773853773
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 4dd2d69aa9f517c9345b8004c14d8db1c56ffcd6
2020-04-17 04:02:40 -07:00
svcscm
3b951b7e23
Updating submodules
...
Summary:
GitHub commits:
8a5981ec8e
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 96cae954ff31fcb13248d3b78ef4bad11f1a7cdd
2020-04-17 04:02:40 -07:00
svcscm
82c9973cb3
Updating submodules
...
Summary:
GitHub commits:
69049d1a47
131dac78ff
a57ee74a02
62fb9e598f
9e6f3efcd2
0ba99f6b0a
74d5c977b7
9e74b34375
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 55b738c3d98b47584e8c51ec64c1cdac463f73fa
2020-04-16 20:04:24 -07:00
svcscm
55e152274b
Updating submodules
...
Summary:
GitHub commits:
117f63b21b
9e19d775b8
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 5ac21cf9aef99d2460ccb6ae1dbc983673d8e6c6
2020-04-16 15:18:11 -07:00
svcscm
401c286de2
Updating submodules
...
Summary:
GitHub commits:
9a081c46cb
3e66804d9c
6717ada899
93844d05fa
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 70fd7b9e6dc1ab116252a17538cac04851b5f3c0
2020-04-16 14:15:53 -07:00
svcscm
b1d382892f
Updating submodules
...
Summary:
GitHub commits:
597152497e
52a8633f0e
9a751a74b8
5801af4646
e74840c489
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 6e751ccbd4d23b1f3c866481cab792504196591e
2020-04-16 12:28:51 -07:00
svcscm
364e3ee9b7
Updating submodules
...
Summary:
GitHub commits:
0e29494c3e
357eab71fb
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 6ffc2fa64f076ad30975b0582c4fcfd998ab1641
2020-04-16 07:46:26 -07:00
svcscm
0c995f8c01
Updating submodules
...
Summary:
GitHub commits:
888146f2cd
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: a5cfbd7cf4710fb861a6662b477cae22ae997276
2020-04-16 00:43:02 -07:00
svcscm
7154f16b01
Updating submodules
...
Summary:
GitHub commits:
f2d53712ca
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: f8f37a838bf62773e88e6e6b599a96589ff965a4
2020-04-15 23:17:21 -07:00
svcscm
8c28b67a02
Updating submodules
...
Summary:
GitHub commits:
9abf6b364a
c26703bb49
dc197d1707
b7c2d2f9b2
e1f371c25e
e5885a29fa
32e9736cba
5c31e5ce4f
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: d29c57c074e85d1b30bdb74402f3a157a3dba5f6
2020-04-15 21:04:01 -07:00
svcscm
7478d41ffe
Updating submodules
...
Summary:
GitHub commits:
3b4602633c
5d585be400
9362555b2e
d2a4722e05
a4472fe07f
e45673dece
4b050c8de3
c86ec6e661
a0260b07ab
dc0fff83ff
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: c7e234f429f50c146135dd82f0c29e1d726e3d45
2020-04-15 18:57:47 -07:00
Adam Simpkins
49a9b52cdc
getdeps: make several improvements to the eden manifest
...
Summary:
- Indicate that the EDEN_VERSION_OVERRIDE environment variable affects the
build.
- Exclude eden/config.py from the shipit path map, as this file is
auto-generated in open source builds.
- Include pexpect as a dependency, as this is needed for some of the
integration tests.
Reviewed By: genevievehelsel
Differential Revision: D21000163
fbshipit-source-id: 8eec378f66487229c995f637c4787eae530c7845
2020-04-15 17:27:06 -07:00
svcscm
06eaf3c226
Updating submodules
...
Summary:
GitHub commits:
140809ea3f
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 5e57d25493ff36be181b2443add20791ca390866
2020-04-15 08:49:57 -07:00
svcscm
0656983c66
Updating submodules
...
Summary:
GitHub commits:
aeb704b05d
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: c5a51e452851911ed5104c8896593096f7924475
2020-04-15 04:17:41 -07:00
svcscm
b6d2cb678b
Updating submodules
...
Summary:
GitHub commits:
3755089477
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: a9a69354a0329bf45986bad3a8d7b0e4f4dd0f32
2020-04-14 21:54:10 -07:00
svcscm
950a5f99c4
Updating submodules
...
Summary:
GitHub commits:
99102a8617
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: b2feee13657baac1f4b37ebb292c84890258c548
2020-04-14 20:30:32 -07:00
svcscm
c6aabb99d5
Updating submodules
...
Summary:
GitHub commits:
1aea7d5c18
7912e9ba9b
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 270e1ea85aa479bc89a4d898c0b968d10946cc6e
2020-04-14 18:49:53 -07:00
svcscm
b50f6fb2d9
Updating submodules
...
Summary:
GitHub commits:
70359215e7
4c2a7c53bc
bd5a2fd3bf
8133c41c46
cb33d1407e
83dfacde3c
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: ce2b1959d295e4acf41d98d88d2775f08f90cf71
2020-04-14 18:27:39 -07:00
svcscm
e25d143ff9
Updating submodules
...
Summary:
GitHub commits:
9c51d22bc0
7469e0b55e
d36ec21c6f
d93870ddaf
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 7a3dc49e07a0b6cec26ff4c7deebdc85e4a878c9
2020-04-14 17:04:11 -07:00
svcscm
78e3a0fc65
Updating submodules
...
Summary:
GitHub commits:
ad8484f1db
02a2effec6
61f744df0a
e18d1fdae6
76d57da2b4
234e2ed5b6
d424d61c65
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 0897f66b03ee5de66dd565c52e0c47a3c9afb7eb
2020-04-14 13:08:52 -07:00
svcscm
9c47e79f36
Updating submodules
...
Summary:
GitHub commits:
be2fa79fa1
b87085650d
Reviewed By: 2d2d2d2d2d
fbshipit-source-id: 16a0c3e3fb16e7ab0622e8f2b92c8af6ca89a30a
2020-04-14 10:53:59 -07:00