Commit Graph

5 Commits

Author SHA1 Message Date
Mark Thomas
6ee252bb95 debugstatus: print the clock value stored in treestate
Summary: Add the current clock value to the output of `hg debugstatus`

Reviewed By: quark-zju

Differential Revision: D14150641

fbshipit-source-id: 917ac3095bc933c042c0f057d0dbda38ef710844
2019-02-20 11:01:52 -08:00
Mateusz Kwapich
4db0750027 fsmonitor: use correct length for number of files changed
Summary: When comparing the number of files changed, fsmonitor was incorrectly using the length of the result dict (always 4), rather than the number of files watchman returned.  Use the right list of files instead.

Reviewed By: markbt

Differential Revision: D14123604

fbshipit-source-id: 94684f1f189d045b2f6a880180b15e52ba9bba8c
2019-02-18 10:03:12 -08:00
Mateusz Kwapich
9e35a167ef fsmonitor: show that we don't update watchman clock as often as we wish
Summary:
This subtle bug shows only when the watchman-changed-file-threshold is set to a
value higher than 4.

Reviewed By: markbt

Differential Revision: D14123605

fbshipit-source-id: 51ff3172fef5bc65fb9f68bb34826a9181fd64a9
2019-02-18 10:03:12 -08:00
Jun Wu
946fa43efd fsmonitor: update watchman clock if too many files are returned
Summary:
This should auto recover from a state where watchman returns too many files,
which makes "hg status" slow.

The default config value 200 is not chosen very scientifically, but it should
cover the 6s status case where there are 90k changed files reported.

Differential Revision: D14036494

fbshipit-source-id: 368f53e99e2e54343a6ac9145cbb86e4ac65e4ac
2019-02-12 11:16:12 -08:00
Jun Wu
b53bc49971 fsmonitor: add a test showing suboptimal behavior
Summary:
akushner encountered a case where "hg status" takes 5+ seconds and cannot
self-recover. That is because watchman constantly returns huge number of files
and fsmonitor didn't choose to update the clock to address that.

Reviewed By: DurhamG

Differential Revision: D14036493

fbshipit-source-id: 0bd8f7c9e3a51b6b4d2a1584b68883f8579e3f0f
2019-02-12 11:16:12 -08:00