Commit Graph

3 Commits

Author SHA1 Message Date
Tony Tung
3cb14683b0 [fastmanifest] enforce strict prototypes
Summary: Newer versions of gcc (5.x) turn on `-Wstrict-prototype` by default.  Turn this on in our setup.py file for older compilers, and fix the errors that crop up from this.

Test Plan: make local

Reviewers: tnardone, wez, lcharignon

Reviewed By: lcharignon

Subscribers: mitrandir, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D3414620

Signature: t1:3414620:1465514102:d91026062582e2a3ab3fc773bbf17686fa38609f
2016-06-09 22:45:05 -07:00
Tony Tung
ca3c7733aa [fastmanifest] fix buffer expansion in tree conversion code
Summary:
# We need to track the enlarged buffer capacity.  If not, we will never enlarge the buffer again.
# The realloc was undersizing the buffer.

Test Plan:
successfully convert the opsfiles manifest using valgrind + test_convert_rt.

run `hg --config=extensions.fastmanifest= debugcache --all` on opsfiles-hg

Reviewers: wez, durham, lcharignon

Reviewed By: lcharignon

Subscribers: mitrandir, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D3369621

Signature: t1:3369621:1464792791:4bc83c39c0355644a0933b2ea3f544fd99894698
2016-06-01 09:27:17 -07:00
Tony Tung
fc8c0d61a1 [fastmanifest] rename fastmanifest c library directory to cfastmanifest
Summary: This allows us to use fastmanifest as a directory to drop in the python module.

Test Plan: compiles, passes existing tests.

Reviewers: lcharignon

Reviewed By: lcharignon

Subscribers: mitrandir, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D3351021

Signature: t1:3351021:1464284417:6cbcde514ab1fd7b5caa6c83cb5577f3502dbc58
2016-05-26 11:33:07 -07:00