Commit Graph

3 Commits

Author SHA1 Message Date
Mark Thomas
0ba172a19e arcdiff: add lastsubmitted revsetpredicate
Summary:
Add a new revsetpredicate, `lastsubmitted(set)`, which maps commits to the last
version that was submitted to phabricator.

Note that this will fail if any commit doesn't have a diff associated with it,
or if the last submitted commit is not in the local repository.

Reviewed By: quark-zju

Differential Revision: D9282952

fbshipit-source-id: 9de8e3196197b2ed106779bb2f58b1f208525e91
2018-08-14 19:27:41 -07:00
Jacob Bower
21b2a6e47f Add second-order diff display for changes since last Phabricator upload
Summary:
The `arcdiff` hg extension is useful in concept - showing the changes since last Phabricator upload, but in practice there is usually too much noise in the output from rebasing. For example, consider the case where I have a stack and haven't re-uploaded the current commit. If one of the ancestors in the stack has changed and I use `--changes-since-last-arc-diff` I end up seeing those changes mixed plus the changes to the the ancestor.

Here we introduce a feature to show only a diff of the current commit vs. Phabriactor's version of the commit i.e. a diff of a diff, or "second-order" diff. The goal is not to perfectly reconstruct the changes, just to highlight what changed for human consumption. There are no line-ranges or context in the diff output, but it still seems pretty usable.

This new feature is invoked via the option `--changes-since-last-arc-diff-2o` to `hg diff`.

Reviewed By: quark-zju

Differential Revision: D8787504

fbshipit-source-id: 2885a118a712a3d9187e6fce67a465e7b664c3ca
2018-07-16 17:51:49 -07:00
Jacob Bower
0ae447b22c Deprecate --since-last-arc-diff
Summary: --since-last-submit is the new hotness

Reviewed By: quark-zju

Differential Revision: D8851071

fbshipit-source-id: 3cc7a9b9c32631bc507fb3bee74db7e5ae95f802
2018-07-16 17:51:49 -07:00