Summary:
There are a couple of reasons to avoid using ui.username():
1) If config option ui.username is set on the server then it will use it
instead of the name of the user that does push
2) It prints confusing warning `no username found, using '....' instead`
3) In some cases it fails (probably because it calls socket.getfqdn() which
does network request).
Let's use simple util.getuser() function and set username to 'unknown' if
it fails.
Test Plan: arc unit
Reviewers: #mercurial, simonfar
Reviewed By: simonfar
Subscribers: azich, mjpieters, #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D4642457
Signature: t1:4642457:1488458040:5dfac435bf44dfa6ab7725d2f5800963e8c860ec
Summary:
stderr/stdout order is different on mac. We don't need stderr at all on this
test so let's just disable it
Test Plan: Run `test-infinitepush-*`
Reviewers: #sourcecontrol, simonfar, jeroenv
Reviewed By: simonfar, jeroenv
Subscribers: mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D4326319
Tasks: 12479677
Signature: t1:4326319:1481711140:443ea2ab92391fa6e4671280441b8f71769650d8
