Summary:
As we are going to add more flags for `sl pr submit`, it no longer
works well to use `submit` as the default command. Though we
add `s` as an alias for `submit` so it does not require much typing.
Reviewed By: zzl0
Differential Revision: D42047829
fbshipit-source-id: 782339a44ec5b548b6fc5e61a32f8fb05c0c8fe4
Summary: This makes it easier to use for trait objects.
Reviewed By: muirdm
Differential Revision: D42024292
fbshipit-source-id: 490f817c368d472f4741830d2d7269ee38f9ada2
Summary: Add a way to specify a name to `ConfigSet`.
Reviewed By: muirdm
Differential Revision: D42024078
fbshipit-source-id: bb530e8fa6d2bf3ac7f73ca0ff076e60ac2887ea
Summary:
This makes it possible to modify a UnionConfig on the fly without recreating it
from scratch.
Reviewed By: muirdm
Differential Revision: D42024079
fbshipit-source-id: 7c583cacc7a4602b29ec1ad1a4cef910ffc8a357
Summary: This will be used by the next change.
Reviewed By: muirdm
Differential Revision: D42022088
fbshipit-source-id: 0df90da6a0a515e1a0e0030d94aa86ea6950b9b5
Summary:
The name "parser" no longer accurately reflects what the code does. Rename it
to "loader" to clarify.
Reviewed By: muirdm
Differential Revision: D42018937
fbshipit-source-id: 22a115b2277e78e48c4ac75d75c97d0ec0ff1a37
Summary:
The configparser became too bloat with dynamicconfig logic.
Move its core structure `ConfigSet` to a standalone crate so code using
`ConfigSet` have a lightweight alternative, and `ConfigSet` logic can
be developed independently without coupling with dynamicconfig.
Reviewed By: muirdm
Differential Revision: D42018678
fbshipit-source-id: 45d1e9458fdaa65b0242bad59dfd76c46dd516d1
Summary: It is no longer referred in other CMakeLists files.
Reviewed By: muirdm
Differential Revision: D42021268
fbshipit-source-id: d172a8ecf82c4764fc4477d0391015a3ec89961e
Summary:
It is only used by hg.rs. Move it to decouple the core ConfigSet features from
hg's business logic (`--config` flags).
Reviewed By: muirdm
Differential Revision: D42018679
fbshipit-source-id: a33b9adf0217288ec7bea997a6e3b81fb35cc123
Summary:
Previously it requires the sub-configs to match their parent config.
That actually seems inflexible. Relax the requirement so it can be
used in more places.
Reviewed By: muirdm
Differential Revision: D42018680
fbshipit-source-id: bf2be4cfe23175ce32738872a16efe906fbc5d29
Summary: Use abstraction to be more flexible.
Reviewed By: muirdm
Differential Revision: D42011185
fbshipit-source-id: 419edb17376a6939a8eac98653b6cac20464544f
Summary:
This allows `workingcopy` to work with other config implementations like
`UnionConfig` not just `ConfigSet`.
Reviewed By: muirdm
Differential Revision: D42011186
fbshipit-source-id: a721922511b900a977e9e629088197f0742ea21c
Summary: move GraphQL queries into consts module, so they can be reused by tests.
Reviewed By: bolinfest
Differential Revision: D42035497
fbshipit-source-id: 0f43e6b43a43c15b61f696858abdd5ae230a2c45
Summary: this formatting choice was a remnant of a codemod
Reviewed By: chadaustin
Differential Revision: D41755813
fbshipit-source-id: aee8dcd0231f807d205530478cb74bb36785fef5
Summary: on macOS, a redirection target is the absolute repo_path of the redirection. Therefore, we need to modify the expected output for macOS integration tests.
Reviewed By: fanzeyi
Differential Revision: D41691840
fbshipit-source-id: 6d6975c9e1f74b5ef56a95b2d0a49f76704ebde7
Summary: on macOS, we default to NFS instead of FUSE, therefore use_nfs() should always return True on macOS
Reviewed By: chadaustin
Differential Revision: D41707744
fbshipit-source-id: 0b987682fe3268a216770b8b0e0b2ee9a99c11e0
Summary: Enable integration tests and disable all tests that are failing. We will slowly resolve all of these test failures over time.
Reviewed By: xavierd
Differential Revision: D41691841
fbshipit-source-id: b36eadee2cfdc5cc367bc5a3b4d224ba4a6968a5
Summary:
This re=implements the backed-out D41393677 (6384a0f39a) with some changes:
- Only log if the size metadata is _less than_ the size of the file contents
we're returning. This way we avoid erroneously logging partial reads, as
happened in T139036919.
- Only log once per Nfsd3ServerProcessor instance.
Reviewed By: chadaustin
Differential Revision: D41751040
fbshipit-source-id: 2503ecb488b0600bdeabbb11e532e4590edbd280
Summary: define `sl` as a shell function to `HGIDENTITY=sl hg`
Reviewed By: quark-zju
Differential Revision: D41965294
fbshipit-source-id: eb3eebb0dc184a3aae4bcb6ab541a42f9e8b82f8
Summary: Adds installation instructions for installing from Homebrew-core on macOS so that users don't have to manually download our bottle. It also adds one additional installation method for non-Ubuntu Linux users.
Reviewed By: bolinfest
Differential Revision: D42008426
fbshipit-source-id: 76757f43739bca3133e3265d5bbe6175edbc9f11
Summary:
This diff changes our versioning scheme from `MAJOR.MINOR-%Y%m%d-%H%M%S-rHASH` to `MAJOR.MINOR-%Y%m%d-%H%M%S-hHASH`
At the moment we cannot send another PR to Homebrew-core since our lastest release (`0.1.20221212-142634-r7ae28228`) gets detected [as an Erlang version](9c88c39bae/Library/Homebrew/version.rb (L411)) instead of a [hyphenated version](9c88c39bae/Library/Homebrew/version.rb (L427)). This was not an issue in the past since the hashes of our previous releases didn't happen to be of the form (`[Rr]\d+[AaBb]\d*(?:-\d+)?)`).
Reviewed By: bolinfest
Differential Revision: D42006425
fbshipit-source-id: 8dd4c52e1f49b79763bcc5863f7578a0f36dda73
Summary: In D34217873 (bb5656edfc) pyre wrongly assumed 'root' was int, while it is actually str. This diff solves that and removes the related coments
Differential Revision: D42003278
fbshipit-source-id: 91088303b2a671e20fe83aa156b97e97f9cc81d7
Summary: Move the update_distance log up so it fires for the Edenfs case as well.
Reviewed By: quark-zju
Differential Revision: D41750022
fbshipit-source-id: 48df0a58c009bc5bb87d76495d942a53f3089d1a
Summary: Point to the wiki, which is clearer and more similar to the error for large files.
Reviewed By: markbt
Differential Revision: D41840992
fbshipit-source-id: 292f30c0e92cf8627f0646ed503d0e0ba30eae82
Summary: This command allows fetching multiple keys at once. It can be used to tell how many exist, but is most useful to allow repairing/scrubbing many keys at once.
Differential Revision: D41660456
fbshipit-source-id: afcaf789479dc0050817d15c1f54299851cb81db
Summary: This stopped being used on D39698723 (3338746679), but we forgot to remove the code that creates it on integration tests.
Differential Revision: D41874472
fbshipit-source-id: bbb2eccdd53103999523b3e5be2fd9ff7ba85e83
Summary:
`ratelimit_meter` is a deprecated crate. It's owner/maintainer has since forked their own library into `governor` which is actively being worked on and offers a similar API. They have also provided a migration guide.
While functional, `ratelimit_meter` is the only crate vendoring in `smallvec@0.6.13`, which is affected by [`RUSTSEC-2021-0003` - 2021-01-08: Buffer overflow in `SmallVec::insert_many`](https://rustsec.org/advisories/RUSTSEC-2021-0003.html). Since upgrading ratelimit_meter is not an option, the only path forward is to migrate away from it.
Notably, `governer`'s `RateLimiter` also offers an async api surface, which removes the need for portions of `async_limiter`. It also offers one algorithm, a slightly modified GCRA, unlike `ratelimit_meter` which offered two, but according to the author, both algorithms ultimately did the same thing.
Please see `governor`'s migration [guide](https://docs.rs/governor/latest/governor/_guide/index.html) and `ratelimit_meter`'s [github page](https://github.com/antifuchs/ratelimit_meter) for more information.
Reviewed By: chriskonstad
Differential Revision: D41690189
fbshipit-source-id: 0b686f95a9a0346b2b0426f660bcc41e8c6657d3
