Commit Graph

5 Commits

Author SHA1 Message Date
Stanislau Hlebik
99929c0055 mononoke: do not upload same bookmark twice in blobimport
Summary:
Currently we are uploading the same bookmark multiple times. It wasn't a
problem before but now it'd just pollute bookmark log. Let's change it

Reviewed By: ikostia

Differential Revision: D13990921

fbshipit-source-id: 4188d5ca8c304d0356f7b6a67f9c6c3adf861846
2019-02-11 05:50:55 -08:00
Stanislau Hlebik
a75a1453f7 mononoke: add bookmark reason moves
Summary:
This is the first step in adding support for tracking all bookmark moves. They
will be recorded in the separate mysql table in the same transaction as
bookmark is updated.

That gives us two things:
1) Ability to inspect all bookmark moves and debug issues with them
2) Also record which mercurial bundle moved a bookmark if any so that we could
later replay these bundles in correct order on hg

Add a struct that let us track bookmark moves.

Reviewed By: ikostia

Differential Revision: D13958872

fbshipit-source-id: 9adfee6d977457db5af4ad5d3a6734c73fcbcd76
2019-02-11 05:50:54 -08:00
Lukas Piatkowski
c163368a07 blobrepo/src/file.rs: use HgFileNodeId instead of HgNodeHash and propagate it
Summary: HgFileNodeId is a stronger typed id, so it is prefered to use it instead of HgNodeHash whenever it is identifying a filenode

Reviewed By: aslpavel

Differential Revision: D13986172

fbshipit-source-id: c0334652345acb868e86c38b8c0045e9c023c176
2019-02-07 04:04:28 -08:00
Lukas Piatkowski
515a2909eb monononoke hashes: remove usages of borrows of hashes which are Copy
Summary: The Copy trait means that something is so cheap to copy that you don't even need to explicitly do `.clone()` on it. As it doesn't make much sense to pass &i64 it also doesn't make much sense to pass &<Something that is Copy>, so I have removed all the occurences of passing one of ouf hashes that are Copy.

Reviewed By: fanzeyi

Differential Revision: D13974622

fbshipit-source-id: 89efc1c1e29269cc2e77dcb124964265c344f519
2019-02-06 15:11:35 -08:00
Stanislau Hlebik
31421666eb mononoke: move blobimport_lib out of cmdlib
Summary:
Previously blobimport_lib was part of cmdlib. That means that to compile tools
like `mononoke_admin` or `alias_verify` we had to also compile blobimport_lib
code. By moving it outside of cmdlib we are making compilation faster

Reviewed By: HarveyHunt

Differential Revision: D13877528

fbshipit-source-id: c59f92589134588fee2e28ffeef9990bb7e1631f
2019-01-30 06:31:10 -08:00