Commit Graph

5 Commits

Author SHA1 Message Date
Thomas Jacob
dc2e79ae3f tweakdefaults: make --phabdiff use shortdate on --quiet as in default blame
Summary: Added some tests for this also

Test Plan: arc unit in fb-hgext

Reviewers: #sourcecontrol, rmcelroy

Reviewed By: rmcelroy

Subscribers: mjpieters, #sourcecontrol

Differential Revision: https://phabricator.intern.facebook.com/D4397881

Tasks: 15360841

Signature: t1:4397881:1484066348:1b9fb24a30a9962de0dad858f4d57956a2c91dc4
2017-01-10 08:48:02 -08:00
Jun Wu
c030cc61cb tweakdefaults: do not use template for annotate if unnecessary (BC)
Summary:
Template lacks of the "padding" feature. There is a hard-coded 13-char wide
username, 5-char wide line number, which does not look well if the usernames
are too long or too short.

This patch restores the original annotate format which is different from
the current behavior. For example, given "-uc", it shows "user node" instead
of "node:user". It also tries to make the template version as close as the
non-template one, by adjusting the order, changing separators, and making
"-c" optional (could be hidden from the output).

Test Plan: Modified existing tests

Reviewers: #sourcecontrol, ikostia

Reviewed By: ikostia

Subscribers: mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D4243830

Signature: t1:4243830:1480437984:1c679c9db516bab905d027061326a7a1524922c6
2016-11-29 11:18:00 +00:00
Jun Wu
8a3a99ba21 hgext: move single file extensions to hgext3rd
Summary:
Be a better citizen under system python path.

Fix all tests issues and change setup.py to use glob pattern to include
all extensions.

Test Plan:
Run tests and `make local`.
Also build and install the package and run `hg sl` in major repos.

Reviewers: #mercurial, ttung, rmcelroy

Reviewed By: rmcelroy

Subscribers: rmcelroy, durham, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D3534311

Signature: t1:3534311:1468275426:fe122646c8bd6c541e1889e73e9df28f86747ff2
2016-07-08 13:15:42 +01:00
Jun Wu
af343f89df fix code that didn't pass test-check-code-hg.t
Summary:
Fix errors reported by test-check-code-hg.t

```
+  logtoprocess.py:45:
+   >         # https://msdn.microsoft.com/en-us/library/windows/desktop/ms684863(v=vs.85).aspx
+   line too long
   Skipping statprof.py it has no-che?k-code (glob)
+  tests/test-logtoprocess.t:38:
+   > Use head to ensure we wait for all lines to be produced, and sort to avoid
+   trailing whitespace on non-output
+  tests/test-tweakdefaults-blame.t:41:
+   >   $ hg blame -p a
+   trailing whitespace on non-output
+  [1]
```

Test Plan: Run `test-check-code-hg.t` and make sure it pass

Reviewers: #sourcecontrol, rmcelroy, ttung

Reviewed By: rmcelroy

Subscribers: rmcelroy, mjpieters

Differential Revision: https://phabricator.fb.com/D3153195

Tasks: 10749152

Signature: t1:3153195:1460068592:eae6aa682c1f935f7812b72534dd761d898b62a7
2016-04-07 15:52:47 -07:00
Kostia Balytskyi
3137e3c69e tweakdefaults: make blame be able to show Phabricator diffs
Differential Revision: https://phabricator.fb.com/D3076727
2016-04-01 07:41:29 -07:00