Summary:
Forgot to commit, so test build just succeeded as it built with
uncommitted change
Test Plan: ./fb_build_rpm.py --release AAAAAA
Reviewers: simpkins
Reviewed By: simpkins
Subscribers: net-systems-diffs@, mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D3978726
Signature: t1:3978726:1475713413:3dcb5389c562ccc1b5675d2b78bcdb2dcba38780
Summary:
Apparently, clang infers that pointer variables in private
structs are unreferenced if they are aliased by parameter names in the
constructor. This doesn't appear to happen with variable passed by
reference. Unalias the field to work-around the problem.
Test Plan: ./fb_build_rpm.py on OS/X
Reviewers: ttung, durham, simpkins
Reviewed By: simpkins
Subscribers: quark, net-systems-diffs@, mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D3978090
Tasks: 13740577
Signature: t1:3978090:1475709499:e50c751341d172f055ed02376521bd880644b01f
Summary:
This fixes the following error when being compiled by clang:
In file included from ctreemanifest/treemanifest.cpp:10:
ctreemanifest/treemanifest.h:247:15: error: private field 'mainRoot' is not used [-Werror,-Wunused-private-field]
Manifest *mainRoot;
^
Test Plan: `make local` on OS X.
Reviewers: durham, ttung, #sourcecontrol
Subscribers: simpkins, mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D3949603
Summary:
gcc 4.9 complains that erase(0) is ambiguous, and may be either string::erase(size_t)
or string::erase(iterator) (since iterator is "char*", and for historical
reasons 0 can be interpreted as a null char*).
Fix the code to explicitly indicate that it means the erase(size_t) version.
Test Plan: Confirmed that the code built successfully with gcc 4.9.
Reviewers: durham, mitrandir, ttung
Reviewed By: ttung
Subscribers: net-systems-diffs@, yogeshwer, mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D3911252
Signature: t1:3911252:1474589551:688ecab4d59053dbdf7b48a062f248d8363e17f3
