svcscm
3138fa7b9e
Updating submodules
...
Summary:
GitHub commits:
385acc503cb35b183e45
2019-11-18 19:10:27 -08:00
Adam Simpkins
d2aeffb44d
getdeps: update FBPythonBinary.cmake to generate executable files on Windows
...
Summary:
On Windows, compile a small C executable to prepend to the zip file, to allow
the resulting executable files to be run directly on Windows, without needing
to explicitly invoke the Python interpreter to run the output file.
Reviewed By: wez
Differential Revision: D17733616
fbshipit-source-id: 989a93851412d0bbe1e7857aa9111db082f67a4c
2019-11-18 18:41:00 -08:00
svcscm
313ba4d41a
Updating submodules
...
Summary:
GitHub commits:
c570a09dd23724751529279c488395
2019-11-18 18:41:00 -08:00
svcscm
16858dd47d
Updating submodules
...
Summary:
GitHub commits:
aceee6d762551cb91526
2019-11-18 14:23:25 -08:00
svcscm
1bdc539172
Updating submodules
...
Summary:
GitHub commits:
3acb25f216b830bffa96fc7064cb4eaa3975852eb2a3d8944d
2019-11-18 13:08:16 -08:00
svcscm
f62ab09f21
Updating submodules
...
Summary:
GitHub commits:
1c9e11ed1492ef8204de8953a590783983a38d1bb74b833648b43987b039ba7f504899
2019-11-18 11:31:16 -08:00
svcscm
19df9a1b56
Updating submodules
...
Summary:
GitHub commits:
ea4aa9fc0754e6aa5568da41ae5048da70fce0d30bec77c2d209fd20898fb47c7f5c775762809397241c174631
2019-11-18 07:06:27 -08:00
Victor Zverovich
3285a8f909
Replace Folly Format with fmt in logger to reduce binary size
...
Summary:
Now that fmt is available in Folly builds (D14813810), use it to reduce binary code size in Folly Logger. This is done by moving most of the formatting logic behind the type-erased `vformat` API. Previously it was instantiated for all combinations of formatting argument types used in calls to `FB_LOGF` and `XLOGF` in a program.
The effect of this change can be illustrated by looking at symbol sizes as given by `nm -S -td` for the following test function:
```
void test_log() {
FB_LOGF(logger, WARN, "num events: {:06d}, duration: {:6.3f}", 1234, 5.6789);
}
```
compiled in `opt` mode.
`nm` before:
```
0000000004236736 0000000000000231 T test_log()
0000000004236992 0000000000001002 W std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > folly::LogStreamProcessor::formatLogString<int, double>(folly::Range<char const*>, int const&, double const&)
```
`nm` after:
```
0000000004237536 0000000000000231 T test_log()
0000000004237792 0000000000000251 W std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > folly::LogStreamProcessor::formatLogString<int, double>(folly::Range<char const*>, int const&, double const&)
0000000004238048 0000000000000740 W folly::LogStreamProcessor::vformatLogString[abi:cxx11](folly::Range<char const*>, fmt::v5::format_args, bool&)
```
Before we had one 1002 byte instantiation of `formatLogString<int, double>`. With this change it was reduced 4x to 251 bytes and non-template function `vformatLogString` was added which is shared among all logging calls. The size of `test_log` remained unchanged. There are even bigger savings from Folly Formatter instantiations which are no longer needed, e.g.
```
0000000004238032 0000000000001363 W _ZNK5folly13BaseFormatterINS_9FormatterILb0EJRKiRKdEEELb0EJS3_S5_EEclIZNKS7_8appendToINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEENSt9enable_ifIXsr12IsSomeStringIT_EE5valueEvE4typeERSH_EUlNS_5RangeIPKcEEE_EEvSK_
```
So in total this change results in ~5x per-call/instantiation binary size. It is possible to reduce binary size even further but it is not done in the current diff to keep it manageable.
In addition to binary size improvements, switching to fmt will potentially
* allow catching errors in format strings at compile time,
* simplify future migration to C++20 [`std::format`](http://eel.is/c++draft/format ).
Reviewed By: simpkins
Differential Revision: D15485589
fbshipit-source-id: 06db4436839f11c2c3dbed7b36658e2193343411
2019-11-18 05:53:08 -08:00
svcscm
05e5741cc9
Updating submodules
...
Summary:
GitHub commits:
3062e817bf3e9812cf6b05d9eea2c0
2019-11-18 05:53:08 -08:00
svcscm
b1c572092f
Updating submodules
...
Summary:
GitHub commits:
eeb38ffd62f27f096824d5c51096af76432027c0e6135854c583800eae9a5a5b563db5
2019-11-17 18:37:38 -08:00
svcscm
21e7fd27e0
Updating submodules
...
Summary:
GitHub commits:
b5fa56c4e4414aa7f2d5a0ceaf440c295a0662c2214cd3295fbe9c6db57aec7569b9b9
2019-11-17 17:21:59 -08:00
svcscm
7a53f38c11
Updating submodules
...
Summary:
GitHub commits:
8f2eb5c69a4a4926a64a8e0ca4677e2ca3bf578d7c5d25d54f4aa70edfce4597821b3a309dc6604d
2019-11-16 16:54:35 -08:00
Wez Furlong
eee586ea4f
getdeps: fix node/yarn detection for watchman builds
...
Summary:
When we detect that we are building out of the fbsource
monorepo internal to FB, pre-set some environment variables to help
projects detect our internally pinned versions of node and yarn.
Previously, the detection logic was deciding that the `yarn` shell
script was the executable to invoke, but since that is a bash script
it would fail to spawn.
Reviewed By: simpkins
Differential Revision: D18523871
fbshipit-source-id: b932d2b0ccd7b79d6f9cd74d363bc426c288e38f
2019-11-16 16:17:32 -08:00
svcscm
f301356f93
Updating submodules
...
Summary:
GitHub commits:
207328497ac272123098cdcd46de4e1c093d3fa7e18b3c2e6e746161a422
2019-11-16 06:09:48 -08:00
svcscm
35e1f88a5f
Updating submodules
...
Summary:
GitHub commits:
ad9b5695cc36862d7625
2019-11-15 17:08:40 -08:00
svcscm
8c45a850f9
Updating submodules
...
Summary:
GitHub commits:
c0c421beeb
2019-11-15 14:21:41 -08:00
svcscm
7a8bb97245
Updating submodules
...
Summary:
GitHub commits:
c24f26fe23
2019-11-15 10:49:43 -08:00
svcscm
33e8f2ed77
Updating submodules
...
Summary:
GitHub commits:
61f165b8f9
2019-11-15 09:48:10 -08:00
svcscm
8d510c0525
Updating submodules
...
Summary:
GitHub commits:
770b887986
2019-11-14 23:17:20 -08:00
svcscm
b9569ab08f
Updating submodules
...
Summary:
GitHub commits:
20080a6338170bb2ae47
2019-11-14 22:04:38 -08:00
svcscm
1718045feb
Updating submodules
...
Summary:
GitHub commits:
35d49a558b8f12df2a87ceabf4daaf0058daef7b4574f38a41aedd6286e5
2019-11-14 17:14:18 -08:00
svcscm
97dfb32ff6
Updating submodules
...
Summary:
GitHub commits:
df16a5e175a91912f485b25002139f141c6d9ccad02b9c97abb06a5e5923
2019-11-14 13:57:44 -08:00
svcscm
fcca32a488
Updating submodules
...
Summary:
GitHub commits:
3de8f357ee4468e01836
2019-11-14 11:14:05 -08:00
svcscm
45dd628557
Updating submodules
...
Summary:
GitHub commits:
401178e861916f8c2477f059c7d9b9dca5f88a84
2019-11-13 20:32:17 -08:00
svcscm
5fc3d15232
Updating submodules
...
Summary:
GitHub commits:
1deef35e630ff7470bdd43dfa89c99
2019-11-13 20:16:37 -08:00
svcscm
0a46a2715b
Updating submodules
...
Summary:
GitHub commits:
fe2aa2895c9735191ff9
2019-11-13 15:23:37 -08:00
svcscm
e26f21353c
Updating submodules
...
Summary:
GitHub commits:
553d3973592a1dc6cf794bd2132eaace60998143
2019-11-12 19:42:14 -08:00
svcscm
d26acc0dbe
Updating submodules
...
Summary:
GitHub commits:
c8ebdc978167c9b0925c9428045992103322c93be3917f1902edcf5e006b83b8ff6b69
2019-11-12 18:19:44 -08:00
svcscm
acbc85e12c
Updating submodules
...
Summary:
GitHub commits:
ae1758dc6742b5494ec835c4a5d481
2019-11-12 16:31:54 -08:00
svcscm
2f526e9753
Updating submodules
...
Summary:
GitHub commits:
56c338eee0
2019-11-12 03:19:14 -08:00
svcscm
b630f7ad8b
Updating submodules
...
Summary:
GitHub commits:
a5381c4d13a19de78da5b5a7d0259c8c4e217115
2019-11-12 03:19:13 -08:00
svcscm
abcdf32d2f
Updating submodules
...
Summary:
GitHub commits:
2bdb5a4a7cdfd521981666f868b7450c4130d051c912150192c17384fea4e0b21568297aef78fb2e
2019-11-11 16:20:23 -08:00
svcscm
60d252f6c3
Updating submodules
...
Summary:
GitHub commits:
c10f5bf664b6d8b723b735f57f4100286e860fbc8996c5393f
2019-11-11 10:56:15 -08:00
svcscm
bf47c6c0ab
Updating submodules
...
Summary:
GitHub commits:
84ff1378e7
2019-11-11 07:24:40 -08:00
svcscm
ffa7b12bd7
Updating submodules
...
Summary:
GitHub commits:
3b56786f08aabaf3c3d7
2019-11-10 12:22:16 -08:00
svcscm
c85be4ccff
Updating submodules
...
Summary:
GitHub commits:
8d9e9cd41f4c3495f81b
2019-11-09 15:23:31 -08:00
svcscm
24480ecb63
Updating submodules
...
Summary:
GitHub commits:
1f41d7adb1c8fcfd74b572de842ac9
2019-11-08 18:30:30 -08:00
svcscm
89aa512894
Updating submodules
...
Summary:
GitHub commits:
403ca8188d74c43417f70e5d305664
2019-11-07 17:52:53 -08:00
svcscm
b73994cc00
Updating submodules
...
Summary:
GitHub commits:
d752e52a31d7cc18d7c76e26fa9d0376fcc9469a1da1f0423117ff03e136d8fde1c7fc8a07c4270c50fdf05973affb36ec7c
2019-11-07 17:26:08 -08:00
svcscm
1ed65ea690
Updating submodules
...
Summary:
GitHub commits:
6111b3b680930b238caa7e195929d5b90eedb63d16416eb27db0817301e07b3222e10ad4a937d86e80a314d94b3e6590ad4bfad1d3411ccb8da69f5d
2019-11-07 10:53:20 -08:00
John Strizich
69842e578c
remove libnl depedency from open source build
...
Summary: We removed this dependency in the code a while ago.
Reviewed By: saifhhasan
Differential Revision: D18366401
fbshipit-source-id: daf1c7865fe0c312694bdf395f9d7ace99f70395
2019-11-06 21:17:08 -08:00
svcscm
d95af19013
Updating submodules
...
Summary:
GitHub commits:
2c518441de8ea087ad16
2019-11-06 16:44:22 -08:00
svcscm
f88fddfc59
Updating submodules
...
Summary:
GitHub commits:
0a9dd201d450804656d2ed7646cad2
2019-11-06 12:11:54 -08:00
svcscm
b176ee20db
Updating submodules
...
Summary:
GitHub commits:
85d753b71d683e83b59a
2019-11-06 11:31:42 -08:00
svcscm
69c4f4e956
Updating submodules
...
Summary:
GitHub commits:
9de1c22848975dc0f92310679bfd01
2019-11-06 01:22:40 -08:00
svcscm
2d68b41676
Updating submodules
...
Summary:
GitHub commits:
d5828b3036a145c9c1f3834feaff05
2019-11-06 01:22:39 -08:00
svcscm
a80377c037
Updating submodules
...
Summary:
GitHub commits:
f36bffb729d3676acb29d697e42c4294495a809767e735dbf9c2e1e16bbc950f8d0dfaee0c193c5d
2019-11-05 19:09:10 -08:00
svcscm
1911739789
Updating submodules
...
Summary:
GitHub commits:
de05e0e7acb6641eb7faec1aa6936b80479de3f7
2019-11-05 18:28:05 -08:00
svcscm
aae7ac4d82
Updating submodules
...
Summary:
GitHub commits:
88800af4cb
2019-11-05 06:27:17 -08:00
svcscm
a824b61155
Updating submodules
...
Summary:
GitHub commits:
b35bea8f074e9b180439
2019-11-04 05:57:28 -08:00
