Commit Graph

2 Commits

Author SHA1 Message Date
Jun Wu
da0b66a8ec copytrace: fix an issue where undesirable entries are reported
Summary:
This solves an issue vipannalla saw that the heuristics logic behaves incorrectly
when running `hg up -C c4a88583; hg graft 23001ead`. The file `great_persons_on_ex_civilization-inl.h`
would be marked as "unresolved" and removed from the working copy potentially
due to other mergedriver actions, while it should be merged cleanly and do not
appear in mergestate at all.

After debugging, the file was only renamed on one side, and not changed on the
other side. In the heuristics code path, the file was reported as copied and
confused the callsite.

Reviewed By: singhsrb

Differential Revision: D14195031

fbshipit-source-id: 0602fd56b75219f851c0175debfe72c4d49d652d
2019-02-25 12:43:20 -08:00
Jun Wu
3f0893c3ab tests: add a test showing suboptimal copytrace + mergedriver behavior
Summary: As explained in the test.

Reviewed By: singhsrb

Differential Revision: D14195032

fbshipit-source-id: 29a19d5ad4abd4a8d77480bd72922b8967a11997
2019-02-25 12:43:20 -08:00