Commit Graph

45 Commits

Author SHA1 Message Date
Jun Wu
9579fc67be edenapi: remove tools
Summary:
`hg debugapi` now provides easier ways to test edenapi endpoints.
Remove the `edenapi/tools` to reduce code bloat. This also unblocks removing
`To/FromJson` complexity so adding new endpoints become easier.

Reviewed By: yancouto

Differential Revision: D31465796

fbshipit-source-id: fdc0a47b4302c876e78455101068f27949d1b645
2021-10-13 15:21:28 -07:00
Genevieve Helsel
7c69d0b55e prepare for master -> main branch rename
Reviewed By: ahornby

Differential Revision: D31114901

fbshipit-source-id: eef24bca0ca3e22ae78d3d158046b7a59e90c4cf
2021-09-23 11:23:05 -07:00
David Tolnay
6ce5dce1be Update to Rust 1.55.0
Summary: Release notes: https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html

Reviewed By: jsgf

Differential Revision: D30859665

fbshipit-source-id: 89db9befd805babe3405522842864500550d5c8c
2021-09-16 22:24:04 -07:00
David Tolnay
c86c8d71ce Update to Rust 1.54.0
Summary: Release notes: https://blog.rust-lang.org/2021/07/29/Rust-1.54.0.html

Reviewed By: zertosh

Differential Revision: D30007531

fbshipit-source-id: ad85c526cb24bd111bef820c7887c4f5e44b79fe
2021-07-30 08:42:15 -07:00
Patrick Walton
84fa20e621 Update Rust to version 1.53.0 (with LLVM 9 support forward ported)
Summary:
This updates the symlinks to `third_party2` to the newest version of Rust. This
was attempted before but failed because upstream Rust stopped supporting the
version of LLVM that `platform009` uses. This new commit works.

Reviewed By: dtolnay

Differential Revision: D29497424

fbshipit-source-id: a2a8444564c3c7ad19df9423f5e82ab6738dd2ef
2021-07-13 17:28:46 -07:00
David Tolnay
1b4a0ae6b5 Revert D29233697: Update to Rust 1.53.0
Differential Revision:
D29233697 (96d72c6887)

Original commit changeset: 72c6d8501d5a

fbshipit-source-id: d0235b731c3f689cea52e27d6d7eb75f7877a02f
2021-06-21 20:11:43 -07:00
David Tolnay
96d72c6887 Update to Rust 1.53.0
Summary: Release notes: https://blog.rust-lang.org/2021/06/17/Rust-1.53.0.html

Reviewed By: jsgf

Differential Revision: D29233697

fbshipit-source-id: 72c6d8501d5a0d19b3beb08e56d4a5f639219da5
2021-06-21 16:11:03 -07:00
David Tolnay
0812a1deb8 Update to Rust 1.52.1
Reviewed By: pcwalton, jsgf

Differential Revision: D28430635

fbshipit-source-id: b3a4f19623055547a2d6e7b704484dfc2aed459f
2021-05-19 22:13:47 -07:00
Jeremy Fitzhardinge
cd15103165 tp2/rust: 1.51.0 update
Summary:
Fixes needed:
- buck2/linter commented out - unstable API change
- hermetic/reverie - ExitStatusExt sealed (fixed in D27637862)
- Iterator::fold_first stabilized as reduce
- panic!() requires literal format string (fixed in D27672891)

I didn't change anything under scripts/ - a lot of it looked like it was already broken.

Reviewed By: dtolnay

Differential Revision: D27654989

fbshipit-source-id: d1eac6e51686dfb74c87cec8718f075066df4b8f
2021-04-09 16:24:33 -07:00
Alex Hornby
8c8dfe0604 getdeps: update github actions to python 3
Summary:
Manual import from https://github.com/facebookexperimental/eden/pull/81 as the auto import mapped the .yml paths incorrectly

Updates eden/scm/Makefile to use python3 so we don't need to install multiple py versions

Adds hgext.convert.repo to setup3.py packages as mononoke tests showed it was missing

Updates github actions python versions

Reviewed By: quark-zju

Differential Revision: D27367568

fbshipit-source-id: 3817bdc1c48a8f7bfa8e29b5f7ec87d0eed579a9
2021-03-28 09:32:36 -07:00
David Tolnay
1ae53c794f Update symlinks for Rust 1.50.0
Summary: Release notes: https://blog.rust-lang.org/2021/02/11/Rust-1.50.0.html

Reviewed By: jsgf, Imxset21

Differential Revision: D26363768

fbshipit-source-id: 25188531cf0a5647128cbeb469225d8dd756d0af
2021-02-12 13:54:50 -08:00
David Tolnay
00e6c4f3e3 Update to Rust 1.49.0
Summary: Release notes: https://blog.rust-lang.org/2020/12/31/Rust-1.49.0.html

Reviewed By: jsgf

Differential Revision: D25866484

fbshipit-source-id: 25a584547df858f71e76ab0cc88e1adeaac070c7
2021-01-19 17:46:47 -08:00
Lukasz Piatkowski
f9e981817b simplify env setting for all steps using GITHUB_ENV (#70)
Summary: Pull Request resolved: https://github.com/facebookexperimental/eden/pull/70

Reviewed By: mitrandir77

Differential Revision: D25474319

Pulled By: lukaspiatkowski

fbshipit-source-id: efa3a02c270b2fa44922de3c140b0b60bf11bf9e
2020-12-11 05:00:20 -08:00
David Tolnay
b682dd6315 Update to Rust 1.48.0
Summary: Release notes: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1480-2020-11-19

Reviewed By: jsgf

Differential Revision: D25011931

fbshipit-source-id: 04ad2c41d1589c7514b0550b20fd8ae0015dc118
2020-11-18 12:47:46 -08:00
Lukas Piatkowski
c70fe5dcf3 mononoke/GitHub workflows: remove beta and nightly testing from GitHub Actions
Summary: Those tests weren't really actionable, no one was paying attention to them and they recently started to report the whole job as failed even though the continue-on-error option was true. Just remove them.

Reviewed By: krallin

Differential Revision: D24645209

fbshipit-source-id: b21503a43db2afc82cccddc7fe6dd1daca2028dd
2020-10-30 03:10:19 -07:00
Lukas Piatkowski
ba1369bdfb rust/oss: update rustc version to 1.47 in rust-shed and eden GitHub workflows (#14)
Summary:
Pull Request resolved: https://github.com/facebookexperimental/rust-shed/pull/14

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/68

Internal codebase was updated to 1.47 with code changes that are no longer compatible with 1.44. Updating to OSS 1.47 to fix build.

Reviewed By: ikostia, mzr

Differential Revision: D24389087

fbshipit-source-id: b4152b7761b4f584e44ff5e0dfe415414ced8a94
2020-10-19 03:53:24 -07:00
Lukas Piatkowski
1b5293d584 mononoke/integration: create a Makefile to run tests as part of getdeps.py build (#67)
Summary:
Pull Request resolved: https://github.com/facebookexperimental/eden/pull/67

With this change it will be possible to build dependencies of and run integration tests using getdeps.py.

This is the first goal of Q4 as per https://fb.quip.com/v8YzAYNSYgot: "Get Open Source version of integration tests running on Legocastle".

Before this diff:
The OSS integration tests run now on GitHub by:
- Building some test dependencies with getdeps.py
- Building some test dependencies with homebrew/apt-get
- Running tests via python script

The OSS integration tests were not running on Sandcastle.

After this diff:
The OSS integration tests run on Github by:
- Building and executing tests via getdeps.py (execution of tests happens by getdeps.py calling Make calling python script)

The OSS integration tests run on Sandcastle using the same getdeps.py setup as Github.

Reviewed By: krallin

Differential Revision: D24253268

fbshipit-source-id: cae249b72d076222673b8bbe4ec21866dcdbb253
2020-10-16 12:23:33 -07:00
Lukasz Piatkowski
2f2fd50a90 pin rustc to 1.44 (#66)
Summary:
This fixes build errors on GitHub.

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/66

Reviewed By: jsgf

Differential Revision: D24254833

Pulled By: lukaspiatkowski

fbshipit-source-id: 85cd791f0ef86cc791885fe5cfcbee3a9b88af39
2020-10-12 11:13:24 -07:00
Lukas Piatkowski
563f866548 mononoke/integration: build EdenSCM with non system OpenSSL (#12)
Summary:
Pull Request resolved: https://github.com/facebookexperimental/rust-shed/pull/12

The OpenSSL version on Mac doesn't work well with EdenSCM and Mononoke integration, just use the one from getdeps/brew.

Also remove the now redundant "DEVELOPER_DIR" since the modern XCode version works.

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/63

Reviewed By: StanislavGlebik

Differential Revision: D23927022

Pulled By: lukaspiatkowski

fbshipit-source-id: 6b6b3baa33d49b567b9aa6178cbd20b7ae9edc89
2020-09-26 12:31:14 -07:00
Lukasz Piatkowski
e8098beff0 mononoke/integration tests: fix issue with missing dulwich for hggit ext (#59)
Summary: Pull Request resolved: https://github.com/facebookexperimental/eden/pull/59

Reviewed By: farnz

Differential Revision: D23783095

Pulled By: lukaspiatkowski

fbshipit-source-id: cb6a72ae3d8856a92945c28e4162c1808539206a
2020-09-19 05:47:30 -07:00
Lukas Piatkowski
78d30ad17f eden/edenapi and mononoke integration tests: add edenapi/tools to getdeps and use them in tests (#51)
Summary:
Pull Request resolved: https://github.com/facebookexperimental/eden/pull/51

This diff extends capabilities of CargoBuilder in getdeps so that individual manifests can be build even without workspaces. Thanks to that a build for edenapi/tools can be made and its artifacts can be used in mononoke integration tests.

Reviewed By: StanislavGlebik

Differential Revision: D23574887

fbshipit-source-id: 8a974a6b5235d36a44fe082aad55cd380d84dd09
2020-09-18 04:20:56 -07:00
Lukasz Piatkowski
64da367e63 mononoke/integration CI: try to free up some space before running tests (#57)
Summary:
We are running out of space on integration tests runs on Linux. In order to avoid that this change is adding some cleanups.

1. Adding `docker rmi $(docker image ls -aq)` frees up 4 GB.
2. Cleaning up `eden_scm` build directory frees up 3 GB.
3. Cleaning up `mononoke` build directory frees up 1 GB.

This diff also includes a fix for run_tests_getdeps.py where we run all the "PASSING" tests when --rerun flag is passed instead of only the failed ones.

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/57

Reviewed By: krallin

Differential Revision: D23742159

Pulled By: lukaspiatkowski

fbshipit-source-id: 3b5e89ad29c753d585c1a6f01a9a1d6c1e616fbf
2020-09-17 07:38:53 -07:00
Lukasz Piatkowski
c044f1669a mononoke/integration tests: deal with bash issues on tests (#50)
Summary:
One test was fixed earlier by switching MacOS to use modern version of bash, the other is fixed here by installing "nmap" and using "ncat" from within it on both linux and mac.

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/50

Reviewed By: krallin

Differential Revision: D23599695

Pulled By: lukaspiatkowski

fbshipit-source-id: e2736cee62e82d1e9da6eaf16ef0f2c65d3d8930
2020-09-10 01:56:54 -07:00
Lukasz Piatkowski
c983dc96fe mononoke/integration tests: fix using private certs during Mac tests with hg (#53)
Summary:
The Mac integration test workflow already installs a modern curl that fixes https://github.com/curl/curl/issues/4801, but it does so after "hg" is built, so "hg" uses the system curl libraries, which fails when used with a certificate not present in keychain.

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/53

Reviewed By: krallin

Differential Revision: D23597285

Pulled By: lukaspiatkowski

fbshipit-source-id: a7b8b6ae55ce338bfb9946a852cbb6b929e73203
2020-09-09 07:28:09 -07:00
Jon Janzen
3e9ba05f80 Add github action to auto-release TagIt tags
Summary:
This came from a [request from Fred Emmott](https://fb.workplace.com/groups/osssupport/permalink/4116491528399431/), but also is something we should do due to the GitHub UI redesign:

Nowadays on GitHub, tags are not shown in the sidebar (just the count) and instead GitHub Releases are prioritized and the most recent *release* is shown.

Secondly, the Source Code zip archives for tags/releases are created on-the-fly on GitHub. This can cause problems for downstream projects that need consistent content hashes of the archive for security/reproducability reasons. This action also creates its own archives (zip and tar.gz) and attaches them to the release.

Reviewed By: fredemmott

Differential Revision: D23167073

fbshipit-source-id: 463e9d93a2c4af260ac3c4dbc1ceab7894add714
2020-08-18 13:31:10 -07:00
Jun Wu
f8d9e51bc9 github: rename "EdenSCM HG" to "EdenSCM"
Summary: Make it consistent with the top-level README which does not use the "HG" name.

Reviewed By: kulshrax

Differential Revision: D23176134

fbshipit-source-id: 2d809cfa89234d00c714f9db381a138e9f03fc64
2020-08-18 12:39:08 -07:00
Lukas Piatkowski
16182e626b mononoke/integration tests: use newer bash version on MacOS GitHub CI runs
Summary: Use brew on MacOS GitHub CI runs to update bash from 3.* to 5.*.

Reviewed By: krallin

Differential Revision: D22762195

fbshipit-source-id: b3a4c9df7f8ed667e88b28aacf7d87c6881eb775
2020-07-28 08:02:52 -07:00
Lukas Piatkowski
88782c8f69 mononoke/integration tests: use GNU command lines to run tests on MacOS
Summary: MacOS uses FreeBSD version of command line tools. This diff uses brew to install the GNU tooling on GitHub CI and uses it to run the integration tests.

Reviewed By: krallin

Differential Revision: D22762198

fbshipit-source-id: 1f67674392bf6eceea9d2de02e929bb3f9f7cadd
2020-07-28 08:02:52 -07:00
Lukas Piatkowski
d5dd156cfb mononoke/integration tests: install missing jq command on MacOS
Reviewed By: krallin

Differential Revision: D22762192

fbshipit-source-id: 73f12e65c3ab63910638f16197e5629a7d6efb2c
2020-07-27 14:35:01 -07:00
Lukas Piatkowski
db06969e0d mononoke/integration tests: create exclusion list of integration tests
Summary: Have a comprehensive list of OSS tests that do not pass yet.

Reviewed By: krallin

Differential Revision: D22762196

fbshipit-source-id: 19ab920c4c143179db65a6d8ee32974db16c5e3d
2020-07-27 14:35:01 -07:00
Lukas Piatkowski
2c5cc232fc mononoke/x509 identity: add OSS parsing of x509 certificates (#32)
Summary:
Pull Request resolved: https://github.com/facebookexperimental/eden/pull/32

This parsing uses the standard "subject name" field of a x509 certificate to create MononokeIdentity.

Reviewed By: farnz

Differential Revision: D22627150

fbshipit-source-id: 7f4bfc87dc2088bed44f95dd224ea8cdecc61886
2020-07-24 09:05:52 -07:00
Lukasz Piatkowski
8053f99ccb fix a typo in GitHub workflow definition for Mononoke MacOs build (#31)
Summary: Pull Request resolved: https://github.com/facebookexperimental/eden/pull/31

Reviewed By: HarveyHunt

Differential Revision: D22625551

Pulled By: lukaspiatkowski

fbshipit-source-id: 3de0c6fb365d695ee3206efb9d1185cdef8a64bb
2020-07-20 04:50:12 -07:00
Lukasz Piatkowski
44c4ca8597 pass --allow-system-packages to getdeps.py build of Mononoke (#28)
Summary:
Using system packages speeds up the build process

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/28

Reviewed By: StanislavGlebik

Differential Revision: D22579916

Pulled By: lukaspiatkowski

fbshipit-source-id: 7315dc898143d44e2be29a1fa9c15554c5775b35
2020-07-17 00:36:06 -07:00
Lukasz Piatkowski
0dd3c4e4bb add Mononoke integration tests CI (#26)
Summary:
This diff adds a minimal workflow for running integrations tests for Mononoke. Currently only one test is run and it fails.

This also splits the regular Mononoke CI into separate files for Linux and Mac to match the current style in Eden repo.
There are the "scopeguard::defer" fixes here that somehow escaped the CI tests.
Some tweaks have been made to "integration_runner_real.py" to make it runnable outside FB context.
Lastly the change from using "[[ -v ... ]" to "[[ -n "${...:-}" ]]; in "library.sh" was made because the former is not supported by the default Bash version preinstalled on modern MacOS.

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/26

Reviewed By: krallin

Differential Revision: D22541344

Pulled By: lukaspiatkowski

fbshipit-source-id: 5023d147823166a8754be852c29b1e7b0e6d9f5f
2020-07-16 12:16:10 -07:00
Lukasz Piatkowski
75ae342768 edenscm/hg: add GitHub Actions with CI for HG plus add fixes for getdeps (#25)
Summary:
Fixes include:
1. Passing "GETDEPS_BUILD_DIR" and "GETDEPS_INSTALL_DIR" env variable and using them in eden/scm/Makefile rather than assuming the source code is always in the same place regardless getdeps arguments (it isn't).
2. Added "fbthrift-source" and "fb303-source" to avoid unnecessary compilation (at least of fb303) and to put fbthrift and fb303 source code in an easy to locate place inside getdeps' "installed" folder.

Pull Request resolved: https://github.com/facebookexperimental/eden/pull/25

Test Plan: sandcastle, check oss-eden_scm-darwin-getdeps

Reviewed By: farnz

Differential Revision: D22431872

Pulled By: lukaspiatkowski

fbshipit-source-id: 8ccbb090713ec085a5dd56df509eb58ab6fb9e34
2020-07-10 12:07:45 -07:00
Jun Wu
fdd4fb1fcd github: do not test edenapi crate
Summary: It was moved by D22305173 (fdba0b98c2). Skip testing it.

Reviewed By: kulshrax

Differential Revision: D22364199

fbshipit-source-id: 3e205daa5aac517020664005a6f95d0292674bc3
2020-07-02 18:46:28 -07:00
Jun Wu
43d7d8ce45 github: do not test stackdesc crate
Summary: It was removed by D22129585 (1020f76e7d). Skip testing it.

Reviewed By: kulshrax

Differential Revision: D22288183

fbshipit-source-id: 07b483028f75df5af9565c9ed693f2299d43f4b2
2020-06-29 20:39:15 -07:00
Lukasz Piatkowski
e326cdb0bd GitHub Actions: fix running out of space on Ubuntu build workflow (#23)
Summary:
As per https://github.com/actions/virtual-environments/issues/709 there started to be some issies with Ubuntu envs running out of space. This should fix it.

Also our Cargo builds use a lot of space, changing them to be non-incremental and removing debug symbols keeps the build fast, but greatly reduces the disk space usage leaving us enough space on GitHub Actions virtual machines.
Pull Request resolved: https://github.com/facebookexperimental/eden/pull/23

Reviewed By: farnz

Differential Revision: D22160020

Pulled By: lukaspiatkowski

fbshipit-source-id: c23393e310c15ebf5a18b80f0bb5f1f894d24849
2020-06-22 07:50:25 -07:00
Lukasz Piatkowski
6a3553cab5 Github Actions: fix MacOS builds - use old XCode version (#22)
Summary:
Boost 1.69 doesn't build with XCode >=11.0 according to https://trac.macports.org/ticket/60287 Downgrading XCode to old version seems to fix this (Selecting done as described in https://www.jessesquires.com/blog/2020/01/06/selecting-an-xcode-version-on-github-ci/)
Pull Request resolved: https://github.com/facebookexperimental/eden/pull/22

Reviewed By: farnz

Differential Revision: D22118747

Pulled By: lukaspiatkowski

fbshipit-source-id: 31acc6298cdcf7c5a75a8be38d6dd0deb90c5bd2
2020-06-18 13:43:06 -07:00
Lukas Piatkowski
abe2c69df3 mononoke/fbcode_builder: bring back mononoke manifests for getdeps build
Summary:
The breakage has been fixed, so bring back the manifest, but only the Linux one, because the Mac version is failing due to another issue.

Also to make it easier to debug issues on GitHub Actions separate out the dependencies build from Mononoke and rust-shed builds.

Reviewed By: krallin

Differential Revision: D21448412

fbshipit-source-id: 68d89c858d1692727a7fd66bca114920e6dfb4dc
2020-05-07 23:45:44 -07:00
Xavier Deguillard
fd72344578 revisionstore: feature gate the Mononoke LFS tests
Summary:
Due to the Mononoke LFS server only being available on FB's network, the tests
using them cannot run outside of FB, including in the github workflows.

Reviewed By: quark-zju

Differential Revision: D20698062

fbshipit-source-id: f780c35665cf8dc314d1f20a637ed615705fd6cf
2020-03-30 08:40:43 -07:00
Wez Furlong
da172f992a mononoke: simplify GH actions workflows
Summary:
These were originally generated by getdeps, but since they
have been manually modified they are no longer regeneratable via
the getdeps tooling.

Simplify and just call the getdeps build rather than replicating
the discrete project fetches: they aren't required to break out
separately it just looks nice in the CI output--they will be fetched
on demand during the build anyway.

Reviewed By: simpkins

Differential Revision: D20660208

fbshipit-source-id: b6c63333e842d2bd1ba2fb574f8f082dcefef89e
2020-03-26 05:51:47 -07:00
Wez Furlong
37d232db3c getdeps: embrace python3 a bit more
Summary:
Ensure that we are referencing python3 in the paths
that we generate for the github actions workflows, and remove
some shebangs that influence how our internal linters process
the python code.

Reviewed By: fanzeyi

Differential Revision: D20659747

fbshipit-source-id: 6f300f8e91edf7701bb27babc7b1418958cf0a10
2020-03-26 05:46:17 -07:00
Jun Wu
6a015a82fc add GitHub workflow for testing scm/lib crates
Summary:
Similar to the Mononoke CI, run tests on the open-source version of the Rust crates.
Crates that do not build are commented out with reasons.

`target-dir` is explicitly set so all crates share a single build cache.

This helps us capture issues with wrong versions specified in `Cargo.toml`, since
internally we use vendored crates, while externally `crates.io` is used.

Reviewed By: sfilipco

Differential Revision: D20376183

fbshipit-source-id: 8cf4df0c893c1119e07f950eaf398313e2efcc25
2020-03-11 12:00:16 -07:00
Lukasz Piatkowski
31b602a6d0 Add GitHub workflows configuration for Mononoke CI. 2020-02-14 12:21:00 +01:00