Commit Graph

2 Commits

Author SHA1 Message Date
Alexandre Marin
d3523cdc77 Feedback
Summary:
dsp had a look at the whole stack and suggested some changes:

* Only write bookmark once at the end of the import - we are doing a single transaction anyways so updating the bookmark after every changelist import is moot
* Remove unused function seqimporter.ChangelistImporter._safe_open
* Require fncache to preserve behavior from p4fastimport

Differential Revision: D7375481

fbshipit-source-id: f4407d5d0276f96d72bf67544091640fe1c46044
2018-04-13 21:51:44 -07:00
Alexandre Marin
738df53c01 Test branching
Summary:
Testing that p4seqimport works properly for branching
Based on comment on D7172867

For a high-level overview of p4seqimport, please check https://our.intern.facebook.com/intern/wiki/IDI/p4seqimport/

Differential Revision: D7203765

fbshipit-source-id: 2e328f5b43fc47a60bfe2c41f9454f8471dda814
2018-04-13 21:51:44 -07:00