Summary:
This diff makes the code closer to shell behavior.
For example, globs are disabled for both single and double quotes:
~ % echo /bin/bash*
/bin/bash /bin/bashbug
~ % echo "/bin/bash*"
/bin/bash*
~ % echo '/bin/bash*'
/bin/bash*
Environment variables are not expanded for single qutoes:
~ % echo $PWD
/home/quark
~ % echo "$PWD"
/home/quark
~ % echo '$PWD'
$PWD
Tests using single quoted environment varialbes are updated to use double
quotes, mostly by using this vim command:
%s/\(sh % ".*\)'\([^'$]*\$[^']*\)'/\1\\"\2\\"
The translation script was updated to prefer double quotes to preserve
environment variable expansion behavior.
Reviewed By: xavierd
Differential Revision: D17675351
fbshipit-source-id: d5c8d5f23ea8e29fe093c4e6ae89ddacda97141e
Summary:
Those tests were converted using:
echo *.t | xargs -P20 -n1 python -m testutil.dott.translate --black --verify
They run 5x faster (via run-tests.py), and 10x faster (via python directly).
run-tests.py on old .t files, 652 CPU seconds:
% time ./run-tests.py `cat list-t.txt` --noprogress
.................................................................................................................................
# Ran 129 tests, 0 skipped, 0 failed.
./run-tests.py `cat list-t.txt` --noprogress 505.30s user 146.37s system 1451% cpu 44.899 total
run-tests.py on new py tests, 135 CPU seconds:
% time ./run-tests.py `cat list-py.txt` --noprogress
.............................................................................................................................
# Ran 125 tests, 0 skipped, 0 failed.
./run-tests.py `cat list-py.txt` --noprogress 55.73s user 78.80s system 744% cpu 18.061 total
vanilla python on new tests, 59 CPU seconds:
% time (for i in `cat list-py.txt`; do python $i; done;)
( for i in `cat list-py.txt`; do; python $i; done; ) 41.61s user 17.47s system 90% cpu 1:05.31 total
The new tests also have auto fix ability. `python test-foo-t.py --fix` will
autofix the code.
Reviewed By: xavierd
Differential Revision: D16172902
fbshipit-source-id: dda53990a7dfff5ac214c1237e4206a4d67e8e48
