Commit Graph

2 Commits

Author SHA1 Message Date
Ryan McElroy
2e0e2f49f6 remotenames: do not expect repo._remotenames to be set unconditionally
Summary:
There are cases when a local repo communicates to another local repo
where one of the repos has remotenames enabled and the other does not that lead
to crashes. We fix these cases by checking repo objects for _remotenames before
accessing that member variables.

Differential Revision: D7023300

fbshipit-source-id: e4df06671bfb8291f50c01b53750ccaa3f9df968
2018-04-13 21:51:13 -07:00
Ryan McElroy
b4e16cf52b remotenames: test various combinations of repos with and without extension
Summary:
Cases from sandcastle make it clear that there are circumstances where
a one local repo talks to another local repo, one with remotenames enabled and
the other without remotenames enabled, that crashes can happen.

Let's add a test case to find some of these so we can prove they are fixed.

Differential Revision: D7023299

fbshipit-source-id: ddc8a701ac7573bcc15f737df1c5e29ef3581201
2018-04-13 21:51:13 -07:00