Commit Graph

61611 Commits

Author SHA1 Message Date
Alex Hornby
511530d030 mononoke: change the default blobstore put behaviour to IfAbsent
Summary: Change the default blobstore put behaviour to IfAbsent, so that all binaries apart from admin tools using MononokeApp::special_put_behaviour() pick up the change.

Reviewed By: farnz

Differential Revision: D24619663

fbshipit-source-id: 98439513b985d2cde88ef99e5eb177974e9db5c9
2020-10-29 16:07:22 -07:00
Alex Hornby
89ace3790f mononoke: extend MononokeApp so admin apps can have a special default put behaviour
Summary:
Extend MononokeApp so admin apps can have a special default put behaviour (typically
 overwrite) vs the soon to be new default of IfAbsent

Use it from the admin tools.

Reviewed By: farnz

Differential Revision: D24623094

fbshipit-source-id: 5709c68429f8e1de0535eec132998d20411fc0e6
2020-10-29 16:07:22 -07:00
svcscm
97269ed0b5 Updating submodules
Summary:
GitHub commits:

f3c188bfd3
2109302cb4
f6eac3215c
787c88e484
88f69f2e97
51245fa528
d2a56d33e0

Reviewed By: jurajh-fb

fbshipit-source-id: e1c8f980458809f7884ce699e7e18f1a946c1b43
2020-10-29 15:58:11 -07:00
Simon Farnsworth
900b2a6982 mercurial: use repository.scm_name instead of arcanist_project_name
Summary:
mitrandir77 pointed me to this field which is exactly what I want.

Leave alias handling in place for configerator, which has a different name.

Reviewed By: mitrandir77

Differential Revision: D24628323

fbshipit-source-id: ccd01e6314feefd8ab75e8052a0a8a98b3119691
2020-10-29 14:40:38 -07:00
svcscm
505ff1977a Updating submodules
Summary:
GitHub commits:

97ec1db2fd
d9ba66ad3b
5f03d8b038
7eb2824e3f
a92fdc71e3
205dacb931
d540e0b41c

Reviewed By: jurajh-fb

fbshipit-source-id: 6c51f9adc610619e7aa411153e3b7101f3b73407
2020-10-29 14:40:38 -07:00
svcscm
114a927b14 Updating submodules
Summary:
GitHub commits:

43a46f0d77

Reviewed By: jurajh-fb

fbshipit-source-id: a387dc8456b38702009deab206f85c0f563c40fb
2020-10-29 13:42:36 -07:00
Katie Mancini
b13c5255eb Allow specifying and picking commits in prefetch_profile fetch CLI
Summary:
We want to be able to prefetch profiles on pull. That means we will need
to pick commits that will be good to prefetch for. This adds a flag --commits
that allows specifiying commits explicitly (mostly for testing), and a
flag `--predict-commits` which will pick good commits to prefetch for.

Reviewed By: genevievehelsel

Differential Revision: D23889882

fbshipit-source-id: 74e61c0c9d443ca396f326b0d547b9fc21a6364b
2020-10-29 13:34:06 -07:00
Katie Mancini
f616872079 Allow specifying commits to match against and prefetch in globFiles
Summary:
We want to be able to fetch prefetch profiles on pull. That means we will need
to prefetch the contents of prefetch profiles for commits that we are not
currently on. Thus globFiles (the thrift endpoint used for prefetch profiles
fetching) needs to be able to take commit hashes to match and fetch against.

Why fetch prefetch profiles on pull? This would get the prefetch started earlier so
the files are hopefully fetched by the time the user needs them.

Reviewed By: chadaustin, genevievehelsel

Differential Revision: D23858659

fbshipit-source-id: 123e423d5117274b92405dbb5c2df690298a1c18
2020-10-29 13:34:06 -07:00
Katie Mancini
e23fd00541 prefetch during prefetch profile activation
Summary:
Often a prefetch profile will be activated by a tool that uses that profile, so
we will by default prefetch a profile when activating it.

Reviewed By: genevievehelsel

Differential Revision: D23772446

fbshipit-source-id: 0b2e14cfa6ce079e8f04790ac2e0d196db5966ee
2020-10-29 13:34:05 -07:00
Katie Mancini
198b0e7451 Allow backgrounding profile prefetches
Summary:
Blocking checkout and pull to prefetch files could make these commands very
slow when large prefetches are triggered. To keep slow prefetches from causing
poor experiences we can background them by default.

Reviewed By: genevievehelsel

Differential Revision: D23831663

fbshipit-source-id: 4fba5ab894b927a6aa3359b516cff604ad524485
2020-10-29 13:34:05 -07:00
svcscm
b7ff7bf6d9 Updating submodules
Summary:
GitHub commits:

a106fa4d16
93ee341082
9a6d0ba238
39d5addbff

Reviewed By: jurajh-fb

fbshipit-source-id: d23e7da4863f1b19f8fa221c0869f7caddea6022
2020-10-29 13:34:05 -07:00
svcscm
a5e6948258 Updating submodules
Summary:
GitHub commits:

76df47f7dd
ae7f09e39d
f9374ae1c5
faf892f329
5320e522dd
4db28737d2
05f7030493

Reviewed By: jurajh-fb

fbshipit-source-id: e3e892f65db7863bad0407dfd55f8ee8e28c3538
2020-10-29 12:10:27 -07:00
Jan Mazur
8152776a35 bypassing hooks for members of scm
Summary: Members of `scm` hipster group will be able to push to mononoke bypassing hooks when `BYPASS_ALL_HOOKS` pushvar is passed.

Reviewed By: krallin

Differential Revision: D24477468

fbshipit-source-id: ac910bf27e5510e1975c4a7cd0bfeff5216da70e
2020-10-29 10:14:25 -07:00
Kostia Balytskyi
3ff917ad64 remove get_current_reverse_mover_DEPRECATED
Reviewed By: farnz

Differential Revision: D24563248

fbshipit-source-id: cabcf29e2874e9a46b82bc118a1f08633ae46443
2020-10-29 07:48:37 -07:00
Katherine Zak
dcbf01f81c rm reading "cert" key from .arcrc
Summary: This diff removes reading the token from the "cert" property in the `~/.arcrc` and forces the caller to use either an OAuth token or CATs.

Reviewed By: quark-zju

Differential Revision: D24242614

fbshipit-source-id: 18538270102b7aa28731e82c8dd21f5da9e2f2d6
2020-10-29 06:13:26 -07:00
Alex Hornby
c359dfc022 mononoke: update walker to use MappedHgChangesetId derived data
Summary: Update walker to use MappedHgChangesetId derived data now that hg data is modeled like other derived data. This simplifies bonsai_to_hg_mapping_step

Reviewed By: aslpavel

Differential Revision: D24531553

fbshipit-source-id: 62663d8d47ec7145980c4cd567cba3009b1999cb
2020-10-29 04:29:44 -07:00
Mateusz Kwapich
cd27efe09c make @nocommit hook stricter
Reviewed By: admdikramr

Differential Revision: D24590666

fbshipit-source-id: 7a56760cfb3381d5fe84b67a9708e0dda377c31d
2020-10-29 03:43:48 -07:00
svcscm
c27a1c0fa3 Updating submodules
Summary:
GitHub commits:

b89e21b71d
f63a5c3168
abd75f9984

Reviewed By: jurajh-fb

fbshipit-source-id: ef7ef974079ed3f55351dffd2182bad768455975
2020-10-29 03:43:48 -07:00
svcscm
e67109978c Updating submodules
Summary:
GitHub commits:

0cbc318546
99a0305bb8
ab2e250dc0
423a8d8169
1b286ec679

Reviewed By: jurajh-fb

fbshipit-source-id: 2c36cc8ad23b816612810110c4f623b2bb20f1ef
2020-10-28 21:36:19 -07:00
Durham Goode
2cf0157824 debug: add --wait to debuglock
Summary:
We have automation that wants to use this to hold the lock while doing
some maintenance. They want the ability to wait for the lock so they don't have
to busy loop.

Reviewed By: snarkmaster

Differential Revision: D24604466

fbshipit-source-id: be02539908655e183f334865718b68b633b069a5
2020-10-28 19:36:17 -07:00
svcscm
e5e6f53b83 Updating submodules
Summary:
GitHub commits:

cb3d9af0ae
2d79be6dde
795090fc01

Reviewed By: jurajh-fb

fbshipit-source-id: 47c52ddced67cfe4742b3c48c1db46bad776627f
2020-10-28 16:22:01 -07:00
Genevieve Helsel
8b42380d18 introduce eden logs command
Summary: Introduces an `eden logs` command to read a large chunk (1M by default) file into a paste. This is also added to the the eden rage report to get more insight into systems in which we cannot log in to view the logs (like laptops).

Reviewed By: kmancini

Differential Revision: D24146812

fbshipit-source-id: 991f1595b974eb01f77e86559a8413b0b09a24a4
2020-10-28 15:48:21 -07:00
svcscm
afb35484f4 Updating submodules
Summary:
GitHub commits:

cf16ffe796
25fe3ce3da
2404f8b9ec
ddb282f31e

Reviewed By: jurajh-fb

fbshipit-source-id: 8cb87c2784f5964796b49bf2d6e3b3aad21d1df4
2020-10-28 15:10:01 -07:00
Stefan Filip
2cce5b532b dag: update InProcessStore serialization
Summary: Removing redundant indexes from serialization.

Reviewed By: quark-zju

Differential Revision: D24580272

fbshipit-source-id: 49b1d6ae00e2f079dd0ed9d710afcd04b9744442
2020-10-28 14:55:59 -07:00
Stefan Filip
dc1edebf9e dag: benchmark for inprocess iddag serialization
Summary:
I am wondering whether we should customize the serialization format for the
InProcessStore. I want to have a basis for the comparison before I proceed.

Reviewed By: quark-zju

Differential Revision: D24580273

fbshipit-source-id: d3ddfdc029dbdd84f60acace06fddc80b4d005f4
2020-10-28 14:55:59 -07:00
Stanislau Hlebik
d40f15876d mononoke: upload missing lfs objects
Reviewed By: krallin

Differential Revision: D24595980

fbshipit-source-id: 397930e00a75b0343ed13839783501fe3d535ccd
2020-10-28 14:09:59 -07:00
svcscm
0cfb846cb0 Updating submodules
Summary:
GitHub commits:

27b5c70967
bcd593ae87
a85208709b

Reviewed By: jurajh-fb

fbshipit-source-id: 855779a7dcfdd331c952f0ca570b6c0dadbac191
2020-10-28 12:52:37 -07:00
Simon Farnsworth
79847775e6 Delete prototype walker
Summary: This is very old code that once acted to prototype walker-type functionality. As it's dead, delete it.

Reviewed By: ikostia, krallin

Differential Revision: D24591123

fbshipit-source-id: 663108e123d354243c2be4f00819f39d6951db93
2020-10-28 12:43:58 -07:00
svcscm
8c46e6a2b5 Updating submodules
Summary:
GitHub commits:

b027160b06
2d0d7cb61d
9ab10e00fb
248d10fb96

Reviewed By: jurajh-fb

fbshipit-source-id: 015fa7b02c566f6d1adee83080c02da01834c982
2020-10-28 12:43:58 -07:00
svcscm
5a8d19ac04 Updating submodules
Summary:
GitHub commits:

dbfa3fd434
a3f856afd4
793e9b7f5b
e6da297627
f3ddff5217
c04aa461a9
d05e599ee2

Reviewed By: jurajh-fb

fbshipit-source-id: 98a2bb3f18a6fd40187f8850e2f227ce79d70562
2020-10-28 11:14:03 -07:00
Mark Thomas
c293fd3322 scs_server: add blobstore rate-limiting for requests
Summary:
Some requests can result in a large number of blob fetches.  Add rate limiting
so that these requests don't use up all available capacity.

Rate limits can be specified in tunables.

Reviewed By: ahornby

Differential Revision: D24592814

fbshipit-source-id: 9a73a92094d0ce01be5491b65b4808e3ebb05c11
2020-10-28 11:01:39 -07:00
Alex Hornby
4f2ce0cad8 mononoke: add ChangesetInfo derived data to the walker
Summary: Add ChangesetInfo derived data to the walker so that it can be scrubbed and validated

Reviewed By: farnz

Differential Revision: D24312123

fbshipit-source-id: 84b3bba87e5391339f97cd2e5ae0313761726d02
2020-10-28 10:53:15 -07:00
Alex Hornby
177e81d27f mononoke: improve walker command line parsing for node types
Summary: Add the ability to specify a group of node types in one go on the command line

Reviewed By: farnz

Differential Revision: D24526827

fbshipit-source-id: 59d2f0cd06dbbe2555625023be3725a528256005
2020-10-28 10:53:15 -07:00
Alex Hornby
e245a88486 mononoke: only walk derived data types that are configured for a repo
Summary:
Prevent the walker from trying to walk derived data node types that are not configured for a repo.

This is done by add a mapping from walker NodeType to derived data ::NAME, connect it up for existing derived data usages and using it for validation in setup.rs

Reviewed By: farnz

Differential Revision: D24391591

fbshipit-source-id: 21ae63f4f210d2e1310b0ee2c509fb492f742db7
2020-10-28 10:53:15 -07:00
Simon Farnsworth
d0110ce4a8 Support marking garbage in SQLBlob
Summary:
We want to be able to detect garbage blobs by looking at generation numbers.

Update generation numbers on put, and have a mark command exist to mark blobs as not garbage.

Reviewed By: ahornby

Differential Revision: D23989289

fbshipit-source-id: d96f38649151e3dbd5297cffc262776e74f6cc86
2020-10-28 10:23:55 -07:00
Stanislau Hlebik
a4eee3facd mononoke: check only common name in hgcli
Reviewed By: krallin

Differential Revision: D24545598

fbshipit-source-id: 7ede4f5b7119baf01e5fd4d651f9b0bd9722ab3e
2020-10-28 09:39:54 -07:00
Stanislau Hlebik
f93274ff8a mononoke: move loggers in StdioRelay
Summary:
I'm planning to use them from inside establish_connection function. So this
diff makes a refactoring to make scuba logger and slog logger available in
StdioRelay

Reviewed By: krallin

Differential Revision: D24590426

fbshipit-source-id: 5c20025295700aa91c685c47242618a20f89eb76
2020-10-28 09:39:54 -07:00
svcscm
5de8bf6d2a Updating submodules
Summary:
GitHub commits:

0c20854fea
918d532644

Reviewed By: jurajh-fb

fbshipit-source-id: ef6c560855965820dfec25d2f7e65b332e8843ed
2020-10-28 09:36:59 -07:00
Durham Goode
e6af9b25b1 py3: fix globalrevs
Summary: The tests now pass with python 3.

Reviewed By: singhsrb

Differential Revision: D24583278

fbshipit-source-id: 7e0a0805751b1d3f1c77dfcd20df5b460994820a
2020-10-28 08:56:55 -07:00
Simon Farnsworth
71d6f02597 mercurial: phrevset should understand about repo aliases
Summary: We had some aliases for fbsource, and `fbcode` is still in use. Teach phrevset to recognise all aliases via config for ease of patching.

Reviewed By: markbt

Differential Revision: D24589906

fbshipit-source-id: bd61e86135d63ae07fa62d741e16cea4882f691b
2020-10-28 05:26:29 -07:00
generatedunixname89002005325677
913d0138ac Daily arc lint --take RUSTFMT
Reviewed By: krallin

Differential Revision: D24588052

fbshipit-source-id: 30ba91b100f9065f7dfb63f3ecdc3b550d0a84a7
2020-10-28 05:17:34 -07:00
svcscm
33c36ba92e Updating submodules
Summary:
GitHub commits:

5b0425c0b0
68df1604f0
90e392ec9e

Reviewed By: jurajh-fb

fbshipit-source-id: 08969e3a7b8752b714c15c44f503546e1755a102
2020-10-28 05:17:34 -07:00
svcscm
b659a30384 Updating submodules
Summary:
GitHub commits:

063ef0c0d1
c937935425
994cb83345
7e4ee5be13

Reviewed By: jurajh-fb

fbshipit-source-id: c9022c341ab91cd40125e1b65106e214a065dfb7
2020-10-27 22:14:55 -07:00
Xavier Deguillard
9c2bb705a1 inodes: fix use after free in LookupProcessor
Summary:
The LookupProcessor class is built with the purpose of iterating all the inodes
in the passed in path. However, the LookupProcessor object may outlive the
lifetime of the path, and thus we need to build an iterator on the copied path,
not on the argument.

Differential Revision: D24581874

fbshipit-source-id: b66dc007920b7adad5272bf56d3034acb211fec6
2020-10-27 21:45:43 -07:00
svcscm
9d6019a78e Updating submodules
Summary:
GitHub commits:

bc0555585a
17da692283

Reviewed By: jurajh-fb

fbshipit-source-id: 2fc95685424cb6e94b09b725711a87d6f0bb7634
2020-10-27 21:45:43 -07:00
svcscm
5301005428 Updating submodules
Summary:
GitHub commits:

6a6093d4f0
3cf980b2ca

Reviewed By: jurajh-fb

fbshipit-source-id: 875c3588614386f908dcf22d9b715d2758dfc01e
2020-10-27 18:42:03 -07:00
Kostia Balytskyi
e606572eb3 cross_repo_sync: get rid of CommitSyncerArgs
Summary:
`CommitSyncerArgs` was useful when `CommitSyncer` did not have a way to query
existing configs from the configerator. Now that `SyncDataProvider` is part of
`CommitSyncer`, we can get rid of `CommitSyncerArgs`, which will also make
further improvements more convenient.

Reviewed By: StanislavGlebik

Differential Revision: D24565773

fbshipit-source-id: 4dd507b06d946c6018a4a4e8d5e77c6b27abe195
2020-10-27 17:00:08 -07:00
Stanislau Hlebik
0163f9dcf1 mononoke: admin rsync - add a command to delete files that exist in dest dir
Summary:
After we synced all the files from source directory into destination directory
the destination directory might have some files that source directory doesn't.

So let's add a command to remove them.

Reviewed By: ikostia

Differential Revision: D24541984

fbshipit-source-id: 7e0e21e4c8079d24e1e24adccd3a20a8bbc737ca
2020-10-27 15:12:00 -07:00
Stanislau Hlebik
e4e4b33bb8 mononoke: add --overwrite option to rsync
Summary:
Previously `mononoke_admin rsync` didn't overwrite files i.e. if a target
directory has a file with the same name as in source directory then it won't be overwritten.

This diff adds an option to make it possible to overwrite a file if a target
directory has a file with the same name but its content is different. However
note that if a file has to be overwritten then target file is going to be removed in one
commit and then copied in the second (i.e. we'll create two commits instead of
one). The reason for doing that is to preserve the history of the original file
(i.e. history from `from-directory`).

Reviewed By: aslpavel

Differential Revision: D24538199

fbshipit-source-id: 792162c4e5ad81fb6949dd95eb1322696ec011ea
2020-10-27 15:12:00 -07:00
svcscm
55e3805a00 Updating submodules
Summary:
GitHub commits:

4c46640fbf
0e2e67562f

Reviewed By: jurajh-fb

fbshipit-source-id: c3af6bcfe42c233c3264c1cefa8a0a762e0ff13b
2020-10-27 13:17:21 -07:00