Summary:
This is a series of patches which adds Cargo.toml files to all the crates and tries to build them. There is individual patch for each crate which tells whether that crate build successfully right now using cargo or not, and if not, reason behind that.
Following are the reasons why the crates don't build:
* failure_ext and netstring crates which are internal
* error related to tokio_io, there might be an patched version of tokio_io internally
* actix-web depends on httparse which uses nightly features
All the build is done using rustc version `rustc 1.27.0-dev`.
Pull Request resolved: https://github.com/facebookexperimental/mononoke/pull/7
Differential Revision: D8778746
Pulled By: jsgf
fbshipit-source-id: 927a7a20b1d5c9643869b26c0eab09e90048443e
Summary:
Implementations of various storage backends in Mononoke may need to access the raw value inside of a Version struct. Originally, the intention was to make Version a trait, with concrete implementations inside of each storage backend crate that could access private fields by virtue of being in the same crate. Now that we're using a single concrete Version implementation across all of Mononoke, this field needs to be made public to allow the storage backends to have the appropriate access.
I considered several alternatives here: for example, we could instead provide as `as_inner()` method to extract the value, or we could even make this method part of a separate trait that one needs to specifically import to get access to the Version's innards. But given that all of these approaches still amount to allowing public access to this field, I decided to start out with the simplest approach, and ask: //should we instead make this a method?//
Reviewed By: jsgf
Differential Revision: D6215854
fbshipit-source-id: b29e7f9c96b077a5805b7195f28ddb5d871dca35
Summary:
This Version type is going to form the basis for other key-value
stores like linknodes, so it needs to be moved into a separate crate.
I've chosen `storage_types` as the name because it seems to be the most obvious
candidate.
Reviewed By: jsgf
Differential Revision: D6015772
fbshipit-source-id: 52de7866d68fdec2a4908626679a6f08c5f73402
