Commit Graph

6 Commits

Author SHA1 Message Date
John Elliott
f149770cf1 Move EnumValue from eden to edencommon
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.

This change moves EnumValue from eden to edencommon.

Reviewed By: genevievehelsel

Differential Revision: D54471130

fbshipit-source-id: 9f0828f4864f43fa4b400d0738333d07c09b93c4
2024-03-04 12:22:09 -08:00
John Elliott
36ae764747 Move utils:utils from eden to edencommon (part 1)
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.

This change moves utils:utils from eden to edencommon.

NOTE: This is a large diff, so breaking the tests into separate subsequent diff.

Reviewed By: genevievehelsel

Differential Revision: D54442939

fbshipit-source-id: 1cfbfa10d2dc4bbf7379d700978198b8b6788c71
2024-03-04 12:22:09 -08:00
John Elliott
108b57fc36 Move FileUtils and PathFuncs from eden to edencommon
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.

This change moves FileUtils and PathFuncs from eden to edencommon.

NOTE: FileUtils and PathFuncs are mutally dependent so they were migrated togehter. Most of the files touched, however, was due to PathFuncs.

Reviewed By: genevievehelsel

Differential Revision: D54393041

fbshipit-source-id: 6dc404b1b1066704584da512220475e9ee486247
2024-03-01 18:09:03 -08:00
John Elliott
dcb1388959 Move CaseSenstivity from eden to edencommon
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.

This change moves CaseSensitvity from eden to edencommon.

Reviewed By: fanzeyi

Differential Revision: D54339283

fbshipit-source-id: f96a421f4390578e5d2281b307532c62e22935d3
2024-02-29 16:32:49 -08:00
John Elliott
438a3f43ba Enable warnings for shadow definitions for clang/gcc
Summary:
Eden builds allow for shadow declarations to hide members, parameters, etc.

This can lead to subtle bugs and frustrations. Lets fix that. This first update enables shadow warngings for most problematic types of shadows. With errors on by default, this will block local and CI builds.

Reviewed By: xavierd

Differential Revision: D50434604

fbshipit-source-id: 976bd2e86c620f1f0e62e19867c81840fee645c9
2023-10-27 16:29:22 -07:00
Xinyi Wang
0e86e4ccf0 create GlobTree class that doesn't depend on inode
Summary:
See why on previous diff

Now with this diff GlobTree is independent of inode

Reviewed By: kmancini

Differential Revision: D49933175

fbshipit-source-id: 1551a2b7e054df5df88ac37fbf0bf45f91e34548
2023-10-10 10:06:24 -07:00