Summary:
Original commit changeset: 9d12716a4f3d
Original Phabricator Diff: D44835399.
File thrift/annotation/cpp.thrift is not available in open source and hence OSS build fails. Will work with thrift team to fix this properly.
Reviewed By: zechengh09
Differential Revision: D45297819
fbshipit-source-id: 0bdf2f3893f9069f34707ea897c2fa8c458a704f
Summary: Planning on using thrift::IPPrefix as the thrift rep of folly::CIDRNetwork, similar to how we use BinaryAddress for folly::IPAddress. Adding conversions accordingly
Reviewed By: zechengh09
Differential Revision: D37901477
fbshipit-source-id: 78997131b5fb966d0b5b603202d50d61d09bd099
Summary:
We are already enrolled in clang-autoformat, but not in
thrift auto format. Enable that now, so we can let linters worry about
formatting our code.
Reviewed By: phshaikh
Differential Revision: D30905313
fbshipit-source-id: bb4724cc11c455b23305e120ddcf22a3df0125b8
Summary: Add test cases to verify LACP behavior with local and remote link down events. For triggering remote link events, a thrift client is used.
Differential Revision: D26329897
fbshipit-source-id: fa1bdfe6df80cab77731ec6e6f21aa826aca3e7f
Summary: Update copyright messages to match the patterns expected by our open source linters.
Reviewed By: chadaustin
Differential Revision: D15105843
fbshipit-source-id: 6c66b4e3a552f9d71e6b43f9a5e6fcda48fd00d9
Summary:
Setting default value to empty causes trouble on server if client is old as
server will think that value is set to empty and it tries to parse empty value.
This field is not being used anywhere except in `openr` for now and openr is
fully compatible with this change. Not setting default value will give us as
`__isset.ifName` to `false` instead of being empty string, which is desired
behaviour.
(Note: this ignores all push blocking failures!)
Reviewed By: anantdeepak
Differential Revision: D4934119
fbshipit-source-id: 4dd2e9307c659f1b6ccaf583964efa8df6041d24
Summary:
We are using `BinaryAddress` heavily within fboss codebase to represent a
nexthop as well as an IPAddres in wire format. Nexthops will need to have
a scoping identifier (iface name) for link-local address inorder to resolve
it properly.
We do this in OpenR and well tested on Arista. This seems bit hacky but it
saves a lot of time. In future we would like to have separate network util for
fboss and openr and we can get rid of this hack at that time.
Differential Revision: D4710768
fbshipit-source-id: 72092935f3738b3fb88a422462d1c995cc0acf18
Summary:
This adds a common/ directory with stub files required for building
eden. These stubs are the same ones as used in the fboss repository:
https://github.com/facebook/fboss/
Our goal is to eventually create an opensource fb303 repository with
complete implementations of these files, but for now these basic stubs
allow building eden. (Most of the underlying stats code that supports
fb303 is already available in folly/stats/ in the folly repository.)
Test Plan:
Tested building eden on Ubuntu 16.04
