Commit Graph

3 Commits

Author SHA1 Message Date
Ryan McElroy
7096d79404 remotenames: do not over-check for svn/git push targets
Summary:
Previously, if the user had an svn or git push target set up, we would
bail from the normal push --to process even if the users were pushing to a
different location. This is silly. Instead, let's only bail if the user is
actually pushing to an svn or git destination repository.

This bug was discovered while testing the updated svn-to-hg sync scripts.

Differential Revision: D7023173

fbshipit-source-id: bec5e069bc043c2f73fb334bdaeb18a6fad93eef
2018-04-13 21:51:12 -07:00
Ryan McElroy
2298ee590a remotenames: do not crash if no bookmarks are passed to push discovery
Summary:
Today, there are cases where this function will be called but bookmarks
will not have been populated. We will eliminate one of these paths next,
but for safety, let's make sure we abort gracefully rather than with a
stacktrace by referencing something that does not exist.

Differential Revision: D7023172

fbshipit-source-id: 8e3b2afe9fe3b9d74d42aa5b947229418ec8c3ad
2018-04-13 21:51:12 -07:00
Stanislau Hlebik
11ed662a15 remotenames: move tests to the tests directory 2018-01-03 06:15:47 -08:00