3 Commits

Author	SHA1	Message	Date
Jun Wu	a6ad29eadf	phase: use commit hash internally ... Summary: This removes a false positive detection of "revision number" usage. Reviewed By: singhsrb Differential Revision: D16955290 fbshipit-source-id: 5d8762c21b0ceb9b7576f220e0d177db3918abc1	2019-08-22 13:00:13 -07:00
Jun Wu	17f66b3e1f	smartlog: avoid false positive detection of revnum usage ... Summary: If `smartlog()` is the user input, the revnum detection is enabled for the whole scope of smartlog revset implemenation. The use of rev numbers triggers the warning. But the user didn't use any rev number. Change smartlog to disable the revnum detection for its internal calculation. Carefully choose the scope so `smartlog(1+2)` will still be warned. Reviewed By: singhsrb Differential Revision: D16954997 fbshipit-source-id: 1a3d32c1c2bcba08bfac908623b6416cf1cd63a8	2019-08-22 13:00:12 -07:00
Jun Wu	b6ab106a37	revset: detect revision numbers optimized in _list revset ... Summary: A revset optimization pass rewrites revsets like 1+2+3 to use the `_list` revset function that has a fast path to bypass the `stringset` function. Change `_list` to detect revision numbers too. Reviewed By: singhsrb Differential Revision: D16910791 fbshipit-source-id: 51036b7d6f16b5388bbaf996864946df91a9f093	2019-08-20 17:21:10 -07:00