Commit Graph

19725 Commits

Author SHA1 Message Date
Alex Gaynor
88c328dbf9 style: never use a space before a colon or comma
Differential Revision: https://phab.mercurial-scm.org/D954
2017-09-29 15:48:34 +00:00
Jun Wu
bcceeef325 eol: make [eol] config section sensitive for chg confighash
The eol extension may mangle the [eol] config section and that means chg is
unable to detect config file change (because it re-applies setconfig
changes).

This makes test-eol.t pass with chg.

Differential Revision: https://phab.mercurial-scm.org/D917
2017-10-02 19:25:11 -07:00
Augie Fackler
ffcbb8d170 ui: convert to/from Optional[bytes] to Optional[str] in password manager
This password manager proxy is roughly the right-looking layer to
convert between strings and bytes. Many of these arguments can be
None, so we have a helper method to make the conversion preserve Nones
without exploding.

Differential Revision: https://phab.mercurial-scm.org/D886
2017-10-01 12:10:48 -04:00
Boris Feld
568bdc4e58 configitems: register the 'debug.dirstate.delaywrite' config 2017-06-30 03:37:05 +02:00
Boris Feld
4ec25dd5f8 configitems: register the 'merge.preferancestor' config 2017-06-30 03:43:13 +02:00
Boris Feld
a27db1fe3f configitems: register the 'email.from' config 2017-06-30 03:39:10 +02:00
Boris Feld
76fddb75bd configitems: register the 'smtp.port' config 2017-06-30 03:44:24 +02:00
Boris Feld
1e6c1ea742 configitems: register the 'phases.new-commit' config 2017-06-30 03:43:48 +02:00
Augie Fackler
271f9f69f9 urllibcompat: move some adapters from pycompat to urllibcompat
These are all the httpserver and urllib.* aliases. They seem to make
more sense in the slightly-more-specific urllibcompat package than the
general-purpose pycompat.

Differential Revision: https://phab.mercurial-scm.org/D935
2017-10-04 11:58:00 -04:00
Augie Fackler
321287c10b cleanup: use urllibcompat for renamed methods on urllib request objects
Differential Revision: https://phab.mercurial-scm.org/D891
2017-10-01 12:14:21 -04:00
Augie Fackler
4337c21943 urllibcompat: new library to help abstract out some python3 urllib2 stuff
Doing a new file instead of pycompat because I'm starting to feel like
pycompat is getting a little enormous in terms of scope.

Differential Revision: https://phab.mercurial-scm.org/D890
2017-10-01 10:45:03 -04:00
Yuya Nishihara
41fead32d1 extdata: use subprocess so we don't have to chdir() manually 2017-10-01 12:12:56 +01:00
Yuya Nishihara
ccfb5e786c extdata: just use iterator to read lines one by one 2017-10-01 11:58:27 +01:00
Yuya Nishihara
810071518d extdata: ignore ambiguous identifier as well 2017-10-01 11:56:41 +01:00
Yuya Nishihara
a5c1e61fda templater: add experimental support for extdata
This is minimal and non-controversial implementation of extdata() template
function. Originally extdata sources were exposed to the keyword namespace,
but I've changed it to a plain function for simplicity.
2017-10-01 11:13:09 +01:00
Yuya Nishihara
235c46722f revset: add experimental support for extdata
This is minimal and non-controversial implementation of extdata() revset.
Originally extdata sources were exposed to the symbol namespace, but I've
changed it to a plain function for simplicity.
2017-10-01 10:50:00 +01:00
Matt Mackall
21e38b9770 extdata: add extdatasource reader
This adds basic support for extdata, a way to add external data
sources for revsets and templates. An extdata data source is simply a
list of lines of the form:

<revision identifier>[<space><freeform text>]\n

An extdata source is configured thusly:

[extdata]
name = <a url or path>

urls of the form shell: are launch shell commands to generate data.

This patch is slightly modified by Yuya Nishihara as follows:

 - fix typo
 - remove unused function
 - remove future expansion point for parameter (which can be added later
   as the extdata revset/template are experimental)

You can see the original patch at
https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-September/088426.html
2016-09-13 14:14:05 -05:00
Jun Wu
e296c0748d config: add a missing preparewrite() call
Thanks Yuya for pointing this out in D808.

Differential Revision: https://phab.mercurial-scm.org/D924
2017-10-03 12:00:07 -07:00
Gregory Szorc
6329605d9f changelog: use a Factory for default value for files
The default value is compiled into the generated type. This means
that default values are shared between instances. For immutable types
like bool, str, int, and tuple, this is fine. But for mutable types
like list and dict, we need to use attr.Factory()  to instantiate a
new instance of the default for each object.

Differential Revision: https://phab.mercurial-scm.org/D901
2017-10-02 11:03:53 +01:00
Gregory Szorc
ce576c3b19 cext: wrap before brace for functions
This is our prevailing style.

Differential Revision: https://phab.mercurial-scm.org/D910
2017-10-02 19:28:41 +01:00
Gregory Szorc
5397128d04 cext: put case statements on separate line
This seems to be the prevailing style, even though it is a bit more
verbose for very simple switch statements.

Differential Revision: https://phab.mercurial-scm.org/D909
2017-10-02 19:09:52 +01:00
Gregory Szorc
a9a915a1bf cext: reorder #include
We mostly abide by this style.

In one case, a blank line was inserted to prevent a local
`#include "file"` from coming before a `#include <file>`.

Differential Revision: https://phab.mercurial-scm.org/D908
2017-10-02 19:06:00 +01:00
Gregory Szorc
1e024e0e3a cext: move braces for control statements to same line
This seems to be the prevailing style in the code by a wide margin.

Differential Revision: https://phab.mercurial-scm.org/D907
2017-10-02 19:02:43 +01:00
Saurabh Singh
786710798c registrar: fixing typo in comment
I was just going through the module and noticed the typo. This commit
fixes 'onfalure' -> 'onfailure'.

Differential Revision: https://phab.mercurial-scm.org/D906
2017-10-02 19:17:04 +01:00
Alex Gaynor
dd422bc1d6 style: never put multiple statements on one line
Differential Revision: https://phab.mercurial-scm.org/D905
2017-09-29 15:49:20 +00:00
Siddharth Agarwal
ba2d76cf38 annotate: mark lines affected by skip-annotate with *
This is to prevent weird surprises from happening with skips being attributed
to the wrong changeset.

.. feature::

   `hg annotate --skip` now prints a `*` on lines with skipped revisions

Differential Revision: https://phab.mercurial-scm.org/D900
2017-10-02 18:18:57 +01:00
Siddharth Agarwal
45633c900e annotate: track whether a particular annotation was the result of a skip
We're going to expose this information in the UI in an upcoming patch.

Differential Revision: https://phab.mercurial-scm.org/D899
2017-10-02 02:34:47 -07:00
Siddharth Agarwal
ca691a7bec annotate: introduce attr for storing per-line annotate data
We're going to extend this a bit -- at first by simply adding whether this was
a skipped child. We're well on our way to outgrowing tuples, though -- adding
more and more fields to tuples becomes annoying very quickly.

Differential Revision: https://phab.mercurial-scm.org/D898
2017-10-02 02:34:47 -07:00
Siddharth Agarwal
26ea4c9f32 context: rename local 'attr' to 'attr_'
In the next diff we're going to import mercurial.thirdparty.attr, and pyflakes
complains about this if this rename isn't done.

Differential Revision: https://phab.mercurial-scm.org/D897
2017-10-02 02:34:47 -07:00
Siddharth Agarwal
87602d16ba annotate: move annotatepair unit tests to a separate file
In upcoming patches the output is going to be significantly longer than it is
today, and doctests don't allow wrapping the output.

Differential Revision: https://phab.mercurial-scm.org/D896
2017-10-02 02:34:47 -07:00
Augie Fackler
5912fbc099 url: use native strings for header values
Differential Revision: https://phab.mercurial-scm.org/D889
2017-10-01 12:16:34 -04:00
Augie Fackler
3d427e2c85 keepalive: python 3 portability tweaks
Differential Revision: https://phab.mercurial-scm.org/D888
2017-10-01 12:15:53 -04:00
Augie Fackler
c388df1839 httppasswordmgrdbproxy: specify exact arguments
We only ever call these functions in a single way, so let's just
actually specify them. We need to do some string/bytes encoding
dancing here for Python 3, so it'll help to know what arguments we
need to convert.

# no-check-commit because I'm modifying functions that check-commit
does not like.

Differential Revision: https://phab.mercurial-scm.org/D885
2017-10-01 07:29:51 -04:00
Yuya Nishihara
b12606055b formatter: fix default list/dict generator to be evaluated more than once
Before, _hybrid.gen must be a generator which could be consumed only once.
It was okay in templatekw.py since template keywords are functions which
create temporary hybrid objects, but the formatter doesn't work in that way.

To work around the issue, this patch makes _hybrid.gen optionally be a
function returning a generator.

Thanks to Pulkit for finding this issue.
2017-10-01 08:37:04 +01:00
Boris Feld
42fd0705ec effectflag: document effect flag
Differential Revision: https://phab.mercurial-scm.org/D542
2017-08-24 18:40:30 +02:00
Boris Feld
0f13d1fb7b effectflag: detect when diff changed
Store in effect flag when the diff changed between the predecessor and
its successors.

Comparing the diff is not easy because we do not want to incorrectly detect a
2017-07-06 15:00:07 +02:00
Boris Feld
183e19c0fb effectflag: detect when meta changed
Store in effect flag when the meta changed between the predecessor and its
successors. We blacklisted some known meta that would always changed when
another flag change. For example rebase would always add a meta rebase-source
while the effect flag parents will already detect this situation.

It can happens with various hg commands.

Differential Revision: https://phab.mercurial-scm.org/D540
2017-07-06 14:58:44 +02:00
Boris Feld
cfcad75689 effectflag: detect when parents changed
Store in effect flag when the parents changed between the predecessor and
its successors.

It can happens with "hg rebase" or "hg grab".

Differential Revision: https://phab.mercurial-scm.org/D539
2017-07-06 14:56:16 +02:00
Boris Feld
fbe68ab2ed effectflag: detect when branch changed
Store in effect flag when the branch changed between the predecessor and
its successors.

It can happens with "hg branch" + "hg commit --amend", "hg branch" + "hg
amend" or "histedit".

Differential Revision: https://phab.mercurial-scm.org/D538
2017-07-06 14:55:12 +02:00
Boris Feld
bd49de9658 effectflag: detect when date changed
Store in effect flag when the date changed between the predecessor and
its successors.

It can happens with "hg commit --amend -d", "hg amend -d" or "histedit".

Differential Revision: https://phab.mercurial-scm.org/D537
2017-07-06 14:54:22 +02:00
Boris Feld
dbe4674ce5 effectflag: detect when user changed
Store in effect flag when the user changed between the predecessor and its
successors.

It can happens with "hg commit --amend -u" or "histedit".

Differential Revision: https://phab.mercurial-scm.org/D536
2017-07-06 14:53:48 +02:00
Boris Feld
802a17caef effectflag: detect when description changed
Store in effect flag when the description changed between the predecessor and
its successors.

It can happens with "hg commit --amend -e", "hg amend -e" or "histedit".

Differential Revision: https://phab.mercurial-scm.org/D535
2017-07-06 14:52:34 +02:00
Boris Feld
f17532cf73 effectflag: store an empty effect flag for the moment
The idea behind effect flag is to store additional information in obs-markers
about what changed between a changeset and its successor(s). It's a low-level
information that comes without guarantees.

This information can be computed a posteriori, but only if we have all
changesets locally. This is not the case with distributed workflows where you
work with several people or on several computers (eg: laptop + build server).

Storing the effect-flag as a bitfield has several advantages:

- It's compact, we are using one byte per obs-marker at most for the effect-
  flag.
- It's compoundable, the obsfate log approach needs to display evolve history
  that could spans several obs-markers. Computing the effect-flag between a
  changeset and its grand-grand-grand-successor is simple thanks to the
  bitfield.

The effect-flag design has also some limitations:

- Evolving a changeset and reverting these changes just after would lead to
  two obs-markers with the same effect-flag without information that the first
  and third changesets are the same.

The effect-flag current design is a trade-off between compactness and
usefulness.

Storing this information helps commands to display a more complete and
understandable evolve history. For example, obslog (an Evolve command) use it
to improve its output:

x  62206adfd571 (34302) obscache: skip updating outdated obscache...
|    rewritten(parent) by Matthieu Laneuville <matthieu.laneuville@octobus...
|    rewritten(content) by Boris Feld <boris.feld@octobus.net>

The effect flag is stored in obs-markers metadata while we iterate on the
information we want to store. We plan to extend the existing obsmarkers
bit-field when the effect flag design will be stabilized.

It's different from the CommitCustody concept, effect-flag are not signed and
can be forged. It's also different from the operation metadata as the command
name (for example: amend) could alter a changeset in different ways (changing
the content with hg amend, changing the description with hg amend -e, changing
the user with hg amend -U). Also it's compatible with every custom command
that writes obs-markers without needing to be updated.

The effect-flag is placed behind an experimental flag set to off by default.

Hook the saving of effect flag in create markers, but store only an empty one
for the moment, I will refine the values in effect flag in following patches.

For more information, see:

  https://www.mercurial-scm.org/wiki/ChangesetEvolutionDevel#Record_types_of_operation

Differential Revision: https://phab.mercurial-scm.org/D533
2017-07-06 14:50:17 +02:00
Boris Feld
533f8e99c5 configitems: register the 'profiling.type' config 2017-06-30 03:44:00 +02:00
Boris Feld
7fee69a49c configitems: register the 'profiling.showmin' config 2017-06-30 03:43:57 +02:00
Boris Feld
c2d0e63222 configitems: register the 'profiling.showmax' config 2017-06-30 03:43:56 +02:00
Boris Feld
ebdb3dfa7a configitems: register the 'profiling.output' config 2017-06-30 03:43:55 +02:00
Simon Whitaker
a83744bf9c dirstate: implement __len__ on dirstatemap (issue5695)
Differential Revision: https://phab.mercurial-scm.org/D884
2017-10-01 16:46:02 +01:00
Simon Whitaker
194133f6f9 obsmarker: crash more helpfully when metadata fields are >255bytes (issue5681)
Various mutators fail when attempting to write obsmarkers with
metadata fields longer than 255 bytes, since the length of
mwetadata fields is stored in u8s. This change raises a more
helpful error in such circumstances.

Differential Revision: https://phab.mercurial-scm.org/D865
2017-10-01 12:54:35 +01:00
Gregory Szorc
348ce9ed24 hgweb: use parsebool for parsing diff query string options
Differential Revision: https://phab.mercurial-scm.org/D875
2017-10-01 12:29:33 +01:00