Commit Graph

4 Commits

Author SHA1 Message Date
Jun Wu
5851c126a5 tests: fix helpers-usechg.sh
Summary:
I noticed some tests were running slower without chg. Upon investigation,
`alias hg=...` seems stop working. Similar to D7563731, let's define
functions explicitly instead.

Reviewed By: singhsrb

Differential Revision: D7964291

fbshipit-source-id: 08a69c865ffef6be7e84dd66a7cece9284b94e60
2018-05-11 16:20:55 -07:00
Jun Wu
7192afdd6b linter: disable ShellCheck for hg
Summary:
The ShellCheck linter:
- Conflict with hg check-code. ex. on "$()" vs "``".
- Over picky. ex. SC2148 should only run on scripts with `x` bit.

Therefore disable it for scm/hg.

Reviewed By: zertosh

Differential Revision: D6887739

fbshipit-source-id: 9447a4582ab5d2798a382d9dc715eb319d4255c0
2018-04-13 21:51:03 -07:00
Jun Wu
b8f87be31d helpers-usechg: respect CHG environment variable
Summary: This allows CHG to override the chg program being used in tests.

Reviewed By: DurhamG

Differential Revision: D6879866

fbshipit-source-id: c6955609e2b6938d7e26d9b42aa0f6221396a4ad
2018-04-13 21:51:02 -07:00
Jun Wu
effa0da8de test-helpers: add a helper to run test using chg
Summary:
The helper could be used in individual tests to enable chg if chg exists.
This allows us to have more precise control on what tests to use chg instead
of using a global flag in run-tests.py.

This makes certain tests containing many hg commands much faster. For example,
`test-revset.t` took 99 seconds before:

  % ./run-tests.py test-revset.t --time
  .
  # Ran 1 tests, 0 skipped, 0 failed.
  # Producing time report
  start   end     cuser   csys    real      Test
    0.000  99.990  86.410  12.000  99.990   test-revset.t

And 10 seconds after:

  % ./run-tests.py test-revset.t --time
  .
  # Ran 1 tests, 0 skipped, 0 failed.
  # Producing time report
  start   end     cuser   csys    real      Test
    0.000  10.080   0.380   0.130  10.080   test-revset.t

Also enable it for some other tests. Note the whitelist is not complete.  We
probably want to whitelist more tests in the future.

The feature could be opted out by deleting `contrib/chg/chg`.

Reviewed By: phillco

Differential Revision: D6767036

fbshipit-source-id: 8220cf408aa198d5d8e2ca5127ca60e2070d3444
2018-04-13 21:50:54 -07:00