Commit Graph

8 Commits

Author SHA1 Message Date
Mark Thomas
9cc2b1cc64 phabstatus: fix long line
Summary: Fix long line which breaks `test-check-code.t`.

Reviewed By: farnz

Differential Revision: D7532586

fbshipit-source-id: e5add9c9407b34bb3bd4cd701ba491e0e0ce1079
2018-04-13 21:51:48 -07:00
Liubov Dmitrieva
7e39e14368 fix phabstatus for commit cloud
Summary:
fix `hg ssl` for Commit Cloud

In Commit Cloud world, obstore can sometimes have more knowledge than the unfiltered repo.
For example, in case of many amends on one client, some stuff can not be backed up
and not fetched to another client.
But we don't need to have all obsoleted versions in both repos,
obstore helps us to provide enough information to a user of what has happened
but we need to be carefull with operator []

Reviewed By: DurhamG

Differential Revision: D7516465

fbshipit-source-id: 7e109741829b26c30f20a7528b21b5ebc9b31dde
2018-04-13 21:51:47 -07:00
Mateusz Moneta
4cfb665650 Update markers during hg pullbackup
Summary:
Before this change `hg pullbackup` did not set correct markers on commits.

This change make possible to see what changes already landed even when we are restoring repository from backup.
Before the change `fbclone` + `hg pullbackup` of repo with `C1` commit landed would result in:
```
o  o C2
|    |
o  o C1
|  /
|
o
```
after:
```
o  o C2
|    |
o  x C1
|  /
|
o
```

Reviewed By: StanislavGlebik

Differential Revision: D7032572

fbshipit-source-id: ffee3c7cc23c24a3df9a89c999c9dd2de226dbff
2018-04-13 21:51:23 -07:00
Ryan McElroy
694229631f phabstatus: TypeErrors are no longer thrown
Summary:
We've now fixed the bugs that caused TypeErrors to show up at the
caller level, so we can remove catching them.

Reviewed By: DurhamG

Differential Revision: D6826615

fbshipit-source-id: 00efba751445164b81ec361a6883ace9cb032505
2018-04-13 21:51:07 -07:00
Ryan McElroy
e194006ddb phabstatus: catch TypeErrors thrown from revision lookup code
Summary:
In T25434376, we see that this data can in some cases be None, and when
we index into None, we get a TypeError:

```
'NoneType' object has no attribute '__getitem__'
```

I re-arranged the except statements and added TypeError to the second one.
I'm not totally happy with this since it's a programming error not actually
well dealt with, but this is the quickest fix. Future commits will fix things
more thoroughly.

Reviewed By: DurhamG

Differential Revision: D6826446

fbshipit-source-id: a21abba25817b746cb77a1f652ed15a189fce8fe
2018-04-13 21:51:06 -07:00
Phil Cohen
45c4a072f9 hgext: use relative imports wherever possible
Summary:
Port of D6798134 to fbsource. It eliminates module-import failures as well as errors like this:

```
mercurial.error.ForeignImportError: hgext.extlib.treedirstate: /home/phillco/.local/lib/python2.7/site-packages/hgext/extlib/treedirstate.so lives outside /..../hg
```

....that block other tests, like test-help.t

(Note: this ignores all push blocking failures!)

Reviewed By: quark-zju

Differential Revision: D6799259

fbshipit-source-id: b77d1b565dbf52165e0847002be498648658e064
2018-04-13 21:50:56 -07:00
Phil Cohen
82285d3577 phabricator: move to extlib
Summary: Update import statements and code to match core linters.

Test Plan:
`run-tests.py -j8`

Source these versions of phabdiff.py, arcdiff.py, and phabstatus.py in my hgrc. Run hg st, diff, ssl and observe no crashes.

Reviewers: durham, rmcelroy, phillco, #mercurial

Reviewed By: rmcelroy

Subscribers: rmcelroy, quark, awestern

Differential Revision: https://phabricator.intern.facebook.com/D6680961

Signature: 6680961:1515578477:ea5f1591e390f6ca8a94f652daeb1db9de819fea
2018-01-10 08:39:19 -08:00
Kostia Balytskyi
e75b9fc1b1 fb-hgext: move most of hgext3rd and related tests to core
Summary:
This commit moves most of the stuff in hgext3rd and related tests to
hg-crew/hgext and hg-crew/test respectively.

The things that are not moved are the ones which require some more complex
imports.


Depends on D6675309

Test Plan: - tests are failing at this commit, fixes are in the following commits

Reviewers: #sourcecontrol

Differential Revision: https://phabricator.intern.facebook.com/D6675329
2018-01-09 03:03:59 -08:00