Commit Graph

61492 Commits

Author SHA1 Message Date
Durham Goode
2cf0157824 debug: add --wait to debuglock
Summary:
We have automation that wants to use this to hold the lock while doing
some maintenance. They want the ability to wait for the lock so they don't have
to busy loop.

Reviewed By: snarkmaster

Differential Revision: D24604466

fbshipit-source-id: be02539908655e183f334865718b68b633b069a5
2020-10-28 19:36:17 -07:00
svcscm
e5e6f53b83 Updating submodules
Summary:
GitHub commits:

cb3d9af0ae
2d79be6dde
795090fc01

Reviewed By: jurajh-fb

fbshipit-source-id: 47c52ddced67cfe4742b3c48c1db46bad776627f
2020-10-28 16:22:01 -07:00
Genevieve Helsel
8b42380d18 introduce eden logs command
Summary: Introduces an `eden logs` command to read a large chunk (1M by default) file into a paste. This is also added to the the eden rage report to get more insight into systems in which we cannot log in to view the logs (like laptops).

Reviewed By: kmancini

Differential Revision: D24146812

fbshipit-source-id: 991f1595b974eb01f77e86559a8413b0b09a24a4
2020-10-28 15:48:21 -07:00
svcscm
afb35484f4 Updating submodules
Summary:
GitHub commits:

cf16ffe796
25fe3ce3da
2404f8b9ec
ddb282f31e

Reviewed By: jurajh-fb

fbshipit-source-id: 8cb87c2784f5964796b49bf2d6e3b3aad21d1df4
2020-10-28 15:10:01 -07:00
Stefan Filip
2cce5b532b dag: update InProcessStore serialization
Summary: Removing redundant indexes from serialization.

Reviewed By: quark-zju

Differential Revision: D24580272

fbshipit-source-id: 49b1d6ae00e2f079dd0ed9d710afcd04b9744442
2020-10-28 14:55:59 -07:00
Stefan Filip
dc1edebf9e dag: benchmark for inprocess iddag serialization
Summary:
I am wondering whether we should customize the serialization format for the
InProcessStore. I want to have a basis for the comparison before I proceed.

Reviewed By: quark-zju

Differential Revision: D24580273

fbshipit-source-id: d3ddfdc029dbdd84f60acace06fddc80b4d005f4
2020-10-28 14:55:59 -07:00
Stanislau Hlebik
d40f15876d mononoke: upload missing lfs objects
Reviewed By: krallin

Differential Revision: D24595980

fbshipit-source-id: 397930e00a75b0343ed13839783501fe3d535ccd
2020-10-28 14:09:59 -07:00
svcscm
0cfb846cb0 Updating submodules
Summary:
GitHub commits:

27b5c70967
bcd593ae87
a85208709b

Reviewed By: jurajh-fb

fbshipit-source-id: 855779a7dcfdd331c952f0ca570b6c0dadbac191
2020-10-28 12:52:37 -07:00
Simon Farnsworth
79847775e6 Delete prototype walker
Summary: This is very old code that once acted to prototype walker-type functionality. As it's dead, delete it.

Reviewed By: ikostia, krallin

Differential Revision: D24591123

fbshipit-source-id: 663108e123d354243c2be4f00819f39d6951db93
2020-10-28 12:43:58 -07:00
svcscm
8c46e6a2b5 Updating submodules
Summary:
GitHub commits:

b027160b06
2d0d7cb61d
9ab10e00fb
248d10fb96

Reviewed By: jurajh-fb

fbshipit-source-id: 015fa7b02c566f6d1adee83080c02da01834c982
2020-10-28 12:43:58 -07:00
svcscm
5a8d19ac04 Updating submodules
Summary:
GitHub commits:

dbfa3fd434
a3f856afd4
793e9b7f5b
e6da297627
f3ddff5217
c04aa461a9
d05e599ee2

Reviewed By: jurajh-fb

fbshipit-source-id: 98a2bb3f18a6fd40187f8850e2f227ce79d70562
2020-10-28 11:14:03 -07:00
Mark Thomas
c293fd3322 scs_server: add blobstore rate-limiting for requests
Summary:
Some requests can result in a large number of blob fetches.  Add rate limiting
so that these requests don't use up all available capacity.

Rate limits can be specified in tunables.

Reviewed By: ahornby

Differential Revision: D24592814

fbshipit-source-id: 9a73a92094d0ce01be5491b65b4808e3ebb05c11
2020-10-28 11:01:39 -07:00
Alex Hornby
4f2ce0cad8 mononoke: add ChangesetInfo derived data to the walker
Summary: Add ChangesetInfo derived data to the walker so that it can be scrubbed and validated

Reviewed By: farnz

Differential Revision: D24312123

fbshipit-source-id: 84b3bba87e5391339f97cd2e5ae0313761726d02
2020-10-28 10:53:15 -07:00
Alex Hornby
177e81d27f mononoke: improve walker command line parsing for node types
Summary: Add the ability to specify a group of node types in one go on the command line

Reviewed By: farnz

Differential Revision: D24526827

fbshipit-source-id: 59d2f0cd06dbbe2555625023be3725a528256005
2020-10-28 10:53:15 -07:00
Alex Hornby
e245a88486 mononoke: only walk derived data types that are configured for a repo
Summary:
Prevent the walker from trying to walk derived data node types that are not configured for a repo.

This is done by add a mapping from walker NodeType to derived data ::NAME, connect it up for existing derived data usages and using it for validation in setup.rs

Reviewed By: farnz

Differential Revision: D24391591

fbshipit-source-id: 21ae63f4f210d2e1310b0ee2c509fb492f742db7
2020-10-28 10:53:15 -07:00
Simon Farnsworth
d0110ce4a8 Support marking garbage in SQLBlob
Summary:
We want to be able to detect garbage blobs by looking at generation numbers.

Update generation numbers on put, and have a mark command exist to mark blobs as not garbage.

Reviewed By: ahornby

Differential Revision: D23989289

fbshipit-source-id: d96f38649151e3dbd5297cffc262776e74f6cc86
2020-10-28 10:23:55 -07:00
Stanislau Hlebik
a4eee3facd mononoke: check only common name in hgcli
Reviewed By: krallin

Differential Revision: D24545598

fbshipit-source-id: 7ede4f5b7119baf01e5fd4d651f9b0bd9722ab3e
2020-10-28 09:39:54 -07:00
Stanislau Hlebik
f93274ff8a mononoke: move loggers in StdioRelay
Summary:
I'm planning to use them from inside establish_connection function. So this
diff makes a refactoring to make scuba logger and slog logger available in
StdioRelay

Reviewed By: krallin

Differential Revision: D24590426

fbshipit-source-id: 5c20025295700aa91c685c47242618a20f89eb76
2020-10-28 09:39:54 -07:00
svcscm
5de8bf6d2a Updating submodules
Summary:
GitHub commits:

0c20854fea
918d532644

Reviewed By: jurajh-fb

fbshipit-source-id: ef6c560855965820dfec25d2f7e65b332e8843ed
2020-10-28 09:36:59 -07:00
Durham Goode
e6af9b25b1 py3: fix globalrevs
Summary: The tests now pass with python 3.

Reviewed By: singhsrb

Differential Revision: D24583278

fbshipit-source-id: 7e0a0805751b1d3f1c77dfcd20df5b460994820a
2020-10-28 08:56:55 -07:00
Simon Farnsworth
71d6f02597 mercurial: phrevset should understand about repo aliases
Summary: We had some aliases for fbsource, and `fbcode` is still in use. Teach phrevset to recognise all aliases via config for ease of patching.

Reviewed By: markbt

Differential Revision: D24589906

fbshipit-source-id: bd61e86135d63ae07fa62d741e16cea4882f691b
2020-10-28 05:26:29 -07:00
generatedunixname89002005325677
913d0138ac Daily arc lint --take RUSTFMT
Reviewed By: krallin

Differential Revision: D24588052

fbshipit-source-id: 30ba91b100f9065f7dfb63f3ecdc3b550d0a84a7
2020-10-28 05:17:34 -07:00
svcscm
33c36ba92e Updating submodules
Summary:
GitHub commits:

5b0425c0b0
68df1604f0
90e392ec9e

Reviewed By: jurajh-fb

fbshipit-source-id: 08969e3a7b8752b714c15c44f503546e1755a102
2020-10-28 05:17:34 -07:00
svcscm
b659a30384 Updating submodules
Summary:
GitHub commits:

063ef0c0d1
c937935425
994cb83345
7e4ee5be13

Reviewed By: jurajh-fb

fbshipit-source-id: c9022c341ab91cd40125e1b65106e214a065dfb7
2020-10-27 22:14:55 -07:00
Xavier Deguillard
9c2bb705a1 inodes: fix use after free in LookupProcessor
Summary:
The LookupProcessor class is built with the purpose of iterating all the inodes
in the passed in path. However, the LookupProcessor object may outlive the
lifetime of the path, and thus we need to build an iterator on the copied path,
not on the argument.

Differential Revision: D24581874

fbshipit-source-id: b66dc007920b7adad5272bf56d3034acb211fec6
2020-10-27 21:45:43 -07:00
svcscm
9d6019a78e Updating submodules
Summary:
GitHub commits:

bc0555585a
17da692283

Reviewed By: jurajh-fb

fbshipit-source-id: 2fc95685424cb6e94b09b725711a87d6f0bb7634
2020-10-27 21:45:43 -07:00
svcscm
5301005428 Updating submodules
Summary:
GitHub commits:

6a6093d4f0
3cf980b2ca

Reviewed By: jurajh-fb

fbshipit-source-id: 875c3588614386f908dcf22d9b715d2758dfc01e
2020-10-27 18:42:03 -07:00
Kostia Balytskyi
e606572eb3 cross_repo_sync: get rid of CommitSyncerArgs
Summary:
`CommitSyncerArgs` was useful when `CommitSyncer` did not have a way to query
existing configs from the configerator. Now that `SyncDataProvider` is part of
`CommitSyncer`, we can get rid of `CommitSyncerArgs`, which will also make
further improvements more convenient.

Reviewed By: StanislavGlebik

Differential Revision: D24565773

fbshipit-source-id: 4dd507b06d946c6018a4a4e8d5e77c6b27abe195
2020-10-27 17:00:08 -07:00
Stanislau Hlebik
0163f9dcf1 mononoke: admin rsync - add a command to delete files that exist in dest dir
Summary:
After we synced all the files from source directory into destination directory
the destination directory might have some files that source directory doesn't.

So let's add a command to remove them.

Reviewed By: ikostia

Differential Revision: D24541984

fbshipit-source-id: 7e0e21e4c8079d24e1e24adccd3a20a8bbc737ca
2020-10-27 15:12:00 -07:00
Stanislau Hlebik
e4e4b33bb8 mononoke: add --overwrite option to rsync
Summary:
Previously `mononoke_admin rsync` didn't overwrite files i.e. if a target
directory has a file with the same name as in source directory then it won't be overwritten.

This diff adds an option to make it possible to overwrite a file if a target
directory has a file with the same name but its content is different. However
note that if a file has to be overwritten then target file is going to be removed in one
commit and then copied in the second (i.e. we'll create two commits instead of
one). The reason for doing that is to preserve the history of the original file
(i.e. history from `from-directory`).

Reviewed By: aslpavel

Differential Revision: D24538199

fbshipit-source-id: 792162c4e5ad81fb6949dd95eb1322696ec011ea
2020-10-27 15:12:00 -07:00
svcscm
55e3805a00 Updating submodules
Summary:
GitHub commits:

4c46640fbf
0e2e67562f

Reviewed By: jurajh-fb

fbshipit-source-id: c3af6bcfe42c233c3264c1cefa8a0a762e0ff13b
2020-10-27 13:17:21 -07:00
Kostia Balytskyi
e23991ca4a SyncedCommitMappingEntry: make constructor take ..Version instead of Option<..Version>
Summary: A better fix would be to also get rid of `Option` in the struct itself, but I don't want to spend any more time on this atm, and this change is a clear improvement.

Reviewed By: StanislavGlebik

Differential Revision: D24538309

fbshipit-source-id: 6190c6936dc34d996ecd3d700e5f71282d45f651
2020-10-27 11:45:02 -07:00
Kostia Balytskyi
26e9741d32 push-redirector: borrow more instead of cloning
Summary: Same as the previous diff, but for push-redirector.

Reviewed By: StanislavGlebik

Differential Revision: D24538027

fbshipit-source-id: 392aee1b9cf0e684486c274c2b54fc2fb719bb3a
2020-10-27 11:45:02 -07:00
svcscm
cab3d4f181 Updating submodules
Summary:
GitHub commits:

2b94e113a0
f35f7f2704

Reviewed By: jurajh-fb

fbshipit-source-id: 27faab1a930546ca0b8e37bf268765f85311a9bc
2020-10-27 11:21:31 -07:00
Genevieve Helsel
33e09c8dac add commit_multiple_path_info method
Reviewed By: krallin

Differential Revision: D24524267

fbshipit-source-id: a36bf7ca9c42285814e88aacd51aa6c3c129b3d7
2020-10-27 10:38:17 -07:00
svcscm
a3318b8293 Updating submodules
Summary:
GitHub commits:

f5ebbb4d29
c007e59002

Reviewed By: jurajh-fb

fbshipit-source-id: f7788d45d910c6109f8d3badbc0a172ccf82ce6e
2020-10-27 10:38:17 -07:00
svcscm
7b3cafdb4d Updating submodules
Summary:
GitHub commits:

e2dab2630e
c9b290f4c1

Reviewed By: jurajh-fb

fbshipit-source-id: 07f23131b38fd431e9034ad43d2f781e9c0acfb3
2020-10-27 09:42:18 -07:00
Stanislau Hlebik
e76fa7ff9d mononoke: remove unused clone
Reviewed By: krallin

Differential Revision: D24564862

fbshipit-source-id: a03a0c5ba677bb11dce11bf06f259f6bd43dd54f
2020-10-27 09:13:43 -07:00
Stanislau Hlebik
972ce32a65 mononoke: fix warnings
Reviewed By: krallin

Differential Revision: D24564863

fbshipit-source-id: 0c461aac40ae50d7315cdcda21e9d7b003a5e536
2020-10-27 09:13:42 -07:00
Alex Hornby
a2ded99cf2 mononoke: update Phases::add_reachable_as_public to futures03
Summary:
update Phases::add_reachable_as_public to futures03

With this change all the Phases methods are futures03

Reviewed By: krallin

Differential Revision: D24531552

fbshipit-source-id: e9201621b798739d4d7dd197f15188103e9d359a
2020-10-27 08:06:12 -07:00
Alex Hornby
3ba61d5db5 mononoke: small improvement to walker command line edge type parsing
Summary: Simplify the combinator usage a little.

Reviewed By: krallin

Differential Revision: D24530950

fbshipit-source-id: 153e8a746b5a4a88c5341331f56144684e5e48eb
2020-10-27 07:44:39 -07:00
svcscm
ab2c531fb5 Updating submodules
Summary:
GitHub commits:

0a01350f65
fe902910a4
471afadf2c
6954525e8c
28bee4bfef
f5498cfc50

Reviewed By: jurajh-fb

fbshipit-source-id: 49fc83b35f663c4e47f938e66a9b17ccde0941e8
2020-10-27 06:44:46 -07:00
Kostia Balytskyi
7f5fb3c574 cross_repo_sync: start borrowing more instead of cloning
Summary:
Fewer clones, better code.

Note that in some cases we would previously have a fn that takes `ctx` by
ownership and just passes it through to some other fn outside of the
`cross_repo_sync`. I triead to make all such functions borrow and clone instead
in order to push cloning to the leaf fns of `cross_repo_sync`.

Reviewed By: StanislavGlebik

Differential Revision: D24538028

fbshipit-source-id: 8a3e78d4076b34d8b1767cdee1db3fdbb7acb4f7
2020-10-27 04:19:51 -07:00
Simon Farnsworth
4e59e26775 Thread ConfigStore into blobstore creation
Summary: SQLBlob GC (next diff in stack) will need a ConfigStore in SQLBlob. Make one available to blobstore creation

Reviewed By: krallin

Differential Revision: D24460586

fbshipit-source-id: ea2d5149e0c548844f1fd2a0d241ed0647e137ae
2020-10-27 04:14:24 -07:00
Alex Hornby
7b278b8bed mononoke: update Phases::get_public to futures03
Summary: update Phases::get_public to futures03

Reviewed By: krallin

Differential Revision: D24531550

fbshipit-source-id: ff60e178a58be6cc2a156b4a3685035c6a372785
2020-10-27 03:50:41 -07:00
Alex Hornby
f1f5d4b117 mononoke: update phases imports so that BoxFuture is the futures03 version
Summary: update phases imports so that BoxFuture is the futures03 version

Reviewed By: krallin

Differential Revision: D24531551

fbshipit-source-id: 1debb007456292fed1113f8c46e019bef27255c2
2020-10-27 03:50:41 -07:00
Alex Hornby
82642a9af9 mononoke: use the new BonsaiDerived::fetch_derived when scrubbing fsnodes
Summary: Use the new BonsaiDerived::fetch_derived from the walker when scrubbing fsnode derived data.   This saves a round trip to derived data and simplifies bonsai_to_fsnode_mapping_step().

Reviewed By: krallin

Differential Revision: D24311164

fbshipit-source-id: b26c6bdef548ca15c0cdbffde675f1a11d8b510e
2020-10-27 02:37:41 -07:00
Alex Hornby
9cdc40f1be mononoke: fix flaky test-walker-count-objects.t
Summary: Fix flaky test-walker-count-objects.t with some missing globs.  Some walker stats vary with execution order.

Reviewed By: StanislavGlebik

Differential Revision: D24391592

fbshipit-source-id: 05a94c23849d4e6db026926ead1b39dbf1e6fe54
2020-10-27 02:37:41 -07:00
Alex Hornby
55547c6cd4 mononoke: add BonsaiDerived::derive03
Summary:
Add BonsaiDerived::derive03 for new callsites that are 0.3/async aware.

Plan is to migrate callsites and then rename BonsaiDerived::derive03 to derive.

Reviewed By: StanislavGlebik

Differential Revision: D24389763

fbshipit-source-id: 4a6f351b9e0c5a2e9a9c47429764f88c47caff08
2020-10-27 02:37:41 -07:00
Alex Hornby
dde412f273 mononoke: pass references to derive_impl::derive_impl
Summary: Preparation for exposing an async BonsaiDerived::derive variant

Reviewed By: StanislavGlebik

Differential Revision: D24389762

fbshipit-source-id: c24b23c3858a91e96b93348a7e42266bee5809a0
2020-10-27 02:37:41 -07:00