Commit Graph

2 Commits

Author SHA1 Message Date
Muir Manders
8e2d79da37 status: handle non-utf8 paths from watchman
Summary:
We don't intend to fully support non-utf8 file names, but it is important we don't error out.

We now use the new BytesNameField watchman query type so we can decode non-utf8 file paths in watchman responses. Then, we pipe the invalid paths along up to the status command where they are printed out as warnings to the user.

In the future we probably want to track invalid paths in the treestate and make "hg clean" support removing them as a special case (as suggested by quark-zju).

Reviewed By: quark-zju

Differential Revision: D43141278

fbshipit-source-id: ad04ebdf75594e33ebaded137e9c65c487f0b30b
2023-02-10 07:14:53 -08:00
Durham Goode
5d13cbb939 status: print warning on fresh watchman instance
Summary: Carry over logic from Python to print a warning to the user when we get a fresh watchman instance and we have to traverse over all files.

Reviewed By: liubov-dmitrieva

Differential Revision: D40229121

fbshipit-source-id: 95a21cd67c4bd2200932fc36da82f8e01ae36875
2022-10-18 18:50:11 -07:00