Summary: This fixes a test-check issue and makes the code safer.
Test Plan: run-tests.py
Reviewers: ikostia, #mercurial
Reviewed By: ikostia
Differential Revision: https://phabricator.intern.facebook.com/D6682545
Signature: 6682545:1515505853:0e9f81c33bbf4c2579ec16f14153fab5fea832fd
Summary: Seems like some unneeded stuff.
Test Plan: - run this test, see it passing
Reviewers: rmcelroy, #sourcecontrol
Reviewed By: rmcelroy
Differential Revision: https://phabricator.intern.facebook.com/D6682999
Signature: 6682999:1515505094:237d85fb2393393a5ac2936949772f4aec5f47c1
Summary: Missed fix of wrong imports.
Test Plan: - run this test, it passes now
Reviewers: rmcelroy, #sourcecontrol
Reviewed By: rmcelroy
Differential Revision: https://phabricator.intern.facebook.com/D6682995
Signature: 6682995:1515504928:f8a0f2bff4c6dc1ff311ecdc12db63a3cfb69b3f
Summary:
Temporary change. Meant to be fixed later.
Depends on D6675437
Test Plan: - all the tests pass!
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675475
Summary:
These scripts are not necessary anymore.
Depends on D6675381
Test Plan: - less complaints from styling tests
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675405
Summary:
Some new help contents are now generated with test-help.t
Depends on D6675351
Test Plan: - test-help.t is passing now
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675363
Summary:
Previously, we were loading extensions from the environment which
is not good for actually getting the right docs.
> It is just plain wrong. --ikostia
Test Plan: run-tets.py
Reviewers: ikostia, #mercurial
Reviewed By: ikostia
Differential Revision: https://phabricator.intern.facebook.com/D6682879
Signature: 6682879:1515500917:a0b79bdae32dfa300fcab83488012c77a5145e15
Summary:
These fixes are related to documentation-related check-style tests.
Depends on D6675344
Test Plan: - more tests pass
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675351
Summary:
This is a big bulk of generally almost-obvious fixes to the moved tests. Mostly
these fixes have to do with correct importing of the actual extensions.
Depends on D6675329
Test Plan:
- ./run-tests.py fails less after this commit
- see further commits for more test fixes
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675344
Summary:
This commit moves most of the stuff in hgext3rd and related tests to
hg-crew/hgext and hg-crew/test respectively.
The things that are not moved are the ones which require some more complex
imports.
Depends on D6675309
Test Plan: - tests are failing at this commit, fixes are in the following commits
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675329
Summary: Fixes an issue where the build would fail if the directory had not been made.
Test Plan: ./setup.py build works now
Reviewers: mbthomas, #mercurial
Differential Revision: https://phabricator.intern.facebook.com/D6681061
Summary:
Moves the remotefilelog extension into hgext/ and it's tests into
tests/.
I did not fix up all the check-module errors, since it's a ton of work for
very little impact at this point.
Test Plan: make local && ./run-tests.py
Reviewers: #mercurial
Differential Revision: https://phabricator.intern.facebook.com/D6680030
Summary:
Moves ctreemanifest into hgext/extlib/. It will be built in a later
step when we add cstore to the build.
Test Plan: make local && cd tests && ./run-tests.py
Reviewers: #mercurial
Differential Revision: https://phabricator.intern.facebook.com/D6678844
Summary:
This moves the cdatapack code to the new lib/ directory and adds it to the main
setup.py.
Test Plan: hg purge --all && make local && cd tests && ./run-tests.py -S -j 48
Reviewers: #mercurial
Differential Revision: https://phabricator.intern.facebook.com/D6677491
Summary:
`hg help` shows a list of all disabled extensions, which is gets by looking at
all submodules in the `hgext` modules. Exclude the new `extlib` submodule,
which is actually just a container for extension libraries.
Test Plan: Re-run `test-help.t`.
Reviewers: durham, #mercurial
Reviewed By: durham
Differential Revision: https://phabricator.intern.facebook.com/D6679750
Tasks: T24908724
Signature: 6679750:1515458834:8813e9ea9aaf6a4d55d24bc8a48ddc628f6070fa
Summary:
Fix up test-check-module-imports, mostly by using absolute imports where
possible.
Also, some lfs errors have been removed, so remove their tests failures too.
Test Plan: Run test-check-module-imports test.
Reviewers: durham, #mercurial
Reviewed By: durham
Differential Revision: https://phabricator.intern.facebook.com/D6679241
Tasks: T24908724
Signature: 6679241:1515457419:2f8683206c8d43af99254c9f75f08af374673c2f
Summary:
I didn't notice the test failure because clang-format was not installed.
Might be a good idea to make it a hard error.
Test Plan: Run test-check-clang-format.t
Reviewers: phillco, #mercurial
Reviewed By: phillco
Subscribers: mathieubaudet
Differential Revision: https://phabricator.intern.facebook.com/D6679576
Signature: 6679576:1515457526:6b1935858da284b896244b0d99e2fef03ead97b8
Summary:
The `lib/linelog` directory contains pure C code that is unrelated from
either Mercurial or Python. The `mercurial/cyext` contains Cython extension
code (although for linelog's case, the Cython extension is unrelated from
Mercurial).
Cython is now a hard dependence to simplify the code.
Test Plan: `make local` and check `from mercurial.cyext import linelog` works.
Reviewers: durham, #mercurial
Reviewed By: durham
Subscribers: durham, fried
Differential Revision: https://phabricator.intern.facebook.com/D6678541
Signature: 6678541:1515455512:967266dc69c702dbff95fdea05671e11c32ebf28
Summary:
lz4revlog and hgsql have external dependencies and loading them may have the
side effect printing "*** failed to import extension *". Therefore ignore
them to stabilize the test.
Test Plan:
Run the test on a machine that do not have lz4 or mysql.connector installed and
make sure it passes.
Reviewers: durham, #mercurial
Reviewed By: durham
Differential Revision: https://phabricator.intern.facebook.com/D6678526
Signature: 6678526:1515454289:ad50291d22889aafcec007c15ff2974dfe05cb13
Summary:
check-seclevel will load disabled extensions including hgsql, which may fail
if its external dependency mysql.connector is not installed. That will break
test-help.t. The error is not fatal so let's just ignore it.
Test Plan:
Run test-help.t on a machine without mysql.connector installed and it now
passes.
Reviewers: durham, #mercurial
Reviewed By: durham
Differential Revision: https://phabricator.intern.facebook.com/D6678500
Signature: 6678500:1515454124:cdd59b644189da86f7d861e80ea3968d6c4b45b1
Summary: The test shouldn't run if the dependency (lz4) cannot be imported.
Test Plan:
Run the test on a machine that does not have Python lz4 module installed and
make sure the test gets skipped.
Reviewers: durham, #mercurial
Reviewed By: durham
Subscribers: durham
Differential Revision: https://phabricator.intern.facebook.com/D6678494
Signature: 6678494:1515454247:245401173d9e1ef16ab865c210b1f5412039c1e1
Summary:
hggit is not guaranteed available in the repo. So let's skip the test
temporarily.
Test Plan:
Run the test with clean PYTHONPATH and it does not complain about failed to
import hggit.
Reviewers: durham, #mercurial
Reviewed By: durham
Differential Revision: https://phabricator.intern.facebook.com/D6678488
Signature: 6678488:1515453639:bf9c4b53273c9b00d7c09c947af9849ebd272ad0
Summary: The test has an additional check if Python 3 was installed.
Test Plan: Run the test with Python 3 installed and it now passes.
Reviewers: durham, #mercurial
Reviewed By: durham
Subscribers: durham
Differential Revision: https://phabricator.intern.facebook.com/D6678482
Signature: 6678482:1515453420:bf233b1fe4c4c0f13c3cbf12af2e2967891f45a0
Summary:
Move the rust libraries and extensions to their new locations, and integrate
them with the hg-crew setup.py.
Test Plan: Run `python setup.py build` and verify rust extensions are built.
Reviewers: durham, #mercurial
Reviewed By: durham
Subscribers: fried, jsgf, mitrandir
Differential Revision: https://phabricator.intern.facebook.com/D6677251
Tasks: T24908724
Signature: 6677251:1515450235:920faf40babbce9b09e3283ff9ca328d1c5c51e6
Summary: Just discovered this typo while browsing through code.
Test Plan: Ran all the tests.
Reviewers: mitrandir, #sourcecontrol
Reviewed By: mitrandir
Differential Revision: https://phabricator.intern.facebook.com/D6677652
Signature: 6677652:1515448670:ff355bcce1beaf1614517b5fc6b39978565b33ac
Summary:
cdatapack depends on clib, so let's move it to lib/ outside of fb-hgext.
None of the consumers of these files were changed. They will be changed as they
are moved into the main part of the repo.
Test Plan: hg purge --all && make local && cd tests && ./run-tests.py -S -j 48
Reviewers: mitrandir, #mercurial
Reviewed By: mitrandir
Differential Revision: https://phabricator.intern.facebook.com/D6677197
Signature: 6677197:1515447873:399fb3e7beb5cc1ad8db18f42b359ffbfbeb21f2
Summary: Per discussion with quark@, we actually don't use this anymore as the extension was
upstreamed, and we now use the upstream version.
Test Plan: howdoi
Reviewers: mercurial
Subscribers:
Tasks:
Tags:
Summary:
cdatapack depends on sha1detectcoll, so let's add the library to setup.py before
we add cdatapack.
Test Plan:
hg purge --all && make local && cd tests/ && ./run-tests.py -S -j 48
Verified sha1dc was in the build output and the tests passed.
Reviewers: quark, #mercurial
Reviewed By: quark
Differential Revision: https://phabricator.intern.facebook.com/D6676405
Signature: 6676405:1515444508:2da65c6c3a18267a1d3c151c8e9acf60b674ffc2
Summary: A bunch of tests started failing due to file moves. Fix them.
Test Plan: run-tests.py
Reviewers: #mercurial
Differential Revision: https://phabricator.intern.facebook.com/D6676006
Tasks: T24908724
Summary:
The prebuilt directory was added by D5252935 to allow a third-party to build
our extensions without a working Cython. Since the third-party is unlikely
to use this version and our build infra does have a working Cython. Let's
remove prebuilt directory.
Test Plan: `make local` in fb-hgext and it works.
Reviewers: rmcelroy, #mercurial
Reviewed By: rmcelroy
Differential Revision: https://phabricator.intern.facebook.com/D6675678
Signature: 6675678:1515436932:a5bada0edbb06584cc5e4031cb628a1a946d6047
Summary:
For the purposes of easier identification of tests which came from fb-hgext,
let's rename them all, even the ones for remotefilelog and so on. Once everything
is in hg-crew properly, we can rename things to not be named like this.
Depends on D6675292
Test Plan: - just a rename
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675309
Summary: Our own sparse is now renamed to fbsparse.
Test Plan: - just a dropped file, no big deal.
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6675292
Summary: It was missed by whoever was adding hsql to this repo
Test Plan: tests are passing now
Reviewers: rmcelroy, ikostia, #mercurial
Reviewed By: rmcelroy
Differential Revision: https://phabricator.intern.facebook.com/D6674927
Signature: 6674927:1515432467:705219df9ef28e218923aafe720c8f908f16be67
Summary: Update check-code test output to reflect new locations of hgsql.
Test Plan: Run tests.
Reviewers: rmcelroy, #sourcecontrol
Reviewed By: rmcelroy
Differential Revision: https://phabricator.intern.facebook.com/D6661008
Tasks: T24908724
Signature: 6661008:1515089234:3c082103ebe6ec083b02281777c1f1d159528c27
Summary:
hgsql can't be loaded if you don't have mysql.connector installed on the build
machine. That shouldn't stop documentation from being generated.
Test Plan:
Make hgsql fail to load on my devserver (add a syntax error) and then build the
documentation. Make sure it builds anyway.
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6660865
Tasks: T24908724
Summary:
Move hgsql into the hgext directory, and the tests to tests/test-hgsql-*.
Update the tests to refer to the new places for things.
Test Plan: Run the hgsql tests and make sure they pass.
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.intern.facebook.com/D6660499
Tasks: T24908724
