Summary:
Upstream Mercurial has enabled python deprecation warning in the tests, so
python 2.6 runs now complain about our use of context.nested(). The current fix
of marking all those functions with suppression decorators breaks the tests in
some environments since the suppression module can't be found unless it's
installed or the environment has been set up correctly.
Let's just get rid of our use of nested() and the nodeprecate module.
Test Plan: Ran the tests on centos7 with python 2.7
Reviewers: wez, #mercurial, rmcelroy
Reviewed By: rmcelroy
Subscribers: mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D4920337
Signature: t1:4920337:1492676584:1c26f2673c14e79793a3ee80c3281fd1bc76a313
Summary:
deals with the tests failing like this on my python 2.7 system:
```
+ /data/users/wez/facebook-hg-rpms/fb-hgext/hgext3rd/uncommit.py:144: DeprecationWarning: With-statements now directly support multiple context managers
+ with nested(repo.wlock(), repo.lock()):
```
Test Plan: arc unit
Reviewers: #mercurial, stash, simonfar, wez
Reviewed By: stash, simonfar
Subscribers: mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D4910040
Signature: t1:4910040:1492593520:ff815c5dbed4a341e0a313cd7160b700d878ee2c
This is an import of a bugfix in upstream evolve by Martin.
As reported in the issue, "hg uncommit" would lose copy information of
the files that remained in the commit. The problem was simply that the
a dict of copies was iterated as "src, dst in copies.items()" where it
should have been "dst, src ...".
Summary:
Using `testedwith = 'internal'` is not a good habit [1]. Having it
auto-updated in batch would also introduce a lot of churn. This diff makes
them "ships-with-fb-hgext". If we do want to fill the ideal "testedwith"
information, we could put it in a centric place, like a "fbtestedwith"
extension rewriting those "ships-with-fb-hgext" on the fly.
Maybe having in-repo tags for tested Mercurial releases is also a good idea.
[1]: www.mercurial-scm.org/repo/hg/rev/2af1014c2534
Test Plan: `arc lint`
Reviewers: #sourcecontrol, rmcelroy
Reviewed By: rmcelroy
Subscribers: rmcelroy, mjpieters
Differential Revision: https://phabricator.intern.facebook.com/D4244689
Signature: t1:4244689:1480440027:3dc18d017b48beba1176fbfd120351889259eb4b