Summary: I want SeedHead to be a part of config - not something we generate in SC code. This diff will make more sense once you read the next ones.
Reviewed By: farnz
Differential Revision: D35934783
fbshipit-source-id: 8a68052e299401760a95d0f4e8ebf633767cb471
Summary:
I'm about to change the data model to allow the user to ask segmented chagelog
all bookmarks except some.
Reviewed By: farnz
Differential Revision: D35934781
fbshipit-source-id: cac7829adba4dbf509006064bf88f7e1147ca390
Summary:
change the tooltip during a checkout operation. Also change it back when the checkout finishes.
The debug menu can also enable this tooltip by changing the icon color to orange. Changing the color to green or white will change the tooltip back
A similar tooltip is also implemented for when EdenFS detects an unhealthy mount
Reviewed By: kmancini
Differential Revision: D35488235
fbshipit-source-id: a33ebfd15cbfd0d46eea85f32be4ddd1bb09f357
Summary:
On Windows, EdenFS should signal that it's working on a checkout operation by changing the color of the E-Menu.
We also add a debug menu option for changing the E-Menu color
Reviewed By: chadaustin
Differential Revision: D35487175
fbshipit-source-id: fae587a223e9ce910e5558b36008a8c97b9dd3ea
Summary:
I'm about to add another stream, and this code will be duplicated a third time,
let's refactor it.
Reviewed By: chadaustin, fanzeyi
Differential Revision: D35767107
fbshipit-source-id: 44975b72a705bd4d2d749b8caacb56743153a148
Summary: before, if we exceeded 24 hours of uptime the E-Menu would roll over to 0 hours of uptime. We can avoid this by adding days to the uptime print out. We don't print out the number of days if the uptime is less than 1 day.
Reviewed By: chadaustin
Differential Revision: D35954540
fbshipit-source-id: 9285433a827f8494b840e9d551cb6504f94417b7
Summary:
Hyper used to have stricter trait bounds for stream bodies, however
they were relaxed in https://github.com/hyperium/hyper/pull/2187.
Remove the code to spawn a task that simply connected streams up now that hyper
is more relaxed. As the spawned task was just polling for data, it shouldn't
add any extra computational work onto the task used for a request.
This change is basically identical to D27963458 (e5cc9a1f3d).
Reviewed By: mitrandir77
Differential Revision: D35931360
fbshipit-source-id: 065fecc77b4ac1218c2be21e0a3639103429c5bc
Summary:
D35892336 (9b18b0d3be) fixed a bug in the LFS server that meant it would consider
an upload successful, even if writing to internal stores failed.
Add a test that verifies writing to a failing blobstore results in upload
failure.
Reviewed By: mitrandir77
Differential Revision: D35928308
fbshipit-source-id: 296ccdddb6f4b86f5fb778f97185a8a6a0ea9d17
Summary:
The upload code can be updated to use the `?` operator, which makes
the code a little simpler.
Reviewed By: mitrandir77
Differential Revision: D35936319
fbshipit-source-id: 054f1e40798a38ff699f56dacfff055eb8c60263
Summary: I'm about to touch this function so I think it's better to have it tested.
Reviewed By: quark-zju, farnz
Differential Revision: D35897942
fbshipit-source-id: 81a141d06a4c326a37cac04a8e4cfb0c97365cf1
Summary: We can use specific types so let's use them.
Reviewed By: farnz
Differential Revision: D35897795
fbshipit-source-id: f966191d05ac7b0228b14539d88c825103b3f38f
Summary: This allows cancelling the request, and cleans up some test-only code.
Reviewed By: chadaustin
Differential Revision: D35754296
fbshipit-source-id: cd0adc2f1d3333efbd718b5954c77f72c9a9e1dd
Summary: As "new worker" was implemented in a separate crate it's time to unwrap it and place in the root.
Reviewed By: yancouto
Differential Revision: D35544988
fbshipit-source-id: 906846d1b2a00ba59f5501c5baf3d35bef311400
Summary:
Create `EdgeTypeArg` that wraps vector of `EdgeTypes` and replaces string-typed arguments. Implementing `FromStr` trait for the `EdgeTypeArg` will remove parsing boilerplate as now clap will parse the input.
It's also possible to implement `ArgEnum` for this struct, but I have some small concerns over it (particularly with `fn value_variants<'a>() -> &'a [Self]` method). Anyway I will check it out and most probably switch to `ArgEnum` in another diff.
Reviewed By: yancouto
Differential Revision: D35540307
fbshipit-source-id: a6b1983a3c53d2810f3099e1319175f239b9d6cf
Summary:
Create `NodeTypeArg` that wraps vector of `NodeType`s and replaces string-typed arguments. Implementing `FromStr` trait for the `NodeTypeArg` will remove parsing boilerplate as now clap will parse the input.
It's also possible to implement `ArgEnum` for this struct, but I have some small concerns over it (particularly with `fn value_variants<'a>() -> &'a [Self]` method). Anyway I will check it out and most probably switch to `ArgEnum` in another diff.
Reviewed By: yancouto
Differential Revision: D35540309
fbshipit-source-id: 57b618c8b2da565be1bcb61767a86114f2599c1e
Summary:
I'm adding another branch to the test git repo to verify that we indeed merge the head of master branch into hg repo.
Also, I'm moving the importing bookmark to the merge commit.
Reviewed By: mitrandir77
Differential Revision: D35606582
fbshipit-source-id: b80ba2c0850b1194faee83268e6eb60e541cd3e5
Summary: Keep usage of Eden vs EdenFS consistent. Also update the title of the message box so it's consistent with the menu item
Reviewed By: chadaustin
Differential Revision: D35951678
fbshipit-source-id: fb62f6edf66ba9159a50130de9ed3a13fff7a1e2
Summary: "Quit E-Menu" is ambiguous and could mean a number of things. We should make it clear that clicking this menu option will cause the E-Menu notification icon to be hidden
Reviewed By: chadaustin
Differential Revision: D35950442
fbshipit-source-id: 86527479dae544bc7db3e596e3bf8477bd147213
Summary: Typoing a path with `eden rm` would tell users that there isn't an existing checkout with that name. That can be confusing. Instead, we should be more specific and let users know when they typo'd
Reviewed By: kmancini
Differential Revision: D35690339
fbshipit-source-id: 8d2bae48d3bb3724cd6c1b4049af3df71c04a287
Summary: We can potentially race if we try to update notificationStatus_ from outside the event thread. As long as we only try to update from within the single thread, we should be fine.
Reviewed By: kmancini
Differential Revision: D35514682
fbshipit-source-id: 0ee8baec6816cebf91fe4fe1c95f1156b5064a42
Summary: `setup.rs` is going away, so let's move repo setup to its proper place
Reviewed By: yancouto
Differential Revision: D35540308
fbshipit-source-id: ee72c0ab7bf24a39902b74d0dfe054db56e439c1
Summary: Adds a function that creates a directory and all of its ancestors, and sets the selected mode for the created directory for Unix-like systems.
Differential Revision: D35832456
fbshipit-source-id: add61ec490395cb1ce7401824abb307450f84280
Summary: All of these were implemented using new clap.
Reviewed By: yancouto
Differential Revision: D35532738
fbshipit-source-id: a7262b1c905c198cf06140720371e9bfa8f20827
Summary: These "old" integration tests are basically duplicates of the new ones. Let's delete them and rename `mononoke_new_walker` as just `mononoke_walker`
Reviewed By: markbt, mitrandir77
Differential Revision: D35532373
fbshipit-source-id: c845f9770d1a3d74719a44a43b65f05a681a6371
Summary:
We should all be migrating to platform010, for the improved performance of its
generated code and for its improved diagnostics/portability.
Reviewed By: kmancini
Differential Revision: D35851539
fbshipit-source-id: d42b12c77ddeacb4777f2e360fdebd1cbbc1bd6d
Summary:
With the `github` extension enabled, `hg link` associates pull request data
with a commit in the metalog. Note that nothing verifies that this
linkage exists on GitHub. Ultimately, `hg submit` will be required
to remap the commits within the actual pull request on GitHub.
I'm not sure what best practices are in terms of using flags
versus positional arguments in the CLI, but we can continue
to experiment with that, for now.
Reviewed By: quark-zju
Differential Revision: D35638199
fbshipit-source-id: f72514b13627a8ef845ffb99e6ae3c86098061cd
Summary: Version 0.4.28 had some misguided use of glob imports which is blocking updating other crates.
Reviewed By: zertosh, lei2022
Differential Revision: D35936373
fbshipit-source-id: 011a703bde19482e9450b00f91cb0836d434c502
Summary:
The repo factory is the place where we have all elements needed for
instantiating a segmented changelog manager. Let's add that as an option.
It's going to be useful for some specialized binaries that don't just want to
query the segmented changelog but want to understand what version of SC do we
currently store an to be able to reload SC at will.
Reviewed By: quark-zju
Differential Revision: D35744722
fbshipit-source-id: 37f9dc4b5750b48212be1bffbdae189341fb2a06
Summary:
This can be used by slow bookmark mover to check if the certain commits were indexed by segmented changelog.
The current implementation has to instantiate the SC but in the future we don't need to do it.
Reviewed By: farnz
Differential Revision: D35744724
fbshipit-source-id: d694a135db0b9af6493477b31d7c1e4277471e8c
Summary:
I'm planning to create manager separately so let's split that part to separate
function.
refactor_time
Reviewed By: yancouto
Differential Revision: D35744723
fbshipit-source-id: 85e168626a9ed4d0085bf425666220c91d418f1a
Summary:
This binary wasn't covered by any tests before.
Note: For this test I had to allow the mononoke hg sync job to act on bookmark moves
created by tests. I think that's fine (we don't have any in production - if we
had the bundle preprarer would be erroring out on them).
Reviewed By: yancouto
Differential Revision: D35648045
fbshipit-source-id: dae3dd89eeaf3c775e5046518a99b755923aff8a
Summary:
allow-large-files
Upgrading async-compression with a patch because they are using old versions of zstd (renamed to libzstd in their dependencies) and zstd-safe
Updated aes-gcm-siv and curve25519-dalek too. Please refer to inline comments. Here is how I pinned the crate:
- git clone the repo
- git checkout the tag
- make changes
- git push -f origin HEAD:master
- use the commit hash and your forked repo to update cargo.toml
Reviewed By: wqfish
Differential Revision: D35585200
fbshipit-source-id: 70c51bf1902c6eaf72004a49bc2be9eaf782e360
Summary:
When EdenFS is starting, `eden start` will attempt to start another EdenFS daemon then it will get a flock error.
On Windows, sometimes we saw a long EdenFS startup process, and this behavior misleads people to think they are not able to start EdenFS.
Reviewed By: xavierd
Differential Revision: D35799954
fbshipit-source-id: 5f58e3ad89962f61d233f962a3e464fe55a9cd8b
Summary: This menu item will cause a shell to be launched and `eden rage --report` to be run.
Reviewed By: chadaustin
Differential Revision: D35327029
fbshipit-source-id: b17c90386e8beb028848fa3d99927dae3c971add
Summary: This will be used in a later diff to give users a "one click" report option.
Reviewed By: chadaustin
Differential Revision: D35330514
fbshipit-source-id: 0d9f3987d788d21cebc71afc796c252eb71028a3
Summary:
The JSON string interface was used when there is no clear way to convert
between a PyObject and a Rust serde-serializable object (blackbox::Event).
Now we can convert between them easily let's avoid the extra JSON round-trip.
Differential Revision: D35236903
fbshipit-source-id: 51cd8028e459f551918777cb572e286cc1d848fe
Summary:
When uploading content to the LFS server it attempts to store the
content in an upstream server, as well as internal data stores. If either of
those fail, then the upload should be considered a failure and the client
should retry. However, D22192005 (ce7f53422f) refactored the code and accidentally updated
`internal_upload` to always return `Ok(())`.
This meant that a failure to write to the filestore wasn't propagated and so an
upload that actually failed would send an HTTP 200 to the client.
Unfortunately, when the client asks for the blob later the server doesn't know
about it.
Update the code to return `res`, so that errors are propagated.
Reviewed By: krallin
Differential Revision: D35892336
fbshipit-source-id: 5302a34fdd338975e0f0db369ed66692db0ade9f
Summary:
`testing` is non-trivial. Add some documentation to make it easier to
understand.
Differential Revision: D35118756
fbshipit-source-id: dad59472d849eb80e230a83403e8c6af48137e6c
Summary:
It seems certain bundle part is occured twice, triggering double output for
something. I didn't trace down as we plan to migrate away from unmaintainable
bundle2 stdio exchange.
For now just make the test compatible with both runners and we can revisit
later when we remove the bundle2/sshpeer techdebt.
Reviewed By: LynBusch
Differential Revision: D34915624
fbshipit-source-id: c2d53050a14ceb56d89bd0c1831f9ab32caf2e4d
Summary:
Avoid `ui.load()` in debugpython. That's known problematic. Use `ui` and `repo`
provided by `debugshell` instead.
Reviewed By: LynBusch
Differential Revision: D34915618
fbshipit-source-id: 2ca393996318b2479c3996e98d4a5695b648356c
