Summary: Typoing a path with `eden rm` would tell users that there isn't an existing checkout with that name. That can be confusing. Instead, we should be more specific and let users know when they typo'd
Reviewed By: kmancini
Differential Revision: D35690339
fbshipit-source-id: 8d2bae48d3bb3724cd6c1b4049af3df71c04a287
Summary: We can potentially race if we try to update notificationStatus_ from outside the event thread. As long as we only try to update from within the single thread, we should be fine.
Reviewed By: kmancini
Differential Revision: D35514682
fbshipit-source-id: 0ee8baec6816cebf91fe4fe1c95f1156b5064a42
Summary: `setup.rs` is going away, so let's move repo setup to its proper place
Reviewed By: yancouto
Differential Revision: D35540308
fbshipit-source-id: ee72c0ab7bf24a39902b74d0dfe054db56e439c1
Summary: Adds a function that creates a directory and all of its ancestors, and sets the selected mode for the created directory for Unix-like systems.
Differential Revision: D35832456
fbshipit-source-id: add61ec490395cb1ce7401824abb307450f84280
Summary: All of these were implemented using new clap.
Reviewed By: yancouto
Differential Revision: D35532738
fbshipit-source-id: a7262b1c905c198cf06140720371e9bfa8f20827
Summary: These "old" integration tests are basically duplicates of the new ones. Let's delete them and rename `mononoke_new_walker` as just `mononoke_walker`
Reviewed By: markbt, mitrandir77
Differential Revision: D35532373
fbshipit-source-id: c845f9770d1a3d74719a44a43b65f05a681a6371
Summary:
We should all be migrating to platform010, for the improved performance of its
generated code and for its improved diagnostics/portability.
Reviewed By: kmancini
Differential Revision: D35851539
fbshipit-source-id: d42b12c77ddeacb4777f2e360fdebd1cbbc1bd6d
Summary:
With the `github` extension enabled, `hg link` associates pull request data
with a commit in the metalog. Note that nothing verifies that this
linkage exists on GitHub. Ultimately, `hg submit` will be required
to remap the commits within the actual pull request on GitHub.
I'm not sure what best practices are in terms of using flags
versus positional arguments in the CLI, but we can continue
to experiment with that, for now.
Reviewed By: quark-zju
Differential Revision: D35638199
fbshipit-source-id: f72514b13627a8ef845ffb99e6ae3c86098061cd
Summary: Version 0.4.28 had some misguided use of glob imports which is blocking updating other crates.
Reviewed By: zertosh, lei2022
Differential Revision: D35936373
fbshipit-source-id: 011a703bde19482e9450b00f91cb0836d434c502
Summary:
The repo factory is the place where we have all elements needed for
instantiating a segmented changelog manager. Let's add that as an option.
It's going to be useful for some specialized binaries that don't just want to
query the segmented changelog but want to understand what version of SC do we
currently store an to be able to reload SC at will.
Reviewed By: quark-zju
Differential Revision: D35744722
fbshipit-source-id: 37f9dc4b5750b48212be1bffbdae189341fb2a06
Summary:
This can be used by slow bookmark mover to check if the certain commits were indexed by segmented changelog.
The current implementation has to instantiate the SC but in the future we don't need to do it.
Reviewed By: farnz
Differential Revision: D35744724
fbshipit-source-id: d694a135db0b9af6493477b31d7c1e4277471e8c
Summary:
I'm planning to create manager separately so let's split that part to separate
function.
refactor_time
Reviewed By: yancouto
Differential Revision: D35744723
fbshipit-source-id: 85e168626a9ed4d0085bf425666220c91d418f1a
Summary:
This binary wasn't covered by any tests before.
Note: For this test I had to allow the mononoke hg sync job to act on bookmark moves
created by tests. I think that's fine (we don't have any in production - if we
had the bundle preprarer would be erroring out on them).
Reviewed By: yancouto
Differential Revision: D35648045
fbshipit-source-id: dae3dd89eeaf3c775e5046518a99b755923aff8a
Summary:
allow-large-files
Upgrading async-compression with a patch because they are using old versions of zstd (renamed to libzstd in their dependencies) and zstd-safe
Updated aes-gcm-siv and curve25519-dalek too. Please refer to inline comments. Here is how I pinned the crate:
- git clone the repo
- git checkout the tag
- make changes
- git push -f origin HEAD:master
- use the commit hash and your forked repo to update cargo.toml
Reviewed By: wqfish
Differential Revision: D35585200
fbshipit-source-id: 70c51bf1902c6eaf72004a49bc2be9eaf782e360
Summary:
When EdenFS is starting, `eden start` will attempt to start another EdenFS daemon then it will get a flock error.
On Windows, sometimes we saw a long EdenFS startup process, and this behavior misleads people to think they are not able to start EdenFS.
Reviewed By: xavierd
Differential Revision: D35799954
fbshipit-source-id: 5f58e3ad89962f61d233f962a3e464fe55a9cd8b
