Summary: This diff is part of a series to cleanup fb-hgext and make it pass check-code.
Test Plan: all tests pass
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2811887
Summary: This diff is part of a series to cleanup fb-hgext and make it pass check-code.
Test Plan: all tests pass
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2812219
Summary: This diff is part of a series to cleanup fb-hgext and make it pass check-code.
Test Plan: all tests pass
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2811926
Summary: This diff is part of a series to cleanup fb-hgext and make it pass check-code.
Test Plan: all tests pass like before
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2811837
Summary:
Remove the need to ommit the rREPO prefix when copy pasting from phabricator and
looking up a commit.
Test Plan:
Ran the following in phabricator enabled HG repos
11/13 12:15 cdelahousse@dev4253 ~/fbsource/fbcode
$ hg log -r rFBS27aa00fb74d9a3b82756dad6ff26fe253f1e9a70 --config extensions.fbconduit=~/local/fb-hgext/fbconduit.py
changeset: 992495:27aa00fb74d9
user: Peng Li <pengli@fb.com>
date: Tue Nov 03 10:29:01 2015 -0800
summary: Add a simple root dir arc library
11/13 12:21 cdelahousse@dev4253 ~/fbjava
$ hg log -r rFBA8f1335e6d588 --config extensions.fbconduit=~/local/fb-hgext/fbconduit.py
changeset: 18654:8f1335e6d588
user: Ryan Menezes <ryandm@fb.com>
date: Thu Oct 22 09:59:27 2015 -0700
summary: move jenkins hook into fbjava/arcanist (fbjava changes)
Tried the same on a repo with a git mirror that exists in phabricator:
11/16 11:40 cdelahousse@dev4253 ~/fbsource/fbcode
$ hg log -r rFBCODE8272d25d65869ce059024ff38c7051388ad7b802 --config extensions.fbconduit=~/local/fb-hgext/fbconduit.py
changeset: 1027287:f26a9c32ae08
user: Oleksandr Kuvshynov <oleksandr@fb.com>
date: Sun Nov 15 19:16:39 2015 -0800
summary: [mf] simple cleanup of feed story view
If a git hash is too small, abort:
$ hg log -r rFBCODE8272d25d65869ce059024f --config extensions.fbconduit=~/local/fb-hgext/fbconduit.py
abort: git hash must be 40 characters
The previous commands depends on a list of repos set in my hgrc. See (D2660070)
[fbconduit]
gitcallsigns=LK, CFPUMA, CFSV, CFGK, CFMF, CFGMON, CF, RSIGMA, FA,·
WAWEBCLIENT, SKY, FBCODE, FBOBJC, WAWP, SV, OVRMOBILEMAIN, WAANDROID, IGSRV,
CPE, MSS, ANDROIDSDK, BUCK, IT-CHEF, WABB, ITINFRA, SIGMA, IOSSDK
Reviewers: #sourcecontrol, durham, ericsumner
Reviewed By: durham, ericsumner
Subscribers: rmcelroy, ericsumner
Differential Revision: https://phabricator.fb.com/D2653497
Tasks: 8361368
Signature: t1:2653497:1447480768:295079a7793e182ddea3aeece9cfaead1bfc1a57
Summary: The regular expression was matching hg hashes that started with a digit.
Test Plan:
Ran it in different repoes:
This should fail (fbcode)
11/13 11:15 cdelahousse@dev4253 ~/fbsource/fbcode
$ hg up rFBCODE8a781801149 --config extensions.fbconduit=~/local/fb-hgext/fbconduit.py
abort: unknown revision 'rFBCODE8a781801149'!
These should succeed (WWW and opsfiles)
11/13 11:16 cdelahousse@dev4253 ~/www
$ hg log -r rE1502460 --config
extensions.fbconduit=~/local/fb-hgext/fbconduit.py
changeset: 808001:34d7f02c58d6
user: cdelahousse@2c7ba8d8-a2f7-0310-a573-de162e16dcc7
date: Thu Nov 20 04:45:21 2014 +0000
summary: CRMEmailHarvester Script runner for raw email processor
11/13 11:29 cdelahousse@dev4253 ~/opsfiles
$ hg log -r rO766855 --config
extensions.fbconduit=~/local/fb-hgext/fbconduit.py
changeset: 758197:db438a952785
user: twsvcscm@914ed892-1039-11dd-9db8-c56a9f3689f4
date: Sat Oct 31 01:13:33 2015 +0000
summary: [Storage] netgroup_gen AUTOCOMMIT
Reviewers: #sourcecontrol, rmcelroy
Subscribers: cdown
Differential Revision: https://phabricator.fb.com/D2653121
Tasks: 9071883
Summary:
Removes the need strip the capital letters from an SVN revision when accessing a revision
rE1502460 -> r1502460
Test Plan:
Manually in opsfiles hg and dubdubdub
In opsfiles:
hg show rO766855
In dub dub dub
hg log -r rE1502460
Reviewers: durham, #sourcecontrol, ericsumner, rmcelroy
Subscribers: ericsumner, rmcelroy
Differential Revision: https://phabricator.fb.com/D2603749
Tasks: 8361368
Summary:
FBConduit used to throw a conduit error when a rev didn't map.
Now, it just returns an empty string for the mapping. This updates the
fbconduit extension so that it matches the server behavior.
Test Plan: passed unit tests.
Reviewers: mitrandir, ericsumner, durham
Reviewed By: ericsumner
Subscribers: mitrandir
Differential Revision: https://phabricator.fb.com/D2331464
Tasks: 7970302
Signature: t1:2331464:1439500203:cbf79e9b9c54aebdf33bbad82c1982b5a69e8bc9
Summary:
# added a backingrepo list configuration variable that enumerates the backing repos.
# wrote a bunch of unit tests to cover this functionality.
Test Plan: passed unit tests.
Reviewers: rmcelroy, durham, ericsumner
Subscribers: mitrandir
Differential Revision: https://phabricator.fb.com/D2247419
Summary:
# mapping['repo'] doesn't exist. looks like it was copypasta from `mirrornode()`.
# the error message is not particularly helpful (it's basically the server return message without any context). changed that.
# repo[hash] runs into a mercurial bug where passing in a hash string triggers some unicode error messages (https://phabricator.fb.com/P19919583). work around this by querying with the binary string representation.
Test Plan: passed fbconduit unit test.
Reviewers: lcharignon, rmcelroy, durham, ericsumner
Reviewed By: ericsumner
Subscribers: mitrandir
Differential Revision: https://phabricator.fb.com/D2246978
Signature: t1:2246978:1436993587:31857064ce810c604ce1c071bfed484b96150b37
Summary:
Added a config option fbconduit:protocol to override the
protocol. It can be set to http or https.
Test Plan: used in later diff
Reviewers: lcharignon, rmcelroy, durham, ericsumner
Reviewed By: ericsumner
Subscribers: mitrandir
Differential Revision: https://phabricator.fb.com/D2244919
Signature: t1:2244919:1436982823:6c5cb7085607285d2a68822ee2401a11af3201f5
Summary:
This copies a bunch of logic from ##gitrevset.py## which should allow the
##fbconduit## extension to be a complete replacement for ##gitrevset##.
Overall, execution times are comparable for the revset and will be much
better for the template (assuming >20% cache hit rate)
Test Plan:
hg log -r 'gitnode("32cb236d579acb48668f8575205c0611b859e883")' -T '{node}\n'
hg log -r 'g32cb236d579acb48668f8575205c0611b859e883' -T '{node}\n'
hg log -r 'master~50::master' -T '{gitnode}\n'
Reviewers: #sourcecontrol, sid0
Reviewed By: #sourcecontrol, sid0
Subscribers: sid0
Differential Revision: https://phabricator.fb.com/D2074214
