Summary: Sync definitions from configerator and add local definitions for new hook config.
Reviewed By: RajivTS
Differential Revision: D49094388
fbshipit-source-id: aeba2d69d1be6ebd2f52fe61fdbd4ef5415c9681
Summary:
picking up from D37112756.
given thrift library `foo`, where before we'd generate target `foo-rust` (containing a `types.rs` module) we now generate two targets, `foo-rust` & `foo-rust-types` where the `types.rs` module is in the latter crate which is depended upon by the former. the motivation is to enable greater build parallelism (see D37112756 for more).
## buck
### files and symlinks in buck-out/.
single-file-thrift-library-foo multi-crate {F1041073024}
multi-file-thrift-library-foo multi-crate
{F1041073062}
## autocargo
### files in target/.
single-file-thrift-library-foo multi-crate {F1041073095}
multi-file-thrift-library-foo multi-crate {F1041073125}
## deployment plan
- diff (1) land autocargo changes (D47342888)
- will break autocargo workflows not using `arc`
- diff (2) initiate an autocargo bump
- https://www.internalfb.com/intern/msdk/bump/autocargo
- diff (3) (D46573767 - this diff) rebase all remaining changes on (2) and land it
- thrift compiler, compiler wrapper, rust thrift build defs
- regenerated 'Cargo.toml', 'thrift_build.rs' and 'thrift_lib.rs' files
- will break autocargo thrift builds (bad "thrift1"; invoking incompatible thrift compiler)
- diff (4) initiate a thrift1 bump (now (3) has landed) and land it
- https://www.internalfb.com/intern/msdk/bump/thrift1
Reviewed By: zertosh
Differential Revision: D46573767
fbshipit-source-id: b2db8e3bf307a6498f92cdb8a64c26b8871a0a1d
Summary:
The casefolding pushrebase check is blocking the sync of www commits causing
problems. Let's exempt www/ dir from it.
We'll also have to modify commit hooks - but that's a separate thing.
Reviewed By: markbt
Differential Revision: D46860559
fbshipit-source-id: 87db959e0d025c0c1fc5c6cfecbdcf96af9e0f81
Summary: We need a way to specify which repos will use a preloaded commit graph and the blobstore key of the commit graph blob in that case.
Reviewed By: RajivTS
Differential Revision: D45993558
fbshipit-source-id: 4cf2ea84b72e3a50187fab3ece86e623a754d571
Summary:
No need for this anymore.
Removing in configerator here: D45394588
Reviewed By: mitrandir77
Differential Revision: D45769295
fbshipit-source-id: c254cac81f931a02f075cf6b37dbf82257afd7eb
Summary:
Corresponding configerator diff - D45732232
This will allow to construct facet to connect to those sql databases.
Reviewed By: mitrandir77
Differential Revision: D45735055
fbshipit-source-id: 5a2bd81779f6118072b5b56e7b9365047987b9cc
Summary:
Seem summary on the previous diff.
This functionality should be a super set of the previous logic.
Reviewed By: mitrandir77
Differential Revision: D45395320
fbshipit-source-id: 2ebf08c6b8c3480ea30cd2bf4635fc116ecd65b6
Summary:
Note: this is a re-land of D44623815, which was was reverted because of a land race with D44626072
In particular this fixes `FlattenUnordered` having a nasty deadlock, but also
some other bugs:
```
# 0.3.28 - 2023-03-30
* Update to syn 2. This raises MSRV of utility crates to 1.56. (#2730, #2733)
* Fix bug in `FlattenUnordered` (#2726, #2728)
# 0.3.27 - 2023-03-11
* Add `TryFlattenUnordered` (#2577, #2590, #2606, #2607)
* Add `AbortHandle::is_aborted` (#2710)
* Add `AbortRegistration::handle` (#2712)
* Make `BiLock` strict-provenance compatible (#2716)
# 0.3.26 - 2023-01-30
* Add `Either::as_pin_mut` and `Either::as_pin_ref` (#2691)
* Add `Shared::ptr_eq` and `Shared::ptr_hash` (#2691)
* Implement `FusedStream` for `Buffered` (#2676)
* Implement `FusedStream` for all streams in `ReadyChunks` (#2693)
* Fix bug in `FuturesOrdered::push_front` (#2664)
* Remove `Fut::Output: Clone` bounds from some `Shared` methods (#2662)
* Remove `T: Debug` bounds from `Debug` implementations of `mpsc` and `oneshot` types (#2666, #2667)
# 0.3.25 - 2022-10-20
* Fix soundness issue in `join!` and `try_join!` macros (#2649)
* Implement `Clone` for `sink::Drain` (#2650)
# 0.3.24 - 2022-08-29
* Fix incorrect termination of `select_with_strategy` streams (#2635)
# 0.3.23 - 2022-08-14
* Work around MSRV increase due to a cargo bug.
```
Reviewed By: zertosh
Differential Revision: D44632588
fbshipit-source-id: bdd87cb02b3aef63a65b1f9b852579225adfedbd
Summary: These files don't have corresponding TARGETS so are presumably not used anywhere
Reviewed By: vitaut
Differential Revision: D44545218
fbshipit-source-id: a898bde46787d40cda8e78c6cc0b4bf2686c98a6
Summary:
Now that `deep_sharding` is expressed via `ShardingModeConfig`, the repo-level `deep_sharded` boolean flag can be removed.
Corresponding configerator diff: D42676137
Reviewed By: markbt
Differential Revision: D42676143
fbshipit-source-id: 09b87aab1718f828c3015930645ba58ca58bb1fd
Summary:
In D38786500, I introduced `deep-sharded` flag that controls whether a repo needs to execute in deep-sharded mode or shallow-sharded mode. However, the flag was universal (i.e. it was applicable to all services). Since we currently have a situation where certain services need to execute repos in deep sharded (e.g. `SCS`) while others need to execute in shallow-sharded mode (e.g. `Eden API`). This diff introduces `ShardingModeConfig` which determines if a repo is deep sharded for a particular service.
For now, the `deep_sharded` flag is kept as is. Once the config + code changes to use this new property are landed, I will delete the old `deep_sharded` flag.
Corresponding configerator diff: D42501648
Differential Revision: D42530372
fbshipit-source-id: 1bd46533ad18939da4465239dab1340a0e8219d2
Summary:
**Context**: The write-mostly name is confusing and out of date. We never read from write-mostly blobstores (only on scrub). Let's rename it to write only to make it less confusing.
See D41520772 for migration plan.
This diff is the step (3). It will only be landed after previous diff rolls out.
Reviewed By: mitrandir77
Differential Revision: D41520763
fbshipit-source-id: f3775ad13439a9326b7fdc4cba5b691d59af4770
Summary: This makes WAL support unsharded DB, which makes MySQL integration tests work again.
Reviewed By: mzr
Differential Revision: D42430809
fbshipit-source-id: b6e2dce380a5c91700dc920fa0cdc993e00cb3e6
Summary: This syncs changes from D42145360 and deletes the category fields from thrift.
Reviewed By: mitrandir77
Differential Revision: D42145669
fbshipit-source-id: 1268308be11af86180709c2b46a407c41c731321
Summary:
**Context**: The write-mostly name is confusing and out of date. We never read from write-mostly blobstores (only on scrub). Let's rename it to write only to make it less confusing.
See D41520772 for migration plan.
This diff is the fbsource part of step (1): **Makes our code accept both configs as meaning write only** and does all the renames.
The most important change is file `eden/mononoke/metaconfig/parser/src/convert/storage.rs`, which starts accepting `write-only` config as well as `write-mostly`.
Reviewed By: mitrandir77
Differential Revision: D41520648
fbshipit-source-id: b0274c937ca7db10debb8c952a9a1867c0b431c1
Summary: This syncs the config change from D41469348, and fully removes logic to do pushrebases remotely through SCS. Now everything should go through land service (and already does so in production).
Reviewed By: RajivTS
Differential Revision: D41469510
fbshipit-source-id: 0e41624a84b8cbefaf3793a5f98533f9abd2257a
Summary:
**Context**: We want to roll out the new WAL multiplexed blobstore and need final tweaks before doing that. See https://fb.quip.com/vyTWAgGZSA2Z
This sync configerator changes from D40754273, and updates our internal configs to load two types of scuba tables. But it continues doing the same as before, only logging to scuba on internal blobstore queries.
I also renamed `scuba` to `inner_blobstores_scuba` to make it clear, because that's confusing on the current multiplexed blobstore.
Note: the thrift compat error is fine to bypass because we're not using this thrift schema anywhere yet.
Differential Revision: D40720597
fbshipit-source-id: fceb9d72b20e298d52744dfd79798c36f34b07da
Summary:
**Context**: We want to roll out the new WAL multiplexed blobstore and need final tweaks before doing that. See https://fb.quip.com/vyTWAgGZSA2Z
This syncs configerator changes from D40677044 and updates our code so that WAL config now takes a sharded DB instead of unsharded. The code for dealing with sharded connections was already added on D40673033, this is just the config to enable it.
For now this is not enabled anywhere. The plan is to:
- Test it locally with locally built binaries
- Move a small-ish repo
- Move everything
This is once we have full feature parity, which is still not done (things like Scuba logging and scrub blobstores are missing)
Differential Revision: D40675512
fbshipit-source-id: 70f74a53dbf10eadc73ce9e210ec7719f866e30a
Summary:
This diff declares a new config for the WAL multiplexed blobstore. It is different from the current multiplex in the way it defines write/read quorums.
The main reason for a separate config is ability to iteratively switch repos and different parts of the Mononoke tools from the old multiplex to the new one.
Reviewed By: yancouto
Differential Revision: D40108825
fbshipit-source-id: 9dae447557702474b6427ad247164a879da90861
Summary: This release makes async trait methods work better with rust-analyzer's "go to definition" and other IDE functionality.
Reviewed By: zertosh
Differential Revision: D40532047
fbshipit-source-id: 1871d1819ebe1aab0846b0135f051c45e6e8821b
Summary:
It (1) adds the repo in the Land Service, (2) includes Remote Land Service and remote land service with local fallback, (2) get the address from tier or host and calls the client in the unbundle processing
The Static analysis failed in the FBTHRIFTCOMPAT1 because i added a new field in the land_changesets method in the impl LandService (land_service_impl.rs). It does not break anything since we do not have the server in production. I mean, changing the id does not influence on previous versions of the server since there is no land service server in production.
Reviewed By: yancouto
Differential Revision: D39553570
fbshipit-source-id: bb1f09c2ab2c111734b9026109fc39e14c514516
Summary: I will use this to correctly infer scm_type in Hack's scmquery-proxy client library.
Differential Revision: D39492898
fbshipit-source-id: 4d9aafcb88f75b20260d4212bae70495efca22d5
Summary: Most of fast replay was removed in D34073952 (a9eaa380fe) but I found some more code, so delete that
Reviewed By: HarveyHunt
Differential Revision: D39547680
fbshipit-source-id: b35850621b3d37b939a1a44db7926f52d583326a
Summary: D39418421 (a1593af094) prematurely upgraded `thiserror`. Various projects in fbcode use nightly features including std::backtrace but the current fbcode Rust toolchain is 1.63.0, in which the backtrace API is different from the API of the latest nightlies.
Reviewed By: quark-zju
Differential Revision: D39562441
fbshipit-source-id: d1f8a993ec776cf82b1736b242bd4466def21230
Summary: This adds a wrapper that knows how to wait for replication of xdb blobstore and sync queue, and for that uses the configerator config added on D39387517, so that this can be hot-reloaded.
Reviewed By: RajivTS
Differential Revision: D39387650
fbshipit-source-id: 548f99bc1b0b3634c8b8a6fb9ea7815edb41d3e4
