Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves Throw.h and it's related tests from eden to edencommon.
Reviewed By: genevievehelsel
Differential Revision: D54046153
fbshipit-source-id: 669d702c13e70536d9c0b58ff8ff17f826237851
Summary: The comment was somewhat unclear. Expand on the soft vs hard choice and add a man page that future devs can reference to understand each option.
Reviewed By: genevievehelsel
Differential Revision: D52710081
fbshipit-source-id: 53bc2eae3799e775a8bbc5dad9bb99ca6e713632
The internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.
Summary:
clang-tidy had some automated suggestions for our code. Apply the ones
that make sense.
Some of them didn't, like removal of all uses of `volatile`. I
manually reverted those changes.
Reviewed By: genevievehelsel
Differential Revision: D41051052
fbshipit-source-id: 3fe22a91e929d3bb8e6346126c2c7bf9f027eb32
Summary:
We already had a pretend PrivHelper on Windows. Remove the stub
methods on Windows and provide a Windows implementation of PrivHelper
where most methods are no-ops but the mounts throw a NOT_IMPLEMENTED
error.
Reviewed By: kmancini
Differential Revision: D45260187
fbshipit-source-id: 87ca8679947372e484c345acdd708a17dbb8235e
Summary:
We don't have a kext on macOS anymore, so we can remove the
configuration setting that enables it.
If we ever build our own kernel module on Linux, we can bring this back.
Reviewed By: kmancini
Differential Revision: D45260142
fbshipit-source-id: 6f99bdfb3fce236b7a17a665818327f00b5884c0
Summary:
We use SpawnedProcess on all platforms to start the privhelper, so we no longer
need to include sys/wait.h. This removes a conditional #include.
Reviewed By: genevievehelsel
Differential Revision: D45259880
fbshipit-source-id: dd54c60c13e34fc819eec4c4143e3c7da37329b0
Summary:
We use privhelper for NFS too, so move fs/fuse/privhelper into
fs/privhelper.
Reviewed By: kmancini
Differential Revision: D45243273
fbshipit-source-id: cfc93b324768809c87075b0085905e873c7ea88d