Summary:
Some bundle2 handlers (such as pushvars) run prior to the acquisition of the lock. In order to have those handlers be able to set hook variables, we have to save the hook variables onto the bundle object, rather than the transaction object.
Once the transaction is retrieved, we drain all the hook arguments into the transaction. Further attempts to call `addhookargs will cause an abort.
An alternative to aborting is to save the transaction, and pass further arguments to the transaction. I believe this is an inferior choice because it is masking a bug.
Test Plan: run ./verify_reviewedby_info.t in opsfiles with D2880506 patched in. passed.
Reviewers: #sourcecontrol, durham
Reviewed By: durham
Subscribers: durham, mitrandir
Differential Revision: https://phabricator.fb.com/D2898401
Signature: t1:2898401:1454615031:94933cf513eaa06c5b60686ec5d65a563ddc31c4
Summary:
I've written it sometime ago and it's not being shipped yet because I forgot to
add it to setup.py
Test Plan: no plan
Reviewers: #sourcecontrol, durham, ttung, rmcelroy
Reviewed By: rmcelroy
Differential Revision: https://phabricator.fb.com/D2887171
Signature: t1:2887171:1454413837:4a57fc8bccfe840c5540e0db59881af2bea21e45
Summary:
There are a few ways in which the 'hg show' alias doesn't work for users:
1) if your argument to 'hg show' isn't in exactly the right form, you get confusing messages (e.g. if you run 'hg show --help').
2) It's slow compared to 'git show', and needs speeding up. There's some low-hanging fruit identified by bryano, and having the command as a native command makes it easier to go there.
As a first step towards fixing this, reimplement the existing alias as a Python extension, aiming for minimum behaviour changes. We can inline the implementation of 'hg log' when we need to.
Test Plan:
Run the new automatic test test-show.t:
: /data/users/simonfar/fb-hgext (hg) [nativeshow]
: simonfar@devvm148 tests $ ../../hg/tests/run-tests.py -l test-show.t
.
# Ran 1 tests, 0 skipped, 0 warned, 0 failed.
Note that this means that review needs to cover the automatic test, too, in case I've missed anything important
Reviewers: #sourcecontrol, lcharignon, ttung, rmcelroy
Reviewed By: lcharignon, rmcelroy
Subscribers: rmcelroy, lcharignon, #sourcecontrol
Differential Revision: https://phabricator.fb.com/D2820421
Tasks: 9323445, 9599994
Signature: t1:2820421:1452541611:02efa59739f690b30053d93e0d47adf0aef8dbf4
Summary: We removed the module, let's remove it from the setup too
Test Plan: setup builds
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2821846
Summary: I forgot to remove it in my previous commit removing the subrepo
Test Plan:
I ran successfully:
python setup.py build
Reviewers: #sourcecontrol, ttung, akushner
Reviewed By: akushner
Subscribers: akushner
Differential Revision: https://phabricator.fb.com/D2819305
Signature: t1:2819305:1452487342:f04e7e79e3427e6779aed3332746f256ddcc86e5
Summary: It was missing, so we couldn't ship it
Test Plan:
I rand
python setup.py build
It completes successfully and shows the module in the list.
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2819070
Summary: loading copytrace
Test Plan: i built the rpm locally
Reviewers: #sourcecontrol, rmcelroy
Differential Revision: https://phabricator.fb.com/D2682418
Tasks: 8501037
Summary: Because working in a virtualenv w/ setuptools makes things a little easier :)
Test Plan: workon hg && python setup.py develop
Reviewers: rmcelroy, durham
Reviewed By: durham
Differential Revision: https://phabricator.fb.com/D2570341
Signature: t1:2570341:1445542319:0f30cb4aefb7c59753decda4535ca335a4f423cc
Summary:
This extension was a temporary hack to help people move from the experimental
bundle2 format to the final one. All user have been moved so we can put this
very hacky extension to the sword.
Test Plan: ran setup.py install --prefix /tmp/foobar, b2xcompat was no longer there.
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.fb.com/D2298571
Summary: inhibit: add extension to warn evolve beta users
Test Plan:
Checked with and without cutoff date set in hgrc that the message
is displayed when it has to.
Reviewers: durham, pyd
Differential Revision: https://phabricator.fb.com/D2080693
Tasks: 6634899
Summary: Now that we have it, we wants it deployable
Test Plan:
ran setup.py install --prefix=/tmp/babar/
The file was there!
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.fb.com/D1990894
Test Plan:
* New test
* Ran all mercurial tests with this extension enabled. Most tests passed, and the ones that failed were due to additional output thansk to the enabled extension (eg, help screens mentioning the extenstion, and config dumps listing the extension as enabled).
Reviewers: sid0, davidsp, pyd, durham
Reviewed By: durham
Subscribers: ps
Differential Revision: https://phabricator.fb.com/D1691116
Tasks: 5503905
Signature: t1:1691116:1418066154:9d0950b7395038a7fa95b4ec26f9360ea2db9fc6
Summary: add the chistedit extension that adds an interactive ncurses based
interface for histedit. It requires python-curses to be installed and the
Mercurial histedit extension to be enabled.
Test Plan: enabled and used it
Reviewers: durham, sid0, pyd
Differential Revision: https://phabricator.fb.com/D1662465
Summary: add fbhistedit extension to the list of installed extensiosn
Test Plan: run setup, ensure fbhistedit is properly compiled
Reviewers: sid0, daviser, pyd, durham
Reviewed By: durham
Differential Revision: https://phabricator.fb.com/D1627113
Summary:
This makes tweaks to the Mercurial defaults, to improve the user experience:
- hg update without arguments now aborts
- hg log now defaults to -f
- hg rebase without -d now aborts
- hg rebase will fast forward a bookmark if possible
Test Plan: Added a test, ran it.
Reviewers: mpm, sid0, davidsp, dschleimer, akushner
Differential Revision: https://phabricator.fb.com/D1501398
Summary:
Adds an 'hg backups' command that lists the commits in the backup
bundles, newest first. It also allows 'hg backups --recover <commit hash>' which will then
recover the commit from the appropriate backup bundle.
The default output looks like so: https://www.facebook.com/pxlcld/l0gC
Test Plan: Ran it. See the screenshot
Reviewers: mpm, sid0, dschleimer, pyd, davidsp
Differential Revision: https://phabricator.fb.com/D1183032