Summary: This supports new syntax added in the past months, including `c"..."` CStr literals.
Reviewed By: shayne-fletcher
Differential Revision: D47316927
fbshipit-source-id: ac0e514ca89dad282e64decd01d3a94b3bff8490
Summary:
* Added new LogEvent - NfsCrawlDetected
* Refactored code to produce a single string output for logging
* Refactored some improperly named local variables (too much Rust recently)
Reviewed By: mshroyer
Differential Revision: D47280602
fbshipit-source-id: 3254eff3f4be417d969fb41116484e350b249530
Summary:
* Added new helper readProcessIdsForPath to common/utils to obtain a list of pids that have open files/paths in the specified path.
* Integrated readProcessIdsForPath into the NFS heavy fetch detection logic - enumerating over mount points and collecting the pids for each that have open files therein.
Reviewed By: MichaelCuevas
Differential Revision: D47276991
fbshipit-source-id: bfee34718a23ab5aca7ebff32577374dadd35af9
Summary:
* Added new helper readProcessIdsForPath to common/utils to obtain a list of pids that have open files/paths in the specified path.
* Integrated readProcessIdsForPath into the NFS heavy fetch detection logic - enumerating over mount points and collecting the pids for each that have open files therein.
Reviewed By: genevievehelsel
Differential Revision: D47202675
fbshipit-source-id: c00c0cf95822678769a01701981c725360107c99
Summary:
* Added experimental config settings to control NFS heavy fetch detection
* Added periodic task to fire and detect for NFS heavy fetching based on controllable threshold
Reviewed By: mshroyer
Differential Revision: D47172825
fbshipit-source-id: 2b4f3da0df52e67288bcb8a874989500e50d2bb4
Summary: A copy_blobstore_keys is a small utility binary that can be used to restore lost blobs from backup repositories. This diff migrates copy_blobstore_keys from dated framework to a new command-line argument parsing and initialisation framework.
Reviewed By: mitrandir77
Differential Revision: D47247626
fbshipit-source-id: f64f1cabdb314e91fcd89b3934f0fd79a55f5642
Summary:
EdenFS has a command eden rage which users run before posting to our Workplace user group. This command collects debugging diagnostics and puts them in a paste. Sometimes, users can have a broken EdenFS instance if their open file limit is misconfigured. Adding the machine's file limit will help our team identify these issues. Right now, we might have to ask a user to run ulimit -a after we look at their post. This back and forth causes some friction. Adding this information to the rage would remove the need for this back and forth.
The Linux version of the "System load" section was missing a blank line at the end, so I added that.
Reviewed By: xavierd
Differential Revision: D47228835
fbshipit-source-id: 418a224d6277d86e6200ee69d771cf55eb10d4e1
Summary:
remove deprecated code
I have verified in mononoke test perf the api is not used.
Also, deprecated client side.
Reviewed By: markbt
Differential Revision: D47292080
fbshipit-source-id: 644b79e44aa898f0a6f8aafb1924ceb4c1c7ccca
Summary: These are not just used for hooks, so make that clear in the error message, and make it clear which variant we hit.
Reviewed By: clara-9
Differential Revision: D47214878
fbshipit-source-id: 94d1b78df782d53f07807e8faac95c15d84e11e6
Summary: When rolling out the symlinks feature, it will be better if we had different options for enabling it on EdenFS or other places. This allows the `experimental.windows-symlinks` option to specifically set a list, pontentially including`edenfs`, `watchman`, or `no-fsmonitor` alongside boolean values to achieve this.
Reviewed By: quark-zju
Differential Revision: D47239158
fbshipit-source-id: 7b5b567d34369f0a51613a39802974701d4663d6
Summary: Seems that [the changelog doesn't list any excessively breaking changes](https://github.com/tokio-rs/tokio/blob/master/tokio-util/CHANGELOG.md), and it's needed to add http/3 support for reqwest.
Reviewed By: zertosh
Differential Revision: D47246722
fbshipit-source-id: 260f8b82bd63725f4c70a48271146dfe4dc1dce8
Summary: Generalize the tooltip on the pull button to depend on the selected pull option.
Reviewed By: quark-zju
Differential Revision: D47247600
fbshipit-source-id: 70a969573a8616b623702a95142770fc213809ad
Summary: We had logic to check if the ongoing or next queued operation is PullOperation. This needs to be generalized to support any pull operation, which can be defined in the configured PullButtonOption.
Reviewed By: quark-zju
Differential Revision: D47246966
fbshipit-source-id: 01182b67f10471ab41fb77a5f3a52e1c80e336c3
Summary: Command runners other than Sapling were not rendering their command in the command history view.
Reviewed By: quark-zju
Differential Revision: D47246445
fbshipit-source-id: c29cde6abd4967c4bbafedf25c5a6a8ed31fa51f
Summary: If you change your pull button choice, persist it via a config like we do for other settings. This way if you reload the page, your choice is remembered.
Reviewed By: quark-zju
Differential Revision: D47246444
fbshipit-source-id: d06a89187470db9903c37c73d1db04bf13e8df62
Summary: Use VSCodeDropdownButton component to support a list of pull button options. This allows us to support arc pull internally. I think we can also put other features like pulling a specific commit here.
Reviewed By: quark-zju
Differential Revision: D47246448
fbshipit-source-id: 15e89b14088ab8f06f9b33c87fff6edc217cfe3f
Summary:
Add a dropdown button component. This behaves like a button with a selection dropdown chevron next to it. Changing the selection via the chevron's dropdown menu changes the button text. Then, clicking the button runs that particular action.
This lets us have buttons which have built-in options / multiple valid choices. For example, we can use this for changing the submit button to Submit Draft for a draft PR/Diff.
This component is implemented as a controlled component, so the caller tracks the current selection and update the state outside the component. Typically, we'll want to persist your button choice or otherwise use an atom for it, so the responsibility is in the caller.
Reviewed By: quark-zju
Differential Revision: D43557610
fbshipit-source-id: 557418a2cf0a42255355c65fa6a21f439ac129c3
Summary: This diff allows the new admin tool to log errors into a given file
Reviewed By: mitrandir77
Differential Revision: D47226107
fbshipit-source-id: 1b51f0f0635ce2b0163a837e4770d742cfe84f87
Summary:
New admin tool bulk unlinking adding a new error logging funciton.
Next diff is going to implement the error logging function, so that we can write the error into a given file
Reviewed By: mitrandir77
Differential Revision: D47226108
fbshipit-source-id: ce6de8a1ca92855414a933099e29b3f33ba8ddbb
Summary:
There are [some places in our codebase](https://www.internalfb.com/code/fbsource/[b4c1becb3f0d5c9df5c8ba2ac1f029ef3ba71bf9]/fbcode/eden/fs/model/TreeEntry.cpp?lines=84) that check for the mode of a TreeEntry using the macros defined at `DirType.h` on Windows.
Before the changes made in this commit, symlinks would get classified as regular files since we only used to check if the bits in one type matched another. The mode for regular files is `0x8000`, and the one for symlinks is `0xA000`. `0x8000 & 0xA000` is `0x8000`.
It seems like we are only using the first byte for determining the TreeEntry type, and then using the remaining three bytes for Unix-style filesystem permissions, so this change should be fine.
Reviewed By: xavierd
Differential Revision: D46860406
fbshipit-source-id: e00ade0c597d856ccba05a372264e6a5532e08f4
Summary: Log file merge conflicts, so we can reproduce conflicts locally and analyze them
Reviewed By: quark-zju
Differential Revision: D47230778
fbshipit-source-id: 1ab4dd10929788d9caed6df899762e5ad2ccf570
Summary:
We would say "last pulled 2 hours ago" or similar when you hover the pull button. Technically, this is not true. The time we show is the newest commit in the history's age.
Internally, commits in large repos come fast enough that you probably wouldn't notice the difference between "last pull" and "newest commit". But in OSS repos, it's quite easy to have the newest commit much older than when you last pulled.
So more precise wording here makes it seem less wrong.
Reviewed By: quark-zju
Differential Revision: D47238973
fbshipit-source-id: c5594197f35d37ee48b8683ca74f0a79704aaca0
Summary: This tooltip was saying "Whether to submit these 0 diffs as a draft" if you were making a new commit. That's never correct, we should just update the number to 1 if it would have been 0. This happens when making a new commit because our list of commits to submit is empty.
Reviewed By: quark-zju
Differential Revision: D47238271
fbshipit-source-id: 2585386f8c717e34f0bbac6c67b985267b4891a3
