mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
ffd60c01b0
Summary: batch_derive() is a dangerous function to use. I'd love to delete it but this function is very useful for backfilling, so unfortunately I can't. The problem arises when one tries to backfill blame and unodes simultaneously (or just derive blame which in turn derives unodes). While batch_derive() tries to be careful with inserting "outer" derived data's mappings (i.e. blame mapping), it doesn't do it for inner derived data mappings (i.e. unodes). So we might end up in the situation where we insert unodes mapping before we inserted all the manifests for it. If this thing fails in the middle of derivation then we have a corruption. Let's do not use it in blobimport. It will make derivation slower, but I'd rather make it slower than incorrect. Reviewed By: farnz Differential Revision: D21905619 fbshipit-source-id: c0227df195a8cf4482b2452ca928acbc5750b3e5 |
||
---|---|---|
.. | ||
dry_run.rs | ||
main.rs | ||
warmup.rs |