mirror of
https://github.com/facebook/sapling.git
synced 2024-10-13 02:07:31 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
36 lines
981 B
Python
36 lines
981 B
Python
import string
|
|
|
|
from mercurial.i18n import _
|
|
|
|
|
|
def reposetup(ui, repo):
|
|
ui.setconfig("hooks", "pretxncommit.checkmessage", checkcommitmessage)
|
|
|
|
|
|
def checkcommitmessage(ui, repo, **kwargs):
|
|
"""
|
|
Checks a single commit message for adherence to commit message rules.
|
|
"""
|
|
hg_commit_message = repo["tip"].description()
|
|
try:
|
|
hg_commit_message.decode("utf8")
|
|
except UnicodeDecodeError:
|
|
ui.warn(_("commit message is not utf-8\n"))
|
|
return True
|
|
|
|
printable = set(string.printable)
|
|
badlines = []
|
|
for lnum, line in enumerate(hg_commit_message.splitlines()):
|
|
for c in line:
|
|
if ord(c) < 128 and c not in printable:
|
|
badlines.append((lnum + 1, line))
|
|
break
|
|
|
|
if badlines:
|
|
ui.warn(_("non-printable characters in commit message\n"))
|
|
for num, l in badlines:
|
|
ui.warn(_("Line {}: {!r}\n".format(num, l)))
|
|
|
|
# False means success
|
|
return bool(badlines)
|