mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
015331583d
Summary: HgBlobEntry is kind of a problematic type right now: - It has no typing to indicate if it's a file or a manifest - It always has a file type, but we only sometimes care about it This results in us using `HgBlobEntry` to sometimes represent `Entry<HgManifestId, (FileType, HgFileNodeId)>`, and some other times to represent `Entry<HgManifestId, HgFileNodeId>`. This makes code a) confusing, b) harder to refactor because you might be having to change unrelated code that cares for the use case you don't care about (i.e. with or without the FileType), and c) results in us sometimes just throwing in a `FileType::Normal` because we don't care about the type, which is prone to breaking stuff. So, this diff just removes it, and replaces it with the appropriate types. Reviewed By: farnz Differential Revision: D25122291 fbshipit-source-id: e9c060c509357321a8059d95daf22399177140f1 |
||
|---|---|---|
| .. | ||
| bundle_replay_data | ||
| bundles | ||
| mutation | ||
| revlog | ||
| types | ||