mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 14:58:03 +03:00
e0c23ea593
Summary: From wez's description (slightly edited): a symlink direction resolves outside the repo, and the new validation logic doesn't like that. the test is doing a redirect add bind then redirect add symlink. The second add is intended to implicitly delete the first one if the config is different, but it's not smart enough to realize that that is happening. This adds an explicit `redirect del` before we do our second `redirect add` Reviewed By: xavierd Differential Revision: D25405011 fbshipit-source-id: 107fd272bbe830d8b23e437286ced00460902d91
306 lines
10 KiB
Python
306 lines
10 KiB
Python
#!/usr/bin/env python3
|
|
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2.
|
|
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
from eden.fs.cli.util import mkscratch_bin
|
|
|
|
from .lib import testcase
|
|
|
|
|
|
def scratch_path(repo: str, subdir: str) -> str:
|
|
return (
|
|
subprocess.check_output(
|
|
[os.fsdecode(mkscratch_bin()), "path", repo, "--subdir", subdir]
|
|
)
|
|
.decode("utf-8")
|
|
.strip()
|
|
)
|
|
|
|
|
|
@testcase.eden_repo_test
|
|
class RedirectTest(testcase.EdenRepoTest):
|
|
"""Exercise the `eden redirect` command"""
|
|
|
|
maxDiff = None
|
|
|
|
def populate_repo(self) -> None:
|
|
self.repo.write_file("hello", "hola\n")
|
|
self.repo.write_file("adir/file", "foo!\n")
|
|
self.repo.symlink("slink", "hello")
|
|
self.repo.write_file(
|
|
".eden-redirections",
|
|
"""\
|
|
[redirections]
|
|
via-profile = "bind"
|
|
""",
|
|
)
|
|
self.repo.commit("Initial commit.")
|
|
|
|
def test_list_no_legacy_bind_mounts(self) -> None:
|
|
output = self.eden.run_cmd("redirect", "list", "--json", "--mount", self.mount)
|
|
profile_path = scratch_path(self.mount, "edenfs/redirections/via-profile")
|
|
self.assertEqual(
|
|
json.loads(output),
|
|
[
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
}
|
|
],
|
|
)
|
|
|
|
def test_disallow_bind_mount_outside_repo(self) -> None:
|
|
dir_to_mount = os.path.join(self.tmp_dir, "to-mount")
|
|
os.mkdir(dir_to_mount)
|
|
mount_point = os.path.join(self.tmp_dir, "mount-point")
|
|
os.mkdir(mount_point)
|
|
|
|
mount_point_bytes = mount_point.encode("utf-8")
|
|
dir_to_mount_bytes = dir_to_mount.encode("utf-8")
|
|
with self.get_thrift_client() as client:
|
|
with self.assertRaises(Exception) as ctx:
|
|
client.addBindMount(
|
|
mount_point_bytes, mount_point_bytes, dir_to_mount_bytes
|
|
)
|
|
self.assertIn(
|
|
"is not known to this eden instance",
|
|
str(ctx.exception),
|
|
msg="Can't specify an arbitrary mount point",
|
|
)
|
|
|
|
with self.assertRaises(Exception) as ctx:
|
|
client.addBindMount(
|
|
self.mount.encode("utf-8"), mount_point_bytes, dir_to_mount_bytes
|
|
)
|
|
self.assertIn(
|
|
f"attempt to construct a RelativePath from an absolute path string: {mount_point}",
|
|
str(ctx.exception),
|
|
msg="Can't mount outside the repo via absolute path",
|
|
)
|
|
|
|
rel_mount = os.path.relpath(mount_point, self.mount).encode("utf-8")
|
|
with self.assertRaises(Exception) as ctx:
|
|
client.addBindMount(
|
|
self.mount.encode("utf-8"), rel_mount, dir_to_mount_bytes
|
|
)
|
|
self.assertIn(
|
|
"PathComponent must not be . or ..",
|
|
str(ctx.exception),
|
|
msg="Can't mount outside the repo via relative path",
|
|
)
|
|
|
|
def test_list(self) -> None:
|
|
repo_path = os.path.join("a", "new-one")
|
|
profile_path = scratch_path(self.mount, "edenfs/redirections/via-profile")
|
|
output = self.eden.run_cmd("redirect", "list", "--json", "--mount", self.mount)
|
|
self.assertEqual(
|
|
json.loads(output),
|
|
[
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
}
|
|
],
|
|
msg="We can interpret the saved bind mount configuration",
|
|
)
|
|
|
|
output = self.eden.run_cmd(
|
|
"redirect", "add", "--mount", self.mount, repo_path, "bind"
|
|
)
|
|
self.assertEqual(output, "", msg="we believe we set up a new bind mount")
|
|
|
|
list_output = self.eden.run_cmd(
|
|
"redirect", "list", "--json", "--mount", self.mount
|
|
)
|
|
target_path = scratch_path(self.mount, "edenfs/redirections/a/new-one")
|
|
self.assertEqual(
|
|
json.loads(list_output),
|
|
[
|
|
{
|
|
"repo_path": repo_path,
|
|
"type": "bind",
|
|
"target": target_path,
|
|
"source": ".eden/client/config.toml:redirections",
|
|
"state": "ok",
|
|
},
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
},
|
|
],
|
|
msg="saved config agrees with last output",
|
|
)
|
|
|
|
if sys.platform != "win32":
|
|
mount_stat = os.stat(self.mount)
|
|
bind_mount_stat = os.stat(os.path.join(self.mount, repo_path))
|
|
self.assertNotEqual(
|
|
mount_stat.st_dev,
|
|
bind_mount_stat.st_dev,
|
|
msg="new-one dir was created and mounted with a different device",
|
|
)
|
|
else:
|
|
# On Windows we use symlink to implement bind mount type
|
|
# redirection. As a result `st_dev` check will fail so we check if
|
|
# the symlink is pointing actually outside of the repository.
|
|
redirection = os.path.join(self.mount, repo_path)
|
|
link_target = os.readlink(redirection)
|
|
|
|
# This checks if the common parent of redirection target and the
|
|
# repository is still in the mount (i.e. if redirection target is a
|
|
# subdirectory of the mount).
|
|
self.assertNotEqual(
|
|
os.path.commonprefix([self.mount, link_target]),
|
|
self.mount,
|
|
msg="Redirection target is still inside the repository.",
|
|
)
|
|
|
|
output = self.eden.run_cmd(
|
|
"redirect",
|
|
"del",
|
|
"--mount",
|
|
self.mount,
|
|
repo_path,
|
|
)
|
|
self.assertEqual(output, "", msg="we believe we removed the bind mount")
|
|
output = self.eden.run_cmd(
|
|
"redirect", "add", "--mount", self.mount, repo_path, "symlink"
|
|
)
|
|
self.assertEqual(output, "", msg="we believe we switched to a symlink")
|
|
|
|
list_output = self.eden.run_cmd(
|
|
"redirect", "list", "--json", "--mount", self.mount
|
|
)
|
|
self.assertEqual(
|
|
json.loads(list_output),
|
|
[
|
|
{
|
|
"repo_path": repo_path,
|
|
"type": "symlink",
|
|
"target": target_path,
|
|
"source": ".eden/client/config.toml:redirections",
|
|
"state": "ok",
|
|
},
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
},
|
|
],
|
|
msg="saved config agrees with last output",
|
|
)
|
|
|
|
self.assertEqual(
|
|
Path(os.readlink(os.path.join(self.mount, "a", "new-one"))).resolve(),
|
|
Path(target_path).resolve(),
|
|
msg="symlink points to scratch space",
|
|
)
|
|
|
|
output = self.eden.run_cmd("redirect", "del", "--mount", self.mount, repo_path)
|
|
self.assertEqual(output, "", msg="we believe we removed the symlink")
|
|
|
|
list_output = self.eden.run_cmd(
|
|
"redirect", "list", "--json", "--mount", self.mount
|
|
)
|
|
self.assertEqual(
|
|
json.loads(list_output),
|
|
[
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
}
|
|
],
|
|
msg="saved config agrees with last output",
|
|
)
|
|
|
|
self.assertFalse(
|
|
os.path.exists(os.path.join(self.mount, "a", "new-one")),
|
|
msg="symlink is gone",
|
|
)
|
|
|
|
def test_fixup_mounts_things(self) -> None:
|
|
profile_path = scratch_path(self.mount, "edenfs/redirections/via-profile")
|
|
|
|
output = self.eden.run_cmd("redirect", "list", "--json", "--mount", self.mount)
|
|
self.assertEqual(
|
|
json.loads(output),
|
|
[
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
}
|
|
],
|
|
)
|
|
self.eden.run_cmd("redirect", "fixup", "--mount", self.mount)
|
|
output = self.eden.run_cmd("redirect", "list", "--json", "--mount", self.mount)
|
|
self.assertEqual(
|
|
json.loads(output),
|
|
[
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
}
|
|
],
|
|
)
|
|
|
|
def test_unmount_unmounts_things(self) -> None:
|
|
profile_path = scratch_path(self.mount, "edenfs/redirections/via-profile")
|
|
|
|
output = self.eden.run_cmd("redirect", "list", "--json", "--mount", self.mount)
|
|
self.assertEqual(
|
|
json.loads(output),
|
|
[
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "ok",
|
|
}
|
|
],
|
|
)
|
|
self.eden.run_cmd("redirect", "unmount", "--mount", self.mount)
|
|
output = self.eden.run_cmd("redirect", "list", "--json", "--mount", self.mount)
|
|
self.assertEqual(
|
|
json.loads(output),
|
|
[
|
|
{
|
|
"repo_path": "via-profile",
|
|
"type": "bind",
|
|
"target": profile_path,
|
|
"source": ".eden-redirections",
|
|
"state": "not-mounted"
|
|
if sys.platform != "win32"
|
|
else "symlink-missing",
|
|
}
|
|
],
|
|
)
|