mirror of
https://github.com/facebook/sapling.git
synced 2024-10-08 07:49:11 +03:00
9df2b10ec0
I've spent several hours over the past few weeks investigating networking failures involving hg.mozilla.org. As part of this, it has become clear that the Mercurial client's error handling when it encounters network failures is far from robust. To prove this is true, I've devised a battery of tests simulating various network failures, notably premature connection closes. To achieve this, I've implemented an extension that monkeypatches the built-in HTTP server and hooks in at the socket level and allows various events to occur based on config options. For example, you can refuse to accept() a client socket or you can close() the socket after N bytes have been sent or received. The latter effectively simulates an unexpected connection drop (and these occur all the time in the real world). The new test file launches servers exhibiting various "bad" behaviors and points a client at them. As the many TODO comments in the test call attention to, Mercurial often displays unhelpful errors when network-related failures occur. This makes it difficult for users to understand what's going on and difficult for server administrators to pinpoint root causes without packet tracing. Upcoming patches will attempt to fix these error handling deficiencies.
78 lines
2.6 KiB
Perl
78 lines
2.6 KiB
Perl
#require test-repo
|
|
|
|
$ . "$TESTDIR/helpers-testrepo.sh"
|
|
$ check_code="$TESTDIR"/../contrib/check-code.py
|
|
$ cd "$TESTDIR"/..
|
|
|
|
New errors are not allowed. Warnings are strongly discouraged.
|
|
(The writing "no-che?k-code" is for not skipping this file when checking.)
|
|
|
|
$ hg locate -X contrib/python-zstandard -X hgext/fsmonitor/pywatchman |
|
|
> sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
|
|
contrib/perf.py:869:
|
|
> r.revision(r.node(x))
|
|
don't convert rev to node before passing to revision(nodeorrev)
|
|
Skipping i18n/polib.py it has no-che?k-code (glob)
|
|
mercurial/demandimport.py:313:
|
|
> if os.environ.get('HGDEMANDIMPORT') != 'disable':
|
|
use encoding.environ instead (py3)
|
|
mercurial/encoding.py:54:
|
|
> environ = os.environ
|
|
use encoding.environ instead (py3)
|
|
mercurial/encoding.py:56:
|
|
> environ = os.environb
|
|
use encoding.environ instead (py3)
|
|
mercurial/encoding.py:61:
|
|
> for k, v in os.environ.items())
|
|
use encoding.environ instead (py3)
|
|
mercurial/encoding.py:221:
|
|
> for k, v in os.environ.items())
|
|
use encoding.environ instead (py3)
|
|
Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
|
|
Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
|
|
mercurial/policy.py:46:
|
|
> if 'HGMODULEPOLICY' in os.environ:
|
|
use encoding.environ instead (py3)
|
|
mercurial/policy.py:47:
|
|
> policy = os.environ['HGMODULEPOLICY'].encode('utf-8')
|
|
use encoding.environ instead (py3)
|
|
mercurial/policy.py:49:
|
|
> policy = os.environ.get('HGMODULEPOLICY', policy)
|
|
use encoding.environ instead (py3)
|
|
Skipping mercurial/statprof.py it has no-che?k-code (glob)
|
|
Skipping tests/badserverext.py it has no-che?k-code (glob)
|
|
[1]
|
|
|
|
@commands in debugcommands.py should be in alphabetical order.
|
|
|
|
>>> import re
|
|
>>> commands = []
|
|
>>> with open('mercurial/debugcommands.py', 'rb') as fh:
|
|
... for line in fh:
|
|
... m = re.match("^@command\('([a-z]+)", line)
|
|
... if m:
|
|
... commands.append(m.group(1))
|
|
>>> scommands = list(sorted(commands))
|
|
>>> for i, command in enumerate(scommands):
|
|
... if command != commands[i]:
|
|
... print('commands in debugcommands.py not sorted; first differing '
|
|
... 'command is %s; expected %s' % (commands[i], command))
|
|
... break
|
|
|
|
Prevent adding new files in the root directory accidentally.
|
|
|
|
$ hg files 'glob:*'
|
|
.editorconfig
|
|
.hgignore
|
|
.hgsigs
|
|
.hgtags
|
|
CONTRIBUTING
|
|
CONTRIBUTORS
|
|
COPYING
|
|
Makefile
|
|
README
|
|
hg
|
|
hgeditor
|
|
hgweb.cgi
|
|
setup.py
|