mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 08:18:15 +03:00
5a150e125a
Summary: While clang has no issue compiling this code, gcc appears to choke on it, failing to compile. This is unfortunate as this means we need to hardcode the size of the serialized datastructure and validate it with a test. Reviewed By: fanzeyi Differential Revision: D27243075 fbshipit-source-id: 5cd59921bbd5d5be4dfb22789942eb022dac5bbe
63 lines
1.6 KiB
C++
63 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This software may be used and distributed according to the terms of the
|
|
* GNU General Public License version 2.
|
|
*/
|
|
|
|
#ifndef _WIN32
|
|
|
|
#include "eden/fs/nfs/DirList.h"
|
|
|
|
namespace facebook::eden {
|
|
|
|
namespace {
|
|
|
|
/**
|
|
* Hardcoded static overhead of READDIR3resok before adding any entries.
|
|
* Ideally we should make XdrTrait<T>::serializedSize a constexpr, but some
|
|
* compiler (gcc) don't seem to be able to then compile the code. Thus, this
|
|
* value is hardcoded here and verified in the DirListTest.
|
|
*/
|
|
constexpr size_t kInitialOverhead = 104u;
|
|
|
|
/**
|
|
* NFS is weird, it specifies the maximum amount of entries to be returned by
|
|
* passing the total size of the READDIR3resok structure, therefore we need to
|
|
* account for all the overhead.
|
|
*/
|
|
uint32_t computeInitialRemaining(uint32_t count) {
|
|
if (kInitialOverhead > count) {
|
|
throw std::length_error(
|
|
"NFS READDIR overhead is bigger than the passed in size");
|
|
}
|
|
return count - kInitialOverhead;
|
|
}
|
|
} // namespace
|
|
|
|
NfsDirList::NfsDirList(uint32_t count)
|
|
: remaining_(computeInitialRemaining(count)) {}
|
|
|
|
bool NfsDirList::add(
|
|
folly::StringPiece name,
|
|
InodeNumber ino,
|
|
uint64_t offset) {
|
|
auto entry = entry3{ino.get(), name.str(), offset};
|
|
// The serialized size includes a boolean indicating that this is not the end
|
|
// of the list.
|
|
auto neededSize = XdrTrait<entry3>::serializedSize(entry) +
|
|
XdrTrait<bool>::serializedSize(true);
|
|
|
|
if (neededSize > remaining_) {
|
|
return false;
|
|
}
|
|
|
|
remaining_ -= neededSize;
|
|
list_.list.push_back(std::move(entry));
|
|
return true;
|
|
}
|
|
|
|
} // namespace facebook::eden
|
|
|
|
#endif
|