sapling/eden
Adam Simpkins 0aef86d323 update HgImporter::importFileContents() to return a Blob
Summary:
Change HgImporter::importFileContents() to return a Blob object rather than
just the IOBuf.

This shouldn't have any behavior changes.  However, it might help track down
some of the cases where we have seen files get incorrectly imported with empty
contents in some rare cases.  We're not sure what is causing that, but
incorrectly using a moved-from IOBuf object would be one thing that might
produce this behavior.  By changing this code to a `unique_ptr<Blob>` will
will eliminate the possibility of seeing empty buffer contents if some code
path is somehow ever able to use one of these objects after they have been
moved away from.  (The code would end up with a null pointer in this case
rather than an empty buffer.  If this ever does occur in practice a null
pointer would make the problem more obvious than an empty buffer.)

Reviewed By: chadaustin

Differential Revision: D9494651

fbshipit-source-id: 799cc1b1d0e2ac32ae2013dc80c84ec17cc1c491
2018-08-24 15:52:23 -07:00
..
cli fix some type errors in debug.py 2018-08-23 12:07:15 -07:00
docs store FileInode and TreeInode timestamps in the InodeTable 2018-05-22 11:22:19 -07:00
fs update HgImporter::importFileContents() to return a Blob 2018-08-24 15:52:23 -07:00
hooks ensure .hg has read and search permissions for group/other 2018-06-11 22:33:11 -07:00
integration fix dirstate.walk()'s handling of ignored symlinks 2018-08-23 15:07:02 -07:00
py enable typechecking on Eden Python libraries 2018-08-03 15:07:00 -07:00
scripts unmount stale edenfs mounts in eden doctor 2018-01-19 11:06:51 -08:00
test-data put the overlay test data into a tar file 2018-06-20 18:36:27 -07:00
third-party Remove TARGETS files 2018-02-20 19:57:45 -08:00
win Started Eden for Windows and integrated hg store with it. 2018-08-21 17:53:38 -07:00
AUTODEPS Set up arc lint to run autodeps automatically for Eden. 2017-11-21 18:23:41 -08:00
Eden.project.toml Eden.project.toml file for Nuclide 2018-04-26 11:05:23 -07:00