sapling/eden/mononoke/cmdlib
Michael Samoylenko e156bbd676 Allow more read-connection-types when creating SqlConnections
Summary:
I want to use `ReplicaFirst` read connection type since `ReplicaOnly` is a bit too restrictive.

We've had 2 MySQL SEVs this year when all the replicas went down crashing our services despite the primary instance working normally.
There was also a case when I've deleted too much rows at once and all replicas went down due to replication lag (I know better now)

RFC
- Yay or Nay?
- Should I expand `ReadConnectionType` to mirror all options of `InstanceRequirement`?
- Perhaps it's worth moving it into the `common/rust/shed/sql` crate?

I kept cleaning up all the usages out of this diff to keep the changes minimal for RFC

Differential Revision: D30574326

fbshipit-source-id: 1462b238305d47557372afe7763096c53df55f10
2021-09-06 14:40:47 -07:00
..
environment third-party/rust: update daemonize to 0.5 2021-09-02 06:27:03 -07:00
src Allow more read-connection-types when creating SqlConnections 2021-09-06 14:40:47 -07:00
x_repo third-party/rust: update daemonize to 0.5 2021-09-02 06:27:03 -07:00
Cargo.toml third-party/rust: update strum 2021-09-02 11:26:28 -07:00