sapling/bundle2_resolver
Thomas Orozco 0b3cd11c26 mononoke: verify bookmark namespace even during pushrebase
Summary:
We accidentally were not verifying the bookmark namespace (with regard to infinitepush) when performing a pushrebase.

This is a problem, because it means if a pushrebase was performed into the infinitepush namespace, then the push would be allowed. This could happen by accident (the earlier diff in this stack fixes a Mercurial bug that did this), or simply if the end-user changes their infinitepush branchpattern.

This patch fixes the bug, and extracts the "do basic checks for whether this bookmark can move" logic into a single function to minimize the potential for this validation logic diverging again between pushrebase and push.

Reviewed By: ikostia

Differential Revision: D15576198

fbshipit-source-id: 24cf9999a7370503e5e0173e34185d9aa57903f7
2019-05-31 08:57:06 -07:00
..
obsolete/src mononoke: add obsmarkers to pushrebase output 2019-05-21 12:25:17 -07:00
pushrebase/src mononoke: support non-publishing / non-pull_default Bookmarks 2019-05-30 07:14:32 -07:00
scribe_commit_queue/src Log pushrebase commits to scribe 2019-03-12 04:50:45 -07:00
src mononoke: verify bookmark namespace even during pushrebase 2019-05-31 08:57:06 -07:00
wirepack/src mononoke: rename crates to contain underscores instead of dashes 2019-03-06 07:18:28 -08:00
Cargo.toml mononoke: rename crates to contain underscores instead of dashes 2019-03-06 07:18:28 -08:00