mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
0b3cd11c26
Summary: We accidentally were not verifying the bookmark namespace (with regard to infinitepush) when performing a pushrebase. This is a problem, because it means if a pushrebase was performed into the infinitepush namespace, then the push would be allowed. This could happen by accident (the earlier diff in this stack fixes a Mercurial bug that did this), or simply if the end-user changes their infinitepush branchpattern. This patch fixes the bug, and extracts the "do basic checks for whether this bookmark can move" logic into a single function to minimize the potential for this validation logic diverging again between pushrebase and push. Reviewed By: ikostia Differential Revision: D15576198 fbshipit-source-id: 24cf9999a7370503e5e0173e34185d9aa57903f7 |
||
---|---|---|
.. | ||
obsolete/src | ||
pushrebase/src | ||
scribe_commit_queue/src | ||
src | ||
wirepack/src | ||
Cargo.toml |