Stanislau Hlebik 79dda5ed04 mononoke: log public commits to scribe from scs move/create_bookmark method ... Summary: The goal of this stack is to start logging commits to scribe even if a commit was introduced by scs create_commit/move_bookmark api. Currently we don't do that. Initially I had bigger plans and I wanted to log to scribe only from bookmarks_movement and remove scribe logging from unbundle/processing.rs, but it turned out to be trickier to implement. In general, the approach we use right now where in order to log to scribe we need to put `log_commit_to_scribe` call in all the places that can possibly create commits/move bookmarks seems wrong, but changing it is a bit hard. So for now I decided to solve the main problem we have, which is the fact that we don't get scribe logs from repos where bookmarks is moved via scs methods. To fix that I added an additional option to CreateBookmark/UpdateBookmark structs. If this option is set to true then before moving/creating the bookmark it finds all draft commits that are going to be made public by the bookmark move i.e. all draft ancestors of new bookmark destinationl. This is unfortunate that we have to do this traversal on the critical path of the move_bookmark call, but in practice I hope it won't be too bad since we do similar traversal to record bonsai<->git mappings. In case my hopes are wrong we have scuba logging which should make it clear that this is an expensive operation and also we have a tunable to disable this behavioiur. Also note that we don't use PushParams::commit_scribe_category. This is intentional - PushParams::commit_scribe_category doesn't seem useful at all, and I plan to deprecate it later in the stack. Even later it would make sense to deprecate PushrebaseParams::commit_scribe_category as well, and put commit_scribe_category optoin in another place in the config. Reviewed By: markbt Differential Revision: D25558248 fbshipit-source-id: f7dedea8d6f72ad40c006693d4f1a265977f843f		2020-12-17 00:19:00 -08:00
..
src	mononoke: log public commits to scribe from scs move/create_bookmark method	2020-12-17 00:19:00 -08:00
metadata.cpp	add thrift metadata support	2020-09-03 12:18:18 -07:00
metadata.h	add thrift metadata support	2020-09-03 12:18:18 -07:00
metadata.rs	Remove extern crate from bindgen src_includes	2020-12-14 12:53:36 -08:00