mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 23:38:50 +03:00
13d7be97ea
Summary: When running edenfs in daemonize mode (i.e. when --foreground is not specified), the daemon process inherits stdin from the parent and never closes it. This has two consequences: * The daemon process holds a reference to stdin even after the parent exits. This causes tests to hang if they wait for EPIPE on stdin after waiting for the parent process to exit. (I discovered this issue when adding tests for 'eden start' in D10434379.) * edenfs could potentially read from the terminal after 'eden start' has returned. I think this behavior is surprising and could potentially cause problems. Promptly close stdin after forking the daemon process, since nothing inside the daemon needs stdin. Reviewed By: simpkins Differential Revision: D10442346 fbshipit-source-id: f3d287e8b48e121807f845b73a1a550e63efae25 |
||
---|---|---|
.. | ||
config | ||
fuse | ||
inodes | ||
journal | ||
model | ||
rocksdb | ||
service | ||
sqlite | ||
store | ||
takeover | ||
testharness | ||
utils | ||
CMakeLists.txt |